You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@tomcat.apache.org by evernat <ev...@free.fr> on 2015/06/14 16:56:04 UTC
Re: Tomcat occasionally duplicating responses
> On Mon, May 18, 2015 at 12:30 PM, Mark Thomas <markt <at> apache.org> wrote:
> Once a request/response has been put into async mode, control passes to
> the async processing. i.e. from that point onwards the container should
> not be writing to the response until the application returns control to
> the container via a dispatch.
>
> If you look at the this line of code [1], javamelody is flushing the
> response. There needs to be an if (!request.isAsyncStarted()) {...}
> around that code.
>
> [1]
>
https://code.google.com/p/javamelody/source/browse/trunk/javamelody-core/
src/main/java/net/bull/javamelody/MonitoringFilter.java#199
About this javamelody and async issue, the change for flushBuffer looks good
and it's merged now. Thanks.
Note that there is one known issue with javamelody and some (spring-webmvc)
async cases, with empty response. And the above change for flushBuffer does
not fix this issue.
It can be reproduced with Tomcat and not with Jetty, here is the link:
https://code.google.com/p/javamelody/issues/detail?id=338#c6
- Emeric
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org
Re: Tomcat occasionally duplicating responses
Posted by Mark Thomas <ma...@apache.org>.
On 14/06/2015 15:56, evernat wrote:
>> On Mon, May 18, 2015 at 12:30 PM, Mark Thomas <markt <at> apache.org> wrote:
>
>> Once a request/response has been put into async mode, control passes to
>> the async processing. i.e. from that point onwards the container should
>> not be writing to the response until the application returns control to
>> the container via a dispatch.
>>
>> If you look at the this line of code [1], javamelody is flushing the
>> response. There needs to be an if (!request.isAsyncStarted()) {...}
>> around that code.
>>
>> [1]
>>
> https://code.google.com/p/javamelody/source/browse/trunk/javamelody-core/
> src/main/java/net/bull/javamelody/MonitoringFilter.java#199
>
>
> About this javamelody and async issue, the change for flushBuffer looks good
> and it's merged now. Thanks.
Great. Happy to help.
> Note that there is one known issue with javamelody and some (spring-webmvc)
> async cases, with empty response. And the above change for flushBuffer does
> not fix this issue.
> It can be reproduced with Tomcat and not with Jetty, here is the link:
> https://code.google.com/p/javamelody/issues/detail?id=338#c6
Open a Tomcat bug for that and we'll take a look.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org