You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "me2seeks (via GitHub)" <gi...@apache.org> on 2026/10/13 02:32:13 UTC
[I] bug(tui): fullscreen multiline drafts clip status on short terminals [maka]
me2seeks opened a new issue, #6082:
URL: https://github.com/apache/maka/issues/6082
### What happened
Follow-up to #4221 / #4136, tracking the remaining P2 from https://github.com/apache/maka/pull/4221#discussion_r4239570918. me2seeks explicitly accepted this known presentation defect for the Nightly trial and authorized merging #4221 with a follow-up; this issue does not claim the defect is fixed.
With a four-line composer draft, running activity strip and unread banner, fullscreen chrome overflows its allocated height on an 8–10-row terminal. The status line is clipped, and at 8–9 rows the bottom editor border is also clipped. In my reproduction all four draft lines remained visible; no input loss or inability to submit was demonstrated.
Expected: optional activity/unread chrome yields before the composer and status are clipped, while retaining the transcript's reserved row.
### How to reproduce
Enable fullscreen (`MAKA_TUI_FULLSCREEN=1`, or a Nightly build) and resize the terminal to 80 columns by 8–10 rows. Use a four-line draft, a running-turn activity strip and a nonzero unread hint. Real-terminal manual acceptance of this gesture sequence remains to be performed.
Deterministic layout reproduction already run on exact head `e5c4ea5504998bea9ce999972b428896f09aa115`:
1. Instantiate the actual pi-tui `Editor` on `TuiAltScreen` with a terminal fixture of the given dimensions.
2. Set a four-line draft and render it through the production `MakaAutocompleteAboveEditorComponent` to establish its 6-row minimum.
3. Construct the production `MakaFullscreenChromeComponent` with `turnElapsedMs: 1000`, unread feed count 5, no pending messages, and a one-row status sentinel.
4. Render the production `VStack` composition through actual `renderLayoutFrame`, reserving one transcript row and using the PR's intrinsic-height chrome entry.
Observed matrix:
| Terminal rows | Chrome output rows | Chrome allocation | Status visible |
| --- | --- | --- | --- |
| 8 | 10 | 7 | no |
| 9 | 10 | 8 | no |
| 10 | 10 | 9 | no |
| 11 | 10 | 10 | yes |
| 20 | 10 | 10 | yes |
### Environment
- Maka source commit: `e5c4ea5504998bea9ce999972b428896f09aa115` (#4221)
- Surface: fullscreen TUI
- Local validation: Linux, Node.js v26.3.0, exact lockfile dependencies
- Harness: actual Editor, production autocomplete adapter/chrome, actual VStack/layout engine; terminal I/O is a fixture, not a physical terminal
### Logs, screenshots, or additional context
`budgetEditorAndPendingRows` in `packages/cli/src/pi-tui-layout.ts:88` clamps a positive remaining budget to `minimumEditorRows`. This hides the real deficit from the outer squeeze loop (`inputRows >= minimumInputRows`), so activity and unread rows are not dropped as intended.
A candidate correction is to keep the queue-first minimum reservation but return the actual remainder:
```ts
editorRows: Math.max(0, budget - pendingLines.length)
```
I validated this one-line change in an independent compiled-module copy without changing the PR source: the status and complete editor frame fit at 8–10 rows; all 34 existing fullscreen tests still pass. The original head passes all 270 tests across fullscreen-mode, pi-tui-runner and tui-copy-catalog, so a new regression is needed for this combination.
Follow-up acceptance:
- Add a real-editor frame regression covering 8–20 rows with a four-line draft, running activity and unread output; verify complete editor/status visibility rather than only the assigned editor budget.
- Preserve the already-fixed queue-first reservation and localized unread hint.
- Check the corresponding blocking-question and autocomplete cases.
- Validate resizing in an actual terminal before graduating the Nightly trial.
Workarounds: enlarge the terminal, or use `MAKA_TUI_FULLSCREEN=0` to opt out. Release builds keep the main-screen default.
AI disclosure: Codex inspected the implementation, ran the reproduction and tests, and drafted this issue; publication and the accepted Nightly tradeoff were explicitly authorized by me2seeks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [I] bug(tui): fullscreen multiline drafts clip status on short terminals [maka]
Posted by "Dante-dan (via GitHub)" <gi...@apache.org>.
Dante-dan commented on issue #6082:
URL: https://github.com/apache/maka/issues/6082#issuecomment-6138205310
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [I] bug(tui): fullscreen multiline drafts clip status on short terminals [maka]
Posted by "Dante-dan (via GitHub)" <gi...@apache.org>.
Dante-dan commented on issue #6082:
URL: https://github.com/apache/maka/issues/6082#issuecomment-6138204997
I plan to keep this follow-up scoped to the short-terminal chrome budget: preserve the queue-first reservation, but expose the actual remaining editor budget so the squeeze loop can drop activity and unread chrome before clipping the composer or status.
I will add the requested production real-editor/layout-frame regression for 8–20 rows, check complete editor and status visibility with the four-line draft, and cover the corresponding blocking-question and autocomplete behavior. The issue's exact-head results are the starting evidence; I have not independently reproduced them yet. Actual-terminal resize acceptance remains a separate Nightly graduation check.
Codex is assisting with this contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [I] bug(tui): fullscreen multiline drafts clip status on short terminals [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han closed issue #6082: bug(tui): fullscreen multiline drafts clip status on short terminals
URL: https://github.com/apache/maka/issues/6082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org