You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hop.apache.org by GitBox <gi...@apache.org> on 2020/12/20 16:40:51 UTC
[GitHub] [incubator-hop] nadment opened a new pull request #483: HOP-2281 Cleaning images
nadment opened a new pull request #483:
URL: https://github.com/apache/incubator-hop/pull/483
It's a first pass for cleaning images, I probably forgot one image somewhere, but we have until version 0.70 to fix them.
I replace many images with Material Design Icons that are under MIT License: https://dev.materialdesignicons.com/license
If certain images do not please, we can replace them incrementally.
- clean GuiRessource class
- remove unused images (many are in plugins now)
- remove usage of LAF properties file
- new images new, open, save, saveas
- new images run, pause, stop, preview, debug
- new images delete, copy, paste, cut, close, show, hide
- new images folder, bookmark
- new images workflow, workflowexecutor, workflow_run_config, repeat
- new images pipelinew,pipelineexecutor, pipeline_run_config
- new images note, note-add, bookmark-add, folder, folder-add, plugin
- new images input, output, distribute, copy-rows
- new images snap-to-grid, align...
- rename some images
- fix SwtGc.drawTransformIcon to use SVG image
- fix toolbars layout ShowHelpDialog
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva commented on pull request #483: HOP-2281 Cleaning images
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #483:
URL: https://github.com/apache/incubator-hop/pull/483#issuecomment-749436581
`2020/12/22 10:13:08 - GUI - ERROR: Error occurred loading image [repeat.svg] for plugin Repeat
2020/12/22 10:13:08 - GUI - ERROR: java.lang.RuntimeException: org.apache.batik.dom.util.SAXIOException: Element type "svg" must be followed by either attribute specifications, ">" or "/>".
2020/12/22 10:13:08 - GUI - at org.apache.hop.ui.util.SwtSvgImageUtil.loadImage(SwtSvgImageUtil.java:307)
2020/12/22 10:13:08 - GUI - at org.apache.hop.ui.util.SwtSvgImageUtil.loadFromClassLoader(SwtSvgImageUtil.java:214)
2020/12/22 10:13:08 - GUI - at org.apache.hop.ui.util.SwtSvgImageUtil.getUniversalImageInternal(SwtSvgImageUtil.java:153)
2020/12/22 10:13:08 - GUI - at org.apache.hop.ui.util.SwtSvgImageUtil.getUniversalImage(SwtSvgImageUtil.java:177)
2020/12/22 10:13:08 - GUI - at org.apache.hop.ui.core.gui.GuiResource.loadWorkflowActionImages(GuiResource.java:785)
2020/12/22 10:13:08 - GUI - at org.apache.hop.ui.core.gui.GuiResource.getResources(GuiResource.java:368)
2020/12/22 10:13:08 - GUI - at org.apache.hop.ui.core.gui.GuiResource.<init>(GuiResource.java:267)
2020/12/22 10:13:08 - GUI - at org.apache.hop.ui.core.gui.GuiResource.getInstance(GuiResource.java:312)
2020/12/22 10:13:08 - GUI - at org.apache.hop.ui.hopgui.HopGui.open(HopGui.java:321)
2020/12/22 10:13:08 - GUI - at org.apache.hop.ui.hopgui.HopGui.main(HopGui.java:300)
2020/12/22 10:13:08 - GUI - Caused by: org.apache.batik.dom.util.SAXIOException: Element type "svg" must be followed by either attribute specifications, ">" or "/>".
2020/12/22 10:13:08 - GUI - at org.apache.batik.dom.util.SAXDocumentFactory.createDocument(SAXDocumentFactory.java:459)
2020/12/22 10:13:08 - GUI - at org.apache.batik.dom.util.SAXDocumentFactory.createDocument(SAXDocumentFactory.java:357)
2020/12/22 10:13:08 - GUI - at org.apache.batik.anim.dom.SAXSVGDocumentFactory.createDocument(SAXSVGDocumentFactory.java:225)
2020/12/22 10:13:08 - GUI - at org.apache.hop.core.svg.SvgSupport.loadSvgImage(SvgSupport.java:60)
2020/12/22 10:13:08 - GUI - at org.apache.hop.ui.util.SwtSvgImageUtil.loadImage(SwtSvgImageUtil.java:305)
2020/12/22 10:13:08 - GUI - ... 9 more
2020/12/22 10:13:08 - GUI - Caused by: org.xml.sax.SAXParseException; lineNumber: 3; columnNumber: 1; Element type "svg" must be followed by either attribute specifications, ">" or "/>".
2020/12/22 10:13:08 - GUI - at org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.util.ErrorHandlerWrapper.fatalError(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.impl.XMLScanner.reportFatalError(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanStartElement(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.impl.XMLNSDocumentScannerImpl$NSContentDispatcher.scanRootElementHook(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.batik.dom.util.SAXDocumentFactory.createDocument(SAXDocumentFactory.java:453)
2020/12/22 10:13:08 - GUI - ... 13 more
2020/12/22 10:13:08 - GUI - ERROR: Unable to load image [repeat.svg] for plugin Repeat
`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] nadment commented on a change in pull request #483: HOP-2281 Cleaning images
Posted by GitBox <gi...@apache.org>.
nadment commented on a change in pull request #483:
URL: https://github.com/apache/incubator-hop/pull/483#discussion_r547306206
##########
File path: plugins/actions/repeat/src/main/resources/repeat.svg
##########
@@ -1,5 +1,105 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
Review comment:
I replaced the image
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva merged pull request #483: HOP-2281 Cleaning images
Posted by GitBox <gi...@apache.org>.
hansva merged pull request #483:
URL: https://github.com/apache/incubator-hop/pull/483
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva edited a comment on pull request #483: HOP-2281 Cleaning images
Posted by GitBox <gi...@apache.org>.
hansva edited a comment on pull request #483:
URL: https://github.com/apache/incubator-hop/pull/483#issuecomment-749436581
```
2020/12/22 10:13:08 - GUI - ERROR: Error occurred loading image [repeat.svg] for plugin Repeat
2020/12/22 10:13:08 - GUI - ERROR: java.lang.RuntimeException: org.apache.batik.dom.util.SAXIOException: Element type "svg" must be followed by either attribute specifications, ">" or "/>".
2020/12/22 10:13:08 - GUI - at org.apache.hop.ui.util.SwtSvgImageUtil.loadImage(SwtSvgImageUtil.java:307)
2020/12/22 10:13:08 - GUI - at org.apache.hop.ui.util.SwtSvgImageUtil.loadFromClassLoader(SwtSvgImageUtil.java:214)
2020/12/22 10:13:08 - GUI - at org.apache.hop.ui.util.SwtSvgImageUtil.getUniversalImageInternal(SwtSvgImageUtil.java:153)
2020/12/22 10:13:08 - GUI - at org.apache.hop.ui.util.SwtSvgImageUtil.getUniversalImage(SwtSvgImageUtil.java:177)
2020/12/22 10:13:08 - GUI - at org.apache.hop.ui.core.gui.GuiResource.loadWorkflowActionImages(GuiResource.java:785)
2020/12/22 10:13:08 - GUI - at org.apache.hop.ui.core.gui.GuiResource.getResources(GuiResource.java:368)
2020/12/22 10:13:08 - GUI - at org.apache.hop.ui.core.gui.GuiResource.<init>(GuiResource.java:267)
2020/12/22 10:13:08 - GUI - at org.apache.hop.ui.core.gui.GuiResource.getInstance(GuiResource.java:312)
2020/12/22 10:13:08 - GUI - at org.apache.hop.ui.hopgui.HopGui.open(HopGui.java:321)
2020/12/22 10:13:08 - GUI - at org.apache.hop.ui.hopgui.HopGui.main(HopGui.java:300)
2020/12/22 10:13:08 - GUI - Caused by: org.apache.batik.dom.util.SAXIOException: Element type "svg" must be followed by either attribute specifications, ">" or "/>".
2020/12/22 10:13:08 - GUI - at org.apache.batik.dom.util.SAXDocumentFactory.createDocument(SAXDocumentFactory.java:459)
2020/12/22 10:13:08 - GUI - at org.apache.batik.dom.util.SAXDocumentFactory.createDocument(SAXDocumentFactory.java:357)
2020/12/22 10:13:08 - GUI - at org.apache.batik.anim.dom.SAXSVGDocumentFactory.createDocument(SAXSVGDocumentFactory.java:225)
2020/12/22 10:13:08 - GUI - at org.apache.hop.core.svg.SvgSupport.loadSvgImage(SvgSupport.java:60)
2020/12/22 10:13:08 - GUI - at org.apache.hop.ui.util.SwtSvgImageUtil.loadImage(SwtSvgImageUtil.java:305)
2020/12/22 10:13:08 - GUI - ... 9 more
2020/12/22 10:13:08 - GUI - Caused by: org.xml.sax.SAXParseException; lineNumber: 3; columnNumber: 1; Element type "svg" must be followed by either attribute specifications, ">" or "/>".
2020/12/22 10:13:08 - GUI - at org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.util.ErrorHandlerWrapper.fatalError(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.impl.XMLScanner.reportFatalError(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanStartElement(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.impl.XMLNSDocumentScannerImpl$NSContentDispatcher.scanRootElementHook(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown Source)
2020/12/22 10:13:08 - GUI - at org.apache.batik.dom.util.SAXDocumentFactory.createDocument(SAXDocumentFactory.java:453)
2020/12/22 10:13:08 - GUI - ... 13 more
2020/12/22 10:13:08 - GUI - ERROR: Unable to load image [repeat.svg] for plugin Repeat
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva commented on a change in pull request #483: HOP-2281 Cleaning images
Posted by GitBox <gi...@apache.org>.
hansva commented on a change in pull request #483:
URL: https://github.com/apache/incubator-hop/pull/483#discussion_r547159520
##########
File path: plugins/actions/repeat/src/main/resources/repeat.svg
##########
@@ -1,5 +1,105 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
Review comment:
merge conflict snuck into this file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org