You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/07/29 17:38:19 UTC
[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #4209: Analyze define expr after replay Rollup job
EmmyMiao87 opened a new pull request #4209:
URL: https://github.com/apache/incubator-doris/pull/4209
## Proposed changes
Fixed.#4208
The define expr should be analyzed after replay RollupJob.
The slot desc of define expr is used to transform to thrift and send to backend.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [] New feature (non-breaking change which adds functionality)
- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [] Documentation Update (if none of the other choices apply)
- [] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on #ISSUE, and have described the bug/feature there in detail
- [] Compiling and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
- [] If this change need a document change, I have updated the document
- [] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 closed pull request #4209: Analyze define expr after replay Rollup job
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 closed pull request #4209:
URL: https://github.com/apache/incubator-doris/pull/4209
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wutiangan commented on a change in pull request #4209: Analyze define expr after replay Rollup job
Posted by GitBox <gi...@apache.org>.
wutiangan commented on a change in pull request #4209:
URL: https://github.com/apache/incubator-doris/pull/4209#discussion_r462365309
##########
File path: fe/fe-core/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
##########
@@ -102,6 +102,20 @@ public MaterializedViewHandler() {
// table id -> set of running job ids
private Map<Long, Set<Long>> tableRunningJobMap = new ConcurrentHashMap<>();
+ @Override
+ public void prepare() {
+ for (AlterJobV2 alterJobV2 : alterJobsV2.values()) {
+ if (alterJobV2.getJobState() == AlterJobV2.JobState.PENDING) {
+ try {
+ alterJobV2.analyze();
+ } catch (Exception e) {
+ alterJobV2.cancel("Analyze failed:" + e.getMessage());
+ LOG.warn("Failed to analyze rollup job []", alterJobV2.getJobId(), e);
Review comment:
```suggestion
LOG.warn("Failed to analyze rollup job [{}]", alterJobV2.getJobId(), e);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #4209: Analyze define expr after replay Rollup job
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on pull request #4209:
URL: https://github.com/apache/incubator-doris/pull/4209#issuecomment-667862626
This pr has been abandoned. The new pr is #4236
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org