You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2006/01/15 23:08:02 UTC
DO NOT REPLY [Bug 38282] New: - [patch] from-table-column implementation
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38282>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38282
Summary: [patch] from-table-column implementation
Product: Fop
Version: 1.0dev
Platform: Other
OS/Version: other
Status: NEW
Severity: enhancement
Priority: P2
Component: fo tree
AssignedTo: fop-dev@xmlgraphics.apache.org
ReportedBy: gerhard.oettl@oesoft.at
This patch should implement the from-table-function.
Changes to TableFObj.java:
1) Make the getTable method public to have a quick access.
Alternatives:
1a) Only make public in TableCell (and call there super.getTable)
1b) Explicitly traverse back in the FromTableColumnFunction
with getParent until we reach the Table object.
Changes to TableColumn:
2) Preserve PropertyList and add an accessor for this list
Note:
Preserved PropertyList could be cleared at the end of the table
at fo tree parsing (for memory freeing) because it is not needed
for the layout-managers.
Should I do this in Table.endOfNode?
Changes to FromTableColumnFunction.java:
Details of implementation under discussion at fop-dev.
Thread: "table-columns and number-columns-spanned"
"last fallback" and eventually "second fallback" may be
obsoleted by this discussion.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 38282] - [patch] from-table-column implementation
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38282>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38282
a_l.delmelle@pandora.be changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
DO NOT REPLY [Bug 38282] - [patch] from-table-column implementation
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38282>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38282
manuel@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fop-
| |dev@xmlgraphics.apache.org
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
DO NOT REPLY [Bug 38282] - [patch] from-table-column implementation
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38282>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38282
------- Additional Comments From gerhard.oettl@oesoft.at 2006-01-15 23:09 -------
Created an attachment (id=17426)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=17426&action=view)
initial patch
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 38282] - [patch] from-table-column implementation
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38282>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38282
a_l.delmelle@pandora.be changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #17530|0 |1
is obsolete| |
AssignedTo|fop- |a_l.delmelle@pandora.be
|dev@xmlgraphics.apache.org |
Status|NEW |ASSIGNED
------- Additional Comments From a_l.delmelle@pandora.be 2006-01-30 19:38 -------
Created an attachment (id=17539)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=17539&action=view)
correction...
Slightly corrected and updated version of the proposed patch.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 38282] - [patch] from-table-column implementation
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38282>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38282
a_l.delmelle@pandora.be changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #17426|0 |1
is obsolete| |
------- Additional Comments From a_l.delmelle@pandora.be 2006-01-29 21:49 -------
Created an attachment (id=17530)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=17530&action=view)
alternative patch
Gerhard,
I finally got around to taking a look at the column-numbers again. In the end,
I think the solution was
pretty straightforward (see attached patch).
I managed to make the function applicable to table-cells as well... I only
needed to make sure column-number and number-columns-spanned were treated the
same way as font-size (see alterations to PropertyList). Maybe in the longer
term, some rational ordering of the possibly specified properties needs to be
looked at in a more global sense. (Apart from the above three, are there any
other cases where the property parsing implies knowing the explicit values for
other properties, so we need to make sure they are available first?)
Roughly, I think my patch does more or less the same as yours. Differences are:
* that I preferred to expose the isColumnNumberUsed() method, instead of using
iterators over the columns List (a matter of taste? seemed to result in less
objects being created...)
* replaced the PropertyList reference in TableColumn with a StaticPropertyList
(efficiency+)
* did some cleanup: moved validation/overlapping colnrs to the PropertyMaker
Let me know if this agrees with you...
Cheers,
Andreas
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 38282] - [patch] from-table-column implementation
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38282>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38282
------- Additional Comments From gerhard.oettl@oesoft.at 2006-01-15 23:09 -------
Created an attachment (id=17427)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=17427&action=view)
an example fo-file
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 38282] - [patch] from-table-column implementation
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38282>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38282
------- Additional Comments From a_l.delmelle@pandora.be 2006-01-31 22:37 -------
OK, just looked it up, and it seems like it *is* possible --although I wouldn't dream of it myself to do
so, that's another issue.
Then again: this problem will always pose itself, and it is not so much a matter of 'early property
evaluation'. All properties are evaluated early, and some need to come first because of possible
dependencies of other specified properties (i.e. relative font-sizes or core function calls). In itself, this
isn't wrong, but the solution may be to postpone the whole property evaluation cycle for a marker and
*all* of its descendants until the marker is retrieved (since we cannot possibly know how inherited
properties specified on the retrieve-marker or its containing block will affect the properties of the
markers and its descendants... Maybe this is another case where we absolutely need to keep a reference
to the original PropertyLists instead of binding the individual properties to instance variables (?)
I'll apply the patch as is, with a few added comments indicating that markers still need to be treated
with caution.
Cheers,
Andreas
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
DO NOT REPLY [Bug 38282] - [patch] from-table-column implementation
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38282>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38282
------- Additional Comments From a_l.delmelle@pandora.be 2006-01-31 22:18 -------
Hi Manuel,
I think it doesn't apply in this particular case... The problem with font-size, IIRC, concerns retrieved
markers (?) Should be no problem here. Column-number 3 will always remain column-number 3,
regardless of whether the table is contained in a marker or not.
I don't know precisely --will have to look it up-- whether a marker that is in column-number 3 in a
table descending from the flow, can be retrieved into a table in the static-content and thus end up in a
different column...
Cheers,
Andreas
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.