Re: [PR] fix(view metadata): define `schemas` and `versions` as slices [iceberg-go]

["zeroshade (via GitHub)" <gi...@apache.org>]

zeroshade commented on code in PR #600:
URL: https://github.com/apache/iceberg-go/pull/600#discussion_r2445776063


##########
catalog/internal/utils.go:
##########
@@ -284,12 +284,10 @@ func CreateViewMetadata(
 		"view-uuid":          viewUUID,
 		"format-version":     1,
 		"location":           loc,
-		"schema":             schema,
+		"schemas":            []*iceberg.Schema{schema},
 		"current-version-id": versionId,
-		"versions": map[string]interface{}{
-			"1": viewVersion,
-		},
-		"properties": props,
+		"versions":           []interface{}{viewVersion},

Review Comment:
   at this rate we might as well properly create the version type with the appropriate required/optional values etc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org