You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by martincgg <gi...@git.apache.org> on 2014/06/24 12:23:54 UTC
[GitHub] cordova-mobile-spec pull request: CB-7013 (WP8) use proper string ...
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/79
CB-7013 (WP8) use proper string to compare
if the platform is windows phone, it will use a proper string to compare (//nativ) instead of the default 'file://' that it won't match with the platform.
This solves the problem for file.spec.114 and file.spec.115.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/martincgg/cordova-mobile-spec CB-7013
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-mobile-spec/pull/79.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #79
----
commit 34072f2d2f4b98f1e84973dbe387d0788d524ae9
Author: Martin Gonzalez <ma...@gmail.com>
Date: 2014-06-24T10:17:33Z
CB-7013 (WP8) use proper string to compare
if the platform is windows phone, it will use a proper string to compare
(//nativ) instead of the default 'file://' that it won't match with the
platform.
This solves the problem for file.spec.114 and file.spec.115.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-mobile-spec pull request: CB-7013 (WP8) use proper string ...
Posted by martincgg <gi...@git.apache.org>.
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/79#issuecomment-51419364
Yeah, this was for the mobile spec tests, is not longer valid
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-mobile-spec pull request: CB-7013 (WP8) use proper string ...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/79#issuecomment-51417924
merge conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-mobile-spec pull request: CB-7013 (WP8) use proper string ...
Posted by martincgg <gi...@git.apache.org>.
Github user martincgg closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/79
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---