You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Mete Atamel (Created) (JIRA)" <ji...@apache.org> on 2012/02/07 12:44:59 UTC
[jira] [Created] (JCR-3229) FileRevision should have a flag to
control whether to sync the file on every write.
FileRevision should have a flag to control whether to sync the file on every write.
-----------------------------------------------------------------------------------
Key: JCR-3229
URL: https://issues.apache.org/jira/browse/JCR-3229
Project: Jackrabbit Content Repository
Issue Type: Improvement
Components: jackrabbit-core
Reporter: Mete Atamel
Priority: Minor
Fix For: 2.5
FileRevision class syncs the underlying revision.log file it uses on every write which could be a performance problem. Add a boolean flag to control whether to sync the file on every write.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3229) FileRevision should have a flag to
control whether to sync the file on every write.
Posted by "Dominique Pfister (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dominique Pfister updated JCR-3229:
-----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Good, I applied your patch (with sync set to true for these journals) in revision 1241481.
> FileRevision should have a flag to control whether to sync the file on every write.
> -----------------------------------------------------------------------------------
>
> Key: JCR-3229
> URL: https://issues.apache.org/jira/browse/JCR-3229
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Mete Atamel
> Priority: Minor
> Labels: performance
> Fix For: 2.5
>
> Attachments: 3229.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> FileRevision class syncs the underlying revision.log file it uses on every write which could be a performance problem. Add a boolean flag to control whether to sync the file on every write.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3229) FileRevision should have a flag to
control whether to sync the file on every write.
Posted by "Mete Atamel (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mete Atamel updated JCR-3229:
-----------------------------
Status: Patch Available (was: Open)
`
> FileRevision should have a flag to control whether to sync the file on every write.
> -----------------------------------------------------------------------------------
>
> Key: JCR-3229
> URL: https://issues.apache.org/jira/browse/JCR-3229
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Mete Atamel
> Priority: Minor
> Labels: performance
> Fix For: 2.5
>
> Attachments: 3229.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> FileRevision class syncs the underlying revision.log file it uses on every write which could be a performance problem. Add a boolean flag to control whether to sync the file on every write.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3229) FileRevision should have a flag to
control whether to sync the file on every write.
Posted by "Mete Atamel (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202424#comment-13202424 ]
Mete Atamel commented on JCR-3229:
----------------------------------
Ah yes. I meant to keep the default sync on but only provide a way to turn it off if someone wanted it. So, you're right, my mistake, both journal should sync by default as before.
> FileRevision should have a flag to control whether to sync the file on every write.
> -----------------------------------------------------------------------------------
>
> Key: JCR-3229
> URL: https://issues.apache.org/jira/browse/JCR-3229
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Mete Atamel
> Priority: Minor
> Labels: performance
> Fix For: 2.5
>
> Attachments: 3229.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> FileRevision class syncs the underlying revision.log file it uses on every write which could be a performance problem. Add a boolean flag to control whether to sync the file on every write.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3229) FileRevision should have a flag to
control whether to sync the file on every write.
Posted by "Mete Atamel (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mete Atamel updated JCR-3229:
-----------------------------
Attachment: 3229.patch
Proposed fix.
> FileRevision should have a flag to control whether to sync the file on every write.
> -----------------------------------------------------------------------------------
>
> Key: JCR-3229
> URL: https://issues.apache.org/jira/browse/JCR-3229
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Mete Atamel
> Priority: Minor
> Labels: performance
> Fix For: 2.5
>
> Attachments: 3229.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> FileRevision class syncs the underlying revision.log file it uses on every write which could be a performance problem. Add a boolean flag to control whether to sync the file on every write.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3229) FileRevision should have a flag to
control whether to sync the file on every write.
Posted by "Dominique Pfister (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202417#comment-13202417 ]
Dominique Pfister commented on JCR-3229:
----------------------------------------
Hi Mete,
Thanks for providing a patch. I noticed that you changed both FileJournal's and DatabaseJournal's revision.log to not sync after writing (opposed to the current state where they sync after every write), which might result in information loss if that cluster node crashes before the file system will eventually write changes back to disk. Don't you think this might be problematic?
Kind regards
Dominique
> FileRevision should have a flag to control whether to sync the file on every write.
> -----------------------------------------------------------------------------------
>
> Key: JCR-3229
> URL: https://issues.apache.org/jira/browse/JCR-3229
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Mete Atamel
> Priority: Minor
> Labels: performance
> Fix For: 2.5
>
> Attachments: 3229.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> FileRevision class syncs the underlying revision.log file it uses on every write which could be a performance problem. Add a boolean flag to control whether to sync the file on every write.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira