You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/03/02 12:35:23 UTC

[GitHub] [netbeans] neilcsmith-net commented on pull request #3683: VersionVault integration with Netbeans

neilcsmith-net commented on pull request #3683:
URL: https://github.com/apache/netbeans/pull/3683#issuecomment-1056881020


   Thanks for your PR, but why not deliver this as a plugin?
   
   The code has multiple license headers, and it is unclear what the provenance of that code is.  It has both (c) Oracle (GPL/CDDL) and (c) HCL (Apache) headers!
   
   If the reason for not making this a plugin aligns with the addition of the friend dependency, then we probably need to discuss opening up the relevant API.
   
   In current state, sorry -1 from me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists