[GitHub] [pulsar] murong00 commented on a change in pull request #5985: [Issue 5935] Support multi pulsar clusters to use the same bk cluster

[GitBox <gi...@apache.org>]

murong00 commented on a change in pull request #5985: [Issue 5935] Support multi pulsar clusters to use the same bk cluster
URL: https://github.com/apache/pulsar/pull/5985#discussion_r383649876
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/BookKeeperClientFactoryImpl.java
 ##########
 @@ -106,6 +106,14 @@ ClientConfiguration createBkClientConfiguration(ServiceConfiguration conf) {
         bkConf.setNettyMaxFrameSizeBytes(conf.getMaxMessageSize() + Commands.MESSAGE_SIZE_FRAME_PADDING);
         bkConf.setDiskWeightBasedPlacementEnabled(conf.isBookkeeperDiskWeightBasedPlacementEnabled());
 
+        if (StringUtils.isNotBlank(conf.getBookkeeperServiceUri())) {
+            bkConf.setMetadataServiceUri(conf.getBookkeeperServiceUri());
+        } else {
+            PulsarService pulsar = new PulsarService(conf);
 
 Review comment:
   done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services