You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/03/06 22:32:17 UTC
[GitHub] [netbeans] matthiasblaesing opened a new pull request #2006:
[NETBEANS-445] Update CSS display property to CSS display module level 3
matthiasblaesing opened a new pull request #2006: [NETBEANS-445] Update CSS display property to CSS display module level 3
URL: https://github.com/apache/netbeans/pull/2006
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #2006:
[NETBEANS-445] Update CSS display property to CSS display module level 3
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #2006: [NETBEANS-445] Update CSS display property to CSS display module level 3
URL: https://github.com/apache/netbeans/pull/2006#issuecomment-596251182
Work in progress as @junichi11 noticed, that there is another problem lurking in the CSS parser. The `org.netbeans.modules.css.lib.api.properties.GrammarResolver` should be able resolve "b c" against a grammar "a? && b && c" (the a value is optional), yet it is rejected. The handling of multiplicities in the resolver does not seem to be correct and if I'm not mistaken, there are more problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #2006:
[NETBEANS-445][NETBEANS-2634] Update CSS display property to CSS display
module level 3 + add unicode-range
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #2006: [NETBEANS-445][NETBEANS-2634] Update CSS display property to CSS display module level 3 + add unicode-range
URL: https://github.com/apache/netbeans/pull/2006#issuecomment-598366211
@junichi11 thank you for the patch - looks sane to me and is a valued addition. I added the patch as a further commit. As unittests come back cleanly, I'll merge it now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #2006:
[NETBEANS-445][NETBEANS-2634] Update CSS display property to CSS display
module level 3 + add unicode-range
Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged pull request #2006: [NETBEANS-445][NETBEANS-2634] Update CSS display property to CSS display module level 3 + add unicode-range
URL: https://github.com/apache/netbeans/pull/2006
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #2006:
[NETBEANS-445][NETBEANS-2634] Update CSS display property to CSS display
module level 3 + add unicode-range
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #2006: [NETBEANS-445][NETBEANS-2634] Update CSS display property to CSS display module level 3 + add unicode-range
URL: https://github.com/apache/netbeans/pull/2006#issuecomment-597830277
Ok - I think I managed to fix the issue of the optional parts in the grammar. I did multiple iterations with varying degree of changes. It turns out, that this fix is not perfect, but should work for the current grammars. A general fix turned out to be much harder and I stepped back from trying to this.
I added unittests to verify the current behavior and ensured that all existing unittests still work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists