You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2021/03/17 16:54:02 UTC

[GitHub] [buildstream] juergbi opened a new pull request #1457: element.py: Compute cache key also for rdep without buildable callback

juergbi opened a new pull request #1457:
URL: https://github.com/apache/buildstream/pull/1457


   The reverse dependency may not be in the build queue yet and thus, the buildable callback may be `None`. However, it's still necessary to update the cache key in non-strict mode.
   
   Fixes #1452.
   
   Fixes: 8d9bf024 ("element.py: Stop computing cache keys when...")


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [buildstream] juergbi commented on pull request #1457: element.py: Compute cache key also for rdep without buildable callback

Posted by GitBox <gi...@apache.org>.
juergbi commented on pull request #1457:
URL: https://github.com/apache/buildstream/pull/1457#issuecomment-801249569


   As the issue is essentially a race condition, writing a reliable regression test for the test suite may no be straight forward, unfortunately. I was able to reproduce the issue manually with a clean freedesktop-sdk build, though, and I've verified the fix manually the same way.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [buildstream] juergbi merged pull request #1457: element.py: Compute cache key also for rdep without buildable callback

Posted by GitBox <gi...@apache.org>.
juergbi merged pull request #1457:
URL: https://github.com/apache/buildstream/pull/1457


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org