You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/12/23 16:22:21 UTC

[GitHub] [logging-log4j2] vorburger opened a new pull request #651: Fix obvious bug in SLF4JLoggerContext (and related typo in LoggerTest)

vorburger opened a new pull request #651:
URL: https://github.com/apache/logging-log4j2/pull/651


   Yo Log4j maintainers - hope this helps?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] vorburger commented on pull request #651: Fix obvious bug in SLF4JLoggerContext (and related typo in LoggerTest)

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #651:
URL: https://github.com/apache/logging-log4j2/pull/651#issuecomment-1000414777


   Builds failing? I've opened https://issues.apache.org/jira/browse/LOG4J2-3229.
   
   BTW should I be raising a 2nd PR to cherry-pick this to `release-2.x` from `master` where I'm submitting this one to, after it's LGTM & merge? Or does that happen automatically? Or do committers do this for PRs from contributors? Just asking to learn how you work in this community. (I'm an Apache committer on other projects.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] carterkozak commented on pull request #651: Fix MessageFactory support bug in SLF4JLoggerContext

Posted by GitBox <gi...@apache.org>.
carterkozak commented on pull request #651:
URL: https://github.com/apache/logging-log4j2/pull/651#issuecomment-1000429985


   lgtm, thanks for the contribution! I'll get this merged once tests complete.
   
   I've filed https://issues.apache.org/jira/browse/LOG4J2-3284 for tracking.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] garydgregory commented on pull request #651: Fix obvious bug in SLF4JLoggerContext (and related typo in LoggerTest)

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #651:
URL: https://github.com/apache/logging-log4j2/pull/651#issuecomment-1000416627


   Hello @vorburger,
   
   Please base your PR on the branch release-2.x.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] carterkozak merged pull request #651: Fix MessageFactory support bug in SLF4JLoggerContext

Posted by GitBox <gi...@apache.org>.
carterkozak merged pull request #651:
URL: https://github.com/apache/logging-log4j2/pull/651


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] carterkozak commented on pull request #651: Fix obvious bug in SLF4JLoggerContext (and related typo in LoggerTest)

Posted by GitBox <gi...@apache.org>.
carterkozak commented on pull request #651:
URL: https://github.com/apache/logging-log4j2/pull/651#issuecomment-1000417982


   It would be helpful to describe what has been resolved rather than using the description `fixed bug in ClassName` ;-)
   
   I'd appreciate it if you could PR into `release-2.x` instead of `master`. The CI system works better on that branch, and it's what we release. I have an issue open with infra to change the default branch on this repo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] vorburger commented on pull request #651: Fix MessageFactory support bug in SLF4JLoggerContext

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #651:
URL: https://github.com/apache/logging-log4j2/pull/651#issuecomment-1000424173


   > Please base your PR on the branch release-2.x.
   
   done
   
   > It would be helpful to describe what has been resolved rather than using the description `fixed bug in ClassName` ;-)
   
   done
   
   > I'd appreciate it if you could PR into `release-2.x` instead of `master`. The CI system works better on that branch, and it's what we release. I have an issue open with infra to change the default branch on this repo.
   
   Good to know. Perhaps you would like to leave a related comment in https://issues.apache.org/jira/browse/LOG4J2-3229.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] vorburger commented on pull request #651: Fix MessageFactory support bug in SLF4JLoggerContext

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #651:
URL: https://github.com/apache/logging-log4j2/pull/651#issuecomment-1000425549


   BTW just FYI this PR is a result of my staring at this code in the context of [LOG4J2-3282](https://issues.apache.org/jira/browse/LOG4J2-3282) - it seemed like a Good Idea to fix this before copy/pasting this code into a new place... 😄 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org