[jira] [Commented] (GEODE-6908) Some retry operation from client did not set setPossibleDuplicate in event

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16874730#comment-16874730 ] 

ASF subversion and git services commented on GEODE-6908:
--------------------------------------------------------

Commit c57d15803dd9c9146af92a027724eaf777aa22d4 in geode's branch refs/heads/feature/GEODE-6908 from zhouxh
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=c57d158 ]

GEODE-6908: retried REMOVE should not create new version tag.
            added retry dunit tests for all the c/s operations.


> Some retry operation from client did not set setPossibleDuplicate in event
> --------------------------------------------------------------------------
>
>                 Key: GEODE-6908
>                 URL: https://issues.apache.org/jira/browse/GEODE-6908
>             Project: Geode
>          Issue Type: Bug
>            Reporter: xiaojian zhou
>            Assignee: xiaojian zhou
>            Priority: Major
>              Labels: GeodeCommons
>
> I fixed a bug GEODE-6899, where the retried UPDATE did not set event the version tag found from previous try. 
> I searched other code and found there's one more place:
> basicBridgeRemove() should also add following lines like in basicBridgeDestroy:
>       // if this is a replayed operation we may already have a version tag
>       event.setVersionTag(clientEvent.getVersionTag());
>       event.setPossibleDuplicate(clientEvent.isPossibleDuplicate());
> BTW, basicBridgeDestroy(), basicBridgeUpdateVersionStamp(), basicBridgeInvalidate() called 
> event.setVersionTag(clientEvent.getVersionTag()); but they did not call "event.setPossibleDuplicate(clientEvent.isPossibleDuplicate());"
> I think it's better to keep all the code the same. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)