You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by khalidhuseynov <gi...@git.apache.org> on 2016/07/04 11:24:12 UTC
[GitHub] zeppelin pull request #1123: [Zeppelin - 1104] ZeppelinHub storage max note ...
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/1123
[Zeppelin - 1104] ZeppelinHub storage max note size to 64Mb
### What is this PR for?
This is to increase default note (text message) size used in ZeppelinHub storage layer from 64Kb to 64Mb.
### What type of PR is it?
Improvement
### Todos
* [x] - change ws client configuration
### What is the Jira issue?
[ZEPPELIN-1104](https://issues.apache.org/jira/browse/ZEPPELIN-1104)
### How should this be tested?
1. configure to use ZeppelinHub storage
2. create any note larger than 64Kb
3. edit note
4. shouldn't receive the exception traceback reported in the issue
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin fix/zeppelinhub-ws-max-size
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1123.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1123
----
commit 3c594451ed94e9f998c0bbafab9d9b416f2f7a8c
Author: Khalid Huseynov <kh...@nflabs.com>
Date: 2016-07-04T11:17:40Z
change max text message size to 64Mb
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1123: [Zeppelin - 1104] ZeppelinHub storage max note ...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/1123
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1123: [Zeppelin - 1104] ZeppelinHub storage max note size to...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1123
Looks good to me,
as for CI failure - did you check JIRA issues, esp with flack-test label?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1123: [Zeppelin - 1104] ZeppelinHub storage max note ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1123
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1123: [Zeppelin - 1104] ZeppelinHub storage max note size to...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1123
@bzz done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1123: [Zeppelin - 1104] ZeppelinHub storage max note size to...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1123
This looks very similar to [ZEPPELIN-1063](https://issues.apache.org/jira/browse/ZEPPELIN-1063) with title "Flaky Test - PythonInterpreterTest.testClose" wich I can not reproduce locally.
Will re-open it and link this PR.
As CI failure is un-related, will merge if there is no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1123: [Zeppelin - 1104] ZeppelinHub storage max note ...
Posted by khalidhuseynov <gi...@git.apache.org>.
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/1123
[Zeppelin - 1104] ZeppelinHub storage max note size to 64Mb
### What is this PR for?
This is to increase default note (text message) size used in ZeppelinHub storage layer from 64Kb to 64Mb.
### What type of PR is it?
Improvement
### Todos
* [x] - change ws client configuration
### What is the Jira issue?
[ZEPPELIN-1104](https://issues.apache.org/jira/browse/ZEPPELIN-1104)
### How should this be tested?
1. configure to use ZeppelinHub storage
2. create any note larger than 64Kb
3. edit note
4. shouldn't receive the exception traceback reported in the issue
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin fix/zeppelinhub-ws-max-size
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1123.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1123
----
commit 3c594451ed94e9f998c0bbafab9d9b416f2f7a8c
Author: Khalid Huseynov <kh...@nflabs.com>
Date: 2016-07-04T11:17:40Z
change max text message size to 64Mb
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1123: [Zeppelin - 1104] ZeppelinHub storage max note size to...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1123
@khalidhuseynov what about latest CI failure on this PR? Licence check is failing the build
```
[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check (verify.rat) on project zeppelin: Too many files with unapproved license: 1 See RAT report in: /home/travis/build/apache/zeppelin/target/rat.txt -> [Help 1]
[ERROR]
[0K$ cat target/rat.txt
*****************************************************
Summary
-------
Generated at: 2016-07-05T00:01:36+00:00
Notes: 2
Binaries: 148
Archives: 0
Standards: 91
Apache Licensed: 90
Generated Documents: 0
JavaDocs are generated and so license header is optional
Generated files do not required license headers
1 Unknown Licenses
*******************************
Unapproved licenses:
zeppelin-examples/zeppelin-example-horizontalbar/src/main/resources/example/app/horizontalbar/horizontalbar_mockdata.txt
*******************************
Archives:
```
?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1123: [Zeppelin - 1104] ZeppelinHub storage max note size to...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1123
@bzz actually i checked, but couldn't find anything with similar content (stacktrace, or tag?). please let me know if it's existing, otherwise i could create one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1123: [Zeppelin - 1104] ZeppelinHub storage max note size to...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1123
Looks good to me, merging to **master** and **branch-0.6** if there is no more discussion
@khalidhuseynov could you please make sure JIRA issue has correct "fix for" version? 0.7.0 and 0.6.1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1123: [Zeppelin - 1104] ZeppelinHub storage max note size to...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1123
@bzz you're right, the latest build was failing because of no header in `zeppelin-examples/zeppelin-example-horizontalbar/src/main/resources/example/app/horizontalbar/horizontalbar_mockdata.txt` that comes from https://github.com/apache/zeppelin/commit/9463fb854764a99a5161226cb95c439bafff5f54. However my branch wasn't even based on it. I rebased from master and pushed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1123: [Zeppelin - 1104] ZeppelinHub storage max note size to...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1123
CI is green, and i think it's better to be included in 0.6 branch as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1123: [Zeppelin - 1104] ZeppelinHub storage max note size to...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1123
I get the following failure which is unrelated
```
Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.486 sec <<< FAILURE! - in org.apache.zeppelin.python.PythonInterpreterTest
testClose(org.apache.zeppelin.python.PythonInterpreterTest) Time elapsed: 0.377 sec <<< FAILURE!
java.lang.AssertionError: null
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertFalse(Assert.java:64)
at org.junit.Assert.assertFalse(Assert.java:74)
at org.apache.zeppelin.python.PythonInterpreterTest.testClose(PythonInterpreterTest.java:141)
```
retriggering
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---