You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Amar Kamat (Created) (JIRA)" <ji...@apache.org> on 2011/11/22 12:08:40 UTC
[jira] [Created] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Configuration.getClasses() never returns the default value.
-----------------------------------------------------------
Key: HADOOP-7851
URL: https://issues.apache.org/jira/browse/HADOOP-7851
Project: Hadoop Common
Issue Type: Bug
Components: conf
Affects Versions: 0.23.0
Reporter: Amar Kamat
Fix For: 0.24.0
Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203074#comment-13203074 ]
Hudson commented on HADOOP-7851:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #1762 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1762/])
HADOOP-7851. Moving to 0.23.1 section in CHANGES.txt
acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241722
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166276#comment-13166276 ]
Hudson commented on HADOOP-7851:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #889 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/889/])
Added Uma's name to the CHANGES.txt file for HADOOP-7851.
HADOOP-7851. Configuration.getClasses() never returns the default value. (amarrk)
amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212288
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212282
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203076#comment-13203076 ]
Hudson commented on HADOOP-7851:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #1688 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1688/])
HADOOP-7851. Moving to 0.23.1 section in CHANGES.txt
acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241722
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203130#comment-13203130 ]
Hudson commented on HADOOP-7851:
--------------------------------
Integrated in Hadoop-Mapreduce-0.23-Commit #520 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/520/])
HADOOP-7851. Moving to 0.23.1 section in CHANGES.txt
acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241724
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Harsh J (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156814#comment-13156814 ]
Harsh J commented on HADOOP-7851:
---------------------------------
Can we not test instead for an empty array and return the default value? This way we properly reuse the getTrimmedStrings function thats already present, instead of directly calling out the StringUtils one.
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Amar Kamat (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155026#comment-13155026 ]
Amar Kamat commented on HADOOP-7851:
------------------------------------
I think, the fix should be something like
{noformat}
diff --git hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java hadoop-common-project/hadoop-common/src
index a3d4de0..2c90493 100644
--- hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
+++ hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
@@ -1145,6 +1145,10 @@ public class Configuration implements Iterable<Map.Entry<String,String>>,
* or <code>defaultValue</code>.
*/
public Class<?>[] getClasses(String name, Class<?> ... defaultValue) {
+ // return the default value if the parameter is missing
+ if (get(name) == null) {
+ return defaultValue;
+ }
String[] classnames = getTrimmedStrings(name);
if (classnames == null)
return defaultValue;
{noformat}
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Labels: configuration
> Fix For: 0.24.0
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Amar Kamat (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165856#comment-13165856 ]
Amar Kamat commented on HADOOP-7851:
------------------------------------
+1. I will commit this.
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156851#comment-13156851 ]
Uma Maheswara Rao G commented on HADOOP-7851:
---------------------------------------------
{quote}
Can we not test instead for an empty array and return the default value? This way we properly reuse the getTrimmedStrings function thats already present, instead of directly calling out the StringUtils one.
{quote}
This also should work.
{quote}
This problem exists in 0.20-security as well. Would love it if you can post a patch for that as well?
{quote}
In 20Security205, getStrings itself will return null if collection is empty.
Collection<String> values = getStringCollection(str);
if(values.size() == 0) {
return null;
}
I dont see problem here. Am i missing some thing here?
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165955#comment-13165955 ]
Hudson commented on HADOOP-7851:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #1461 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1461/])
HADOOP-7851. Configuration.getClasses() never returns the default value. (amarrk)
amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212282
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156867#comment-13156867 ]
Uma Maheswara Rao G commented on HADOOP-7851:
---------------------------------------------
Javadoc comments are not from this patch! let me check.
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203581#comment-13203581 ]
Hudson commented on HADOOP-7851:
--------------------------------
Integrated in Hadoop-Mapreduce-0.23-Build #185 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/185/])
HADOOP-7851. Moving to 0.23.1 section in CHANGES.txt
acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241724
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7851:
----------------------------------------
Attachment: HADOOP-7851.patch
Updated the patch for trunk!
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7851:
----------------------------------------
Attachment: HADOOP-7851.patch
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165982#comment-13165982 ]
Hudson commented on HADOOP-7851:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #1462 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1462/])
Added Uma's name to the CHANGES.txt file for HADOOP-7851.
amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212288
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203607#comment-13203607 ]
Hudson commented on HADOOP-7851:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #983 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/983/])
HADOOP-7851. Moving to 0.23.1 section in CHANGES.txt
acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241722
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156853#comment-13156853 ]
Uma Maheswara Rao G commented on HADOOP-7851:
---------------------------------------------
For 23 branch, we can directly merge the trunk patch because there is no code mismatches.
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203086#comment-13203086 ]
Hudson commented on HADOOP-7851:
--------------------------------
Integrated in Hadoop-Common-0.23-Commit #516 (See [https://builds.apache.org/job/Hadoop-Common-0.23-Commit/516/])
HADOOP-7851. Moving to 0.23.1 section in CHANGES.txt
acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241724
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7851:
----------------------------------------
Attachment: HADOOP-7851.patch
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203097#comment-13203097 ]
Hudson commented on HADOOP-7851:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #1699 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1699/])
HADOOP-7851. Moving to 0.23.1 section in CHANGES.txt
acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241722
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7851:
----------------------------------------
Target Version/s: 0.24.0, 0.23.1 (was: 0.23.1, 0.24.0)
Status: Open (was: Patch Available)
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Amar Kamat (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amar Kamat updated HADOOP-7851:
-------------------------------
Resolution: Fixed
Target Version/s: 0.24.0, 0.23.1 (was: 0.23.1, 0.24.0)
Release Note: Fixed Configuration.getClasses() API to return the default value if the key is not set.
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
I just committed this to trunk. Thanks Uma!
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166037#comment-13166037 ]
Uma Maheswara Rao G commented on HADOOP-7851:
---------------------------------------------
Thanks Amar for the reviews.
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166238#comment-13166238 ]
Hudson commented on HADOOP-7851:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #922 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/922/])
Added Uma's name to the CHANGES.txt file for HADOOP-7851.
HADOOP-7851. Configuration.getClasses() never returns the default value. (amarrk)
amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212288
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212282
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165378#comment-13165378 ]
Uma Maheswara Rao G commented on HADOOP-7851:
---------------------------------------------
Thanks Amar for taking a look again.
Ok, it is better than get. its little lighter :-)
Updated the patch by addressing the comments.
{quote}
kindly use
Class<?>[] classes =
config.getClasses("testClassName", Configuration.class);
{quote}
This is due to formatter. I am usiing hadoop formatter only. Manually i changed it.
3. Instead of assertTrue, you can use assertEquals()
Yes, assertEquals will give the values in trace when it is failing. But i included the value in error message.Since they are premitives i used assertTrue.
Now i changed it to assertEquals.
4. Kindly add a testcase for a value of "". The output should be an empty array.
Added test for "".
Amar, can you please take a look?
Thanks
Uma
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203557#comment-13203557 ]
Hudson commented on HADOOP-7851:
--------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #163 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/163/])
HADOOP-7851. Moving to 0.23.1 section in CHANGES.txt
acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241724
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165301#comment-13165301 ]
Uma Maheswara Rao G commented on HADOOP-7851:
---------------------------------------------
Hi Amar, Thanks for the review.
{quote}
1. Instead of
String[] classnames = StringUtils.getTrimmedStrings(valueString);
use
String[] classnames = getTrimmedStrings(name);
{quote}
get call will be executed multiple times if i use getTrimmedStrings(name).
Because we should call get once for validating null and then call getTrimmedStrings. This api again will call get and passed to StringUtils.getTrimmedStrings. That is the reason i used directly StringUtils.getTrimmedStrings. do you agree with this?
i will update the patch with other comments. Can you please confirm above one.
Regards,
Uma
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165770#comment-13165770 ]
Hadoop QA commented on HADOOP-7851:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12506694/HADOOP-7851.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 5 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/455//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/455//console
This message is automatically generated.
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Harsh J (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HADOOP-7851:
----------------------------
Target Version/s: 0.24.0, 0.23.1 (was: 0.24.0)
Fix Version/s: 0.23.1
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7851:
----------------------------------------
Attachment: HADOOP-7851.patch
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Amar Kamat (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165338#comment-13165338 ]
Amar Kamat commented on HADOOP-7851:
------------------------------------
Uma, does it makes sense to use {{getRaw()}} instead. Something like
{code}
if (null == getRaw(name)) {
return defaultValue;
}
String[] classnames = getTrimmedStrings(name);
{code}
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7851:
----------------------------------------
Target Version/s: 0.24.0, 0.23.1 (was: 0.23.1, 0.24.0)
Status: Patch Available (was: Open)
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156856#comment-13156856 ]
Hadoop QA commented on HADOOP-7851:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12505028/HADOOP-7851.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 15 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/406//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/406//console
This message is automatically generated.
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166031#comment-13166031 ]
Hudson commented on HADOOP-7851:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #1412 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1412/])
Added Uma's name to the CHANGES.txt file for HADOOP-7851.
amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212288
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Amar Kamat (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165259#comment-13165259 ]
Amar Kamat commented on HADOOP-7851:
------------------------------------
Some comments on the first patch.
1. Instead of
{code}
String[] classnames = StringUtils.getTrimmedStrings(valueString);
{code}
use
{code}
String[] classnames = getTrimmedStrings(name);
{code}
2. In the testcase,
{code}
Class<?>[] classes = config
.getClasses("testClassName", Configuration.class);
{code}
kindly use
{code}
Class<?>[] classes =
config.getClasses("testClassName", Configuration.class);
{code}
3. Instead of assertTrue, you can use assertEquals()
4. Kindly add a testcase for a value of "". The output should be an empty array.
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Amar Kamat (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155023#comment-13155023 ]
Amar Kamat commented on HADOOP-7851:
------------------------------------
Configuration.getClasses() internally uses getTrimmedStrings() which returns an empty array in case the parameter value is not specified.
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Labels: configuration
> Fix For: 0.24.0
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203537#comment-13203537 ]
Hudson commented on HADOOP-7851:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #950 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/950/])
HADOOP-7851. Moving to 0.23.1 section in CHANGES.txt
acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241722
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156768#comment-13156768 ]
Hadoop QA commented on HADOOP-7851:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12505005/HADOOP-7851.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 15 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/405//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/405//console
This message is automatically generated.
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Harsh J (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156816#comment-13156816 ]
Harsh J commented on HADOOP-7851:
---------------------------------
This problem exists in 0.20-security as well. Would love it if you can post a patch for that as well?
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165957#comment-13165957 ]
Hudson commented on HADOOP-7851:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #1387 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1387/])
HADOOP-7851. Configuration.getClasses() never returns the default value. (amarrk)
amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212282
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165750#comment-13165750 ]
Uma Maheswara Rao G commented on HADOOP-7851:
---------------------------------------------
{quote}
-1 javadoc. The javadoc tool appears to have generated 9 warning messages.
{quote}
Javadoc comments are unrelated. sorry previous patch has problem, Tests should pass with this patch.
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7851:
----------------------------------------
Target Version/s: 0.24.0, 0.23.1 (was: 0.23.1, 0.24.0)
Status: Patch Available (was: Open)
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165969#comment-13165969 ]
Hudson commented on HADOOP-7851:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #1388 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1388/])
Added Uma's name to the CHANGES.txt file for HADOOP-7851.
amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212288
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165854#comment-13165854 ]
Uma Maheswara Rao G commented on HADOOP-7851:
---------------------------------------------
{quote}
- 1 javadoc. The javadoc tool appears to have generated 5 warning messages.
{quote}
Javadoc comments are again spurious.
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165987#comment-13165987 ]
Hudson commented on HADOOP-7851:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #1411 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1411/])
HADOOP-7851. Configuration.getClasses() never returns the default value. (amarrk)
amarrk : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212282
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156989#comment-13156989 ]
Uma Maheswara Rao G commented on HADOOP-7851:
---------------------------------------------
Yes Amar,
My first pacth should adderss your comment. But i used directly StringUtils api directly. So, that i could avaoid two times get invokation.
But coming to harsh comment, i thought to raise your point. But i could'nt find any usecase for setting "" for classnames. Do we have some use cases? If so, we can prefer 1st patch itself.
Thanks
Uma
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7851:
----------------------------------------
Attachment: (was: HADOOP-7851.patch)
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165400#comment-13165400 ]
Hadoop QA commented on HADOOP-7851:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12506628/HADOOP-7851.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 9 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.conf.TestConfiguration
org.apache.hadoop.http.TestHttpServer
org.apache.hadoop.http.TestPathFilter
org.apache.hadoop.http.TestGlobalFilter
org.apache.hadoop.http.TestServletFilter
org.apache.hadoop.conf.TestGetInstances
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/450//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/450//console
This message is automatically generated.
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Amar Kamat (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156984#comment-13156984 ]
Amar Kamat commented on HADOOP-7851:
------------------------------------
Not setting a value for a configuration parameter is different from setting it to "". Hence when the parameter is not set, the default value should be returned. When the parameter is set (including "") then the specified value should be returned and not the default. Hence a simple check before invoking getTrimmedStrings() should suffice.
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203072#comment-13203072 ]
Hudson commented on HADOOP-7851:
--------------------------------
Integrated in Hadoop-Hdfs-0.23-Commit #504 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/504/])
HADOOP-7851. Moving to 0.23.1 section in CHANGES.txt
acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241724
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HADOOP-7851) Configuration.getClasses() never
returns the default value.
Posted by "Uma Maheswara Rao G (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G reassigned HADOOP-7851:
-------------------------------------------
Assignee: Uma Maheswara Rao G
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
> Key: HADOOP-7851
> URL: https://issues.apache.org/jira/browse/HADOOP-7851
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Amar Kamat
> Assignee: Uma Maheswara Rao G
> Labels: configuration
> Fix For: 0.24.0
>
>
> Configuration.getClasses() never returns the default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira