You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/23 14:41:45 UTC
[GitHub] [spark] MrDLontheway opened a new pull request #27993:
[SPARK-31221][Core] invaild parquet map key type
MrDLontheway opened a new pull request #27993: [SPARK-31221][Core] invaild parquet map key type
URL: https://github.com/apache/spark/pull/27993
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
add parquet Map Key type verification
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Illegal parquet data type should not be written
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
add tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27993:
[SPARK-30996][Core] invaild parquet map key type
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27993: [SPARK-30996][Core] invaild parquet map key type
URL: https://github.com/apache/spark/pull/27993#discussion_r397745277
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormatSuite.scala
##########
@@ -56,4 +55,22 @@ class ParquetFileFormatSuite extends QueryTest with ParquetTest with SharedSpark
}.getCause
assert(exception.getMessage().contains("Could not read footer for file"))
}
+
+ test("read parquet map invaild key type") {
+ withTempDir { dir =>
+ val spark_session = spark
+ import spark_session.implicits._
+ val df = Seq(Map(Map(1 -> 1) -> 1L)).toDF("map")
+ val exception = intercept[AnalysisException] {
+ df.write.mode("overwrite").parquet(dir.getPath)
+ }
+ assert(exception.getMessage().contains("Parquet data source does not support"))
Review comment:
I'm not sure about what's your suggestion;
```
scala> val df = Seq(Map(Map(1 -> 1) -> 1L)).toDF("map")
df: org.apache.spark.sql.DataFrame = [map: map<map<int,int>,bigint>]
scala> df.printSchema
root
|-- map: map (nullable = true)
| |-- key: map
| | |-- key: integer
| | |-- value: integer (valueContainsNull = false)
| |-- value: long (valueContainsNull = false)
scala> df.write.mode("overwrite").parquet("/tmp/test")
scala> spark.read.load("/tmp/test").printSchema()
root
|-- map: map (nullable = true)
| |-- key: map
| | |-- key: integer
| | |-- value: integer (valueContainsNull = true)
| |-- value: long (valueContainsNull = true)
```
Any issue here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27993:
[SPARK-30996][Core] invaild parquet map key type
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27993: [SPARK-30996][Core] invaild parquet map key type
URL: https://github.com/apache/spark/pull/27993#issuecomment-602643335
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MrDLontheway commented on a change in pull request #27993:
[SPARK-30996][Core] invaild parquet map key type
Posted by GitBox <gi...@apache.org>.
MrDLontheway commented on a change in pull request #27993: [SPARK-30996][Core] invaild parquet map key type
URL: https://github.com/apache/spark/pull/27993#discussion_r397819088
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormatSuite.scala
##########
@@ -56,4 +55,22 @@ class ParquetFileFormatSuite extends QueryTest with ParquetTest with SharedSpark
}.getCause
assert(exception.getMessage().contains("Could not read footer for file"))
}
+
+ test("read parquet map invaild key type") {
+ withTempDir { dir =>
+ val spark_session = spark
+ import spark_session.implicits._
+ val df = Seq(Map(Map(1 -> 1) -> 1L)).toDF("map")
+ val exception = intercept[AnalysisException] {
+ df.write.mode("overwrite").parquet(dir.getPath)
+ }
+ assert(exception.getMessage().contains("Parquet data source does not support"))
Review comment:
thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27993:
[SPARK-30996][Core] invaild parquet map key type
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27993: [SPARK-30996][Core] invaild parquet map key type
URL: https://github.com/apache/spark/pull/27993#issuecomment-602644812
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MrDLontheway commented on issue #27993: [SPARK-30996][Core]
invaild parquet map key type
Posted by GitBox <gi...@apache.org>.
MrDLontheway commented on issue #27993: [SPARK-30996][Core] invaild parquet map key type
URL: https://github.com/apache/spark/pull/27993#issuecomment-604208882
https://github.com/apache/spark/blob/336621e277794ab2e6e917391a928ec662498fcf/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala#L228
The key is checked here, it seems that the keyType is not necessarily Primitive.
After I remove it, I can read the previous data normally. Can anyone explain this place?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MrDLontheway commented on issue #27993: [SPARK-30996][Core]
invaild parquet map key type
Posted by GitBox <gi...@apache.org>.
MrDLontheway commented on issue #27993: [SPARK-30996][Core] invaild parquet map key type
URL: https://github.com/apache/spark/pull/27993#issuecomment-603712440
cc @maropu @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27993:
[SPARK-30996][Core] invaild parquet map key type
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27993: [SPARK-30996][Core] invaild parquet map key type
URL: https://github.com/apache/spark/pull/27993#issuecomment-602643335
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27993:
[SPARK-30996][Core] invaild parquet map key type
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27993: [SPARK-30996][Core] invaild parquet map key type
URL: https://github.com/apache/spark/pull/27993#discussion_r397816937
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormatSuite.scala
##########
@@ -56,4 +55,22 @@ class ParquetFileFormatSuite extends QueryTest with ParquetTest with SharedSpark
}.getCause
assert(exception.getMessage().contains("Could not read footer for file"))
}
+
+ test("read parquet map invaild key type") {
+ withTempDir { dir =>
+ val spark_session = spark
+ import spark_session.implicits._
+ val df = Seq(Map(Map(1 -> 1) -> 1L)).toDF("map")
+ val exception = intercept[AnalysisException] {
+ df.write.mode("overwrite").parquet(dir.getPath)
+ }
+ assert(exception.getMessage().contains("Parquet data source does not support"))
Review comment:
btw, to make reviwers understood easily, you had better clearly write the PR description, what's an issue, example queries to reproduce the issue, and how-to-fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MrDLontheway commented on a change in pull request #27993:
[SPARK-30996][Core] invaild parquet map key type
Posted by GitBox <gi...@apache.org>.
MrDLontheway commented on a change in pull request #27993: [SPARK-30996][Core] invaild parquet map key type
URL: https://github.com/apache/spark/pull/27993#discussion_r397808676
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormatSuite.scala
##########
@@ -56,4 +55,22 @@ class ParquetFileFormatSuite extends QueryTest with ParquetTest with SharedSpark
}.getCause
assert(exception.getMessage().contains("Could not read footer for file"))
}
+
+ test("read parquet map invaild key type") {
+ withTempDir { dir =>
+ val spark_session = spark
+ import spark_session.implicits._
+ val df = Seq(Map(Map(1 -> 1) -> 1L)).toDF("map")
+ val exception = intercept[AnalysisException] {
+ df.write.mode("overwrite").parquet(dir.getPath)
+ }
+ assert(exception.getMessage().contains("Parquet data source does not support"))
Review comment:
o sorry , I seem to be wrong
This side will make it impossible to read. Let me review it again.
Seq(Seq(Map(Map(1 -> 1) -> StructValue(1L)))).toDF("long1")
root
|-- long1: array (nullable = true)
| |-- element: map (containsNull = true)
| | |-- key: map
| | | |-- key: integer
| | | |-- value: integer (valueContainsNull = false)
| | |-- value: struct (valueContainsNull = true)
| | | |-- l: long (nullable = false)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org