[jira] [Commented] (TS-1140) Implement HTTP method filtering in ip_allow.config

["Igor Galić (Commented JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230739#comment-13230739 ] 

Igor Galić commented on TS-1140:
--------------------------------

I don't like the smell of STL in this code, but it's been in before, so that's not Igor's beef.

line 107, while you're at it, please change the if()/else to have { braces  }
lines 129-138 are incomprehensible.. to me. Don't we have anywhere a foreach template? Alan...? ;)

what's happening in line 164 of that patch with the snprintf?
Looks like you're using tabs - our code uses spaces.

Two questions or.. wishes:
{code}
+src_ip=0.0.0.0-255.255.255.255                    action=ip_deny  method=PUSH|PURGE|DELETE
{code}

Maybe I'm delusioned, but I thought we had a /network notation somewhere around. Maybe it's just wishful thinking because in httpd we do.

And finally: This is my remap config:
{code}
map / http://127.0.0.1:8000 @method=GET @method=POST @method=HEAD @method=OPTIONS @action=allow
{code}
I used this because quickfilters where broken. But now that they worked and you moved the code to IpAllow.cc -- which part of our code takes care of parsing ^ that?
                
> Implement HTTP method filtering in ip_allow.config
> --------------------------------------------------
>
>                 Key: TS-1140
>                 URL: https://issues.apache.org/jira/browse/TS-1140
>             Project: Traffic Server
>          Issue Type: New Feature
>          Components: HTTP
>    Affects Versions: 3.1.3, 3.1.2
>            Reporter: Igor Brezac
>            Priority: Critical
>             Fix For: 3.1.3
>
>         Attachments: ts.patch
>
>
> Implement HTTP method filtering in ip_allow.config (and deprecate proxy.config.http.quick_filter.mask)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira