You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Reid Chan (JIRA)" <ji...@apache.org> on 2018/12/18 03:24:00 UTC
[jira] [Comment Edited] (HBASE-21048) Get LogLevel is not working
from console in secure environment
[ https://issues.apache.org/jira/browse/HBASE-21048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723609#comment-16723609 ]
Reid Chan edited comment on HBASE-21048 at 12/18/18 3:23 AM:
-------------------------------------------------------------
{code}
47 import org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting;
48 import org.apache.hbase.thirdparty.com.google.common.base.Charsets;
{code}
org.apache.hbase.thirdparty.com.* should be another import group, it‘s always the last one.
The correct import order should be, IIRC:
{code}
import org.apache.yetus.audience.InterfaceAudience;
import org.apache.yetus.audience.InterfaceStability;
import org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting;
import org.apache.hbase.thirdparty.com.google.common.base.Charsets;
{code}
I will review this patch late this week, not enough cycles recently.
was (Author: reidchan):
{code}
47 import org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting;
48 import org.apache.hbase.thirdparty.com.google.common.base.Charsets;
{code}
org.apache.hbase.thirdparty.com.* should be another import group, it always the last one.
The correct import order should be, IIRC:
{code}
import org.apache.yetus.audience.InterfaceAudience;
import org.apache.yetus.audience.InterfaceStability;
import org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting;
import org.apache.hbase.thirdparty.com.google.common.base.Charsets;
{code}
I will review this patch late this week, not enough cycles recently.
> Get LogLevel is not working from console in secure environment
> --------------------------------------------------------------
>
> Key: HBASE-21048
> URL: https://issues.apache.org/jira/browse/HBASE-21048
> Project: HBase
> Issue Type: Bug
> Reporter: Chandra Sekhar
> Assignee: Wei-Chiu Chuang
> Priority: Major
> Attachments: HBASE-21048.001.patch, HBASE-21048.master.001.patch, HBASE-21048.master.002.patch
>
>
> When we try to get log level of specific package in secure environment, getting SocketException.
> {code:java}
> hbase/master/bin# ./hbase org.apache.hadoop.hbase.http.log.LogLevel -getlevel host-xxxx:16010 org.apache.hadoop.hbase
> Connecting to http://host-xxxx:16010/logLevel?log=org.apache.hadoop.hbase
> java.net.SocketException: Unexpected end of file from server
> {code}
> It is trying to connect http instead of https
> code snippet that handling only http in *LogLevel.java*
> {code:java}
> public static void main(String[] args) {
> if (args.length == 3 && "-getlevel".equals(args[0])) {
> process("http://" + args[1] + "/logLevel?log=" + args[2]);
> return;
> }
> else if (args.length == 4 && "-setlevel".equals(args[0])) {
> process("http://" + args[1] + "/logLevel?log=" + args[2]
> + "&level=" + args[3]);
> return;
> }
> System.err.println(USAGES);
> System.exit(-1);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)