You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/14 07:48:13 UTC

[GitHub] [pulsar] Sherlock113 opened a new pull request, #16051: [Improve][Doc] Add explanation about the Helm release script

Sherlock113 opened a new pull request, #16051:
URL: https://github.com/apache/pulsar/pull/16051

   ### Motivation and Modifications
   
   Add more explanation about how to use the script to create relevant secrets for Pulsar if using the Helm chart to install it.
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [ ] `doc-not-needed` 
   (Please explain why)
     
   - [ ] `doc` 
   (Your PR contains doc changes)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #16051: [Improve][Doc] Add explanation about the Helm release script

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #16051:
URL: https://github.com/apache/pulsar/pull/16051#issuecomment-1156096247

   @tjiuming thanks for your professional guidance! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet merged pull request #16051: [Improve][Doc] Add explanation about the Helm release script

Posted by GitBox <gi...@apache.org>.
Anonymitaet merged PR #16051:
URL: https://github.com/apache/pulsar/pull/16051


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #16051: [Improve][Doc] Add explanation about the Helm release script

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #16051:
URL: https://github.com/apache/pulsar/pull/16051#issuecomment-1155894957

   @Sherlock113 
   Thanks for your contribution!
   
   1. Before submitting a doc PR, please [preview your changes locally](https://docs.google.com/document/d/1wszdtMRo6MhKbVaggPK7_bnKaC4TewuT--GWZZxJNGg/edit#). When submitting a PR, please attach the screenshots of your local preview. In this way, you can get your PR reviewed and merged more quickly.
   
   2. Does this change apply to multiple doc versions? If so, please [update them all](https://github.com/apache/pulsar/tree/master/site2/website/versioned_docs).
   
   Thank you! 😊


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Sherlock113 commented on pull request #16051: [Improve][Doc] Add explanation about the Helm release script

Posted by GitBox <gi...@apache.org>.
Sherlock113 commented on PR #16051:
URL: https://github.com/apache/pulsar/pull/16051#issuecomment-1157136434

   Hi @Anonymitaet I added the explanation to all versions and here is a preview image of the latest version for your reference:
   ![Screen Shot 2022-06-16 at 09 10 14](https://user-images.githubusercontent.com/65327072/173972379-2a203e9b-2372-4a74-9784-84517e5b6ce8.png)
   Thanks! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tjiuming commented on pull request #16051: [Improve][Doc] Add explanation about the Helm release script

Posted by GitBox <gi...@apache.org>.
tjiuming commented on PR #16051:
URL: https://github.com/apache/pulsar/pull/16051#issuecomment-1155900655

   @Anonymitaet 
   ![image](https://user-images.githubusercontent.com/95597048/173721951-4800de11-d6b5-437f-af88-f1da2b088e96.png)
   I've read the script, this change looks good to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org