You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by wr...@apache.org on 2001/11/17 04:27:09 UTC
cvs commit: apache-1.3/src/modules/standard mod_autoindex.c
wrowe 01/11/16 19:27:09
Modified: src/modules/standard mod_autoindex.c
Log:
Correct mod_autoindex's test of the query string's requested ordering.
This patch is a bit more paranoid than Kestutis's, but this is user
supplied input, so a bit of paranoia is healthy.
PR: 8771
Submitted by: Kestutis Kupciunas <ke...@soften.ktu.lt>
Revision Changes Path
1.121 +2 -2 apache-1.3/src/modules/standard/mod_autoindex.c
Index: mod_autoindex.c
===================================================================
RCS file: /home/cvs/apache-1.3/src/modules/standard/mod_autoindex.c,v
retrieving revision 1.120
retrieving revision 1.121
diff -u -r1.120 -r1.121
--- mod_autoindex.c 2001/03/09 10:10:33 1.120
+++ mod_autoindex.c 2001/11/17 03:27:09 1.121
@@ -1673,8 +1673,8 @@
else {
keyid = *qstring;
ap_getword(r->pool, &qstring, '=');
- if (qstring != '\0') {
- direction = *qstring;
+ if (*qstring == D_DESCENDING) {
+ direction = D_DESCENDING;
}
else {
direction = D_ASCENDING;