You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by nicolas de loof <ni...@gmail.com> on 2011/08/24 17:28:27 UTC
fix wagon http lightweight
I'm testing a fix for WAGON-346 <http://jira.codehaus.org/browse/WAGON-346> and
WAGON-347 <http://jira.codehaus.org/browse/WAGON-347>
Before I commit anything to svn I'd like your advice : see
https://github.com/ndeloof/maven-wagon/tree/wagon-1.x
The idea to make LightWeightHttpWagon thread-safe despite the
java.net.Authenticator static singleton, is to have a custom Authenticator
shared component and callback methods to the wagon instance, using a
ThreadLocal to keep track of "current" wagon
For WAGON-347 the preemptive authentication can be configured either per
repository using a "preemptiveAuthentication" parameter, or system wide
using -Dmaven.wagon.http.preemptiveAuthentication=true
Re: fix wagon http lightweight
Posted by Olivier Lamy <ol...@apache.org>.
Hello,
Your changes looks good.
It will be nice to see those merged back in the ASF community scm.
2011/8/27 nicolas de loof <ni...@gmail.com>:
> I just can't get git svn to work and push my changes to wagon 1.x branch
> feel free to pick-up those changes if you like them
>
> 2011/8/24 nicolas de loof <ni...@gmail.com>
>
>> I'm testing a fix for WAGON-346<http://jira.codehaus.org/browse/WAGON-346> and
>> WAGON-347 <http://jira.codehaus.org/browse/WAGON-347>
>> Before I commit anything to svn I'd like your advice : see
>> https://github.com/ndeloof/maven-wagon/tree/wagon-1.x
>>
>> The idea to make LightWeightHttpWagon thread-safe despite the
>> java.net.Authenticator static singleton, is to have a custom Authenticator
>> shared component and callback methods to the wagon instance, using a
>> ThreadLocal to keep track of "current" wagon
>>
>> For WAGON-347 the preemptive authentication can be configured either per
>> repository using a "preemptiveAuthentication" parameter, or system wide
>> using -Dmaven.wagon.http.preemptiveAuthentication=true
>>
>
--
Olivier Lamy
Talend : http://talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: fix wagon http lightweight
Posted by Olivier Lamy <ol...@apache.org>.
Why not commit your changes in trunk ?
If you're not volunteer. I will do this wagon 2.0 first release.
--
Olivier
send from a mobile
Le 28 août 2011 11:13, "nicolas de loof" <ni...@gmail.com> a
écrit :
> except for getting volunteers, why shouldn't we be able to release pretty
> quickly ?
> jenkins releases every week :P
>
> 2011/8/28 Mark Struberg <st...@yahoo.de>
>
>> yea, wagon-http-lightweight has lots of systematic problems. Mainly the
>> inability to correctly handle files which are bigger than the memory
given
>> via -Xmx
>>
>> I think John tried once to deprecate the lightweight provider, but then
>> reverted it back because we got quite a few bugs reported for wagon-http.
I
>> think it is worth it to try it again and this time to just fix the bugs
in
>> wagon-http.
>>
>> Of course this would mean that we should be ready to release 2 or 3 new
>> wagon + maven versions pretty quickly...
>>
>> LieGrue,
>> strub
>>
>> --- On Sun, 8/28/11, nicolas de loof <ni...@gmail.com> wrote:
>>
>> > From: nicolas de loof <ni...@gmail.com>
>> > Subject: Re: fix wagon http lightweight
>> > To: "Maven Developers List" <de...@maven.apache.org>
>> > Date: Sunday, August 28, 2011, 8:04 AM
>> > lightweight-http-wagon
>> > http-wagon could replace it
>> >
>> > 2011/8/28 Mark Struberg <st...@yahoo.de>
>> >
>> > > Hi Nicolas!
>> > >
>> > > Not really sure what you are talking of. Which
>> > parts/versions do you like
>> > > to deprecate and which part of wagon-webdav got
>> > deprecated?
>> > >
>> > > LieGrue,
>> > > strub
>> > >
>> > >
>> > > --- On Sun, 8/28/11, nicolas de loof <ni...@gmail.com>
>> > wrote:
>> > >
>> > > > From: nicolas de loof <ni...@gmail.com>
>> > > > Subject: Re: fix wagon http lightweight
>> > > > To: "Maven Developers List" <de...@maven.apache.org>
>> > > > Date: Sunday, August 28, 2011, 7:30 AM
>> > > > Merge fails, need some rework to
>> > > > match trunk changes
>> > > > would be simpler to deprecate and drop this shit
>> > out from
>> > > > repository as we
>> > > > did for wagon-webdav
>> > > >
>> > > > 2011/8/27 Mark Struberg <st...@yahoo.de>
>> > > >
>> > > > > Nicolas,
>> > > > >
>> > > > > I'm currently reviewing your github work. It
>> > basically
>> > > > looks good, but it
>> > > > > should be applied to trunk (maven-2.x). The
>> > changes
>> > > > you did needs java5, but
>> > > > > wagon-1.x is still java-1.4 only. Switching
>> > to java5
>> > > > is one of the main
>> > > > > difference between wagon-1.x and wagon-2.x
>> > > > >
>> > > > > The patch should pretty much apply without
>> > much
>> > > > changes.
>> > > > >
>> > > > > txs and LieGrue,
>> > > > > strub
>> > > > >
>> > > > > --- On Sat, 8/27/11, nicolas de loof <ni...@gmail.com>
>> > > > wrote:
>> > > > >
>> > > > > > From: nicolas de loof <ni...@gmail.com>
>> > > > > > Subject: Re: fix wagon http
>> > lightweight
>> > > > > > To: "Maven Developers List" <de...@maven.apache.org>
>> > > > > > Date: Saturday, August 27, 2011, 5:27
>> > AM
>> > > > > > I just can't get git svn to work and
>> > > > > > push my changes to wagon 1.x branch
>> > > > > > feel free to pick-up those changes if
>> > you like
>> > > > them
>> > > > > >
>> > > > > > 2011/8/24 nicolas de loof <ni...@gmail.com>
>> > > > > >
>> > > > > > > I'm testing a fix for
>> > WAGON-346<
>> > > > > http://jira.codehaus.org/browse/WAGON-346> and
>> > > > > > > WAGON-347 <http://jira.codehaus.org/browse/WAGON-347>
>> > > > > > > Before I commit anything to svn
>> > I'd like
>> > > > your advice :
>> > > > > > see
>> > > > > > > https://github.com/ndeloof/maven-wagon/tree/wagon-1.x
>> > > > > > >
>> > > > > > > The idea to make
>> > LightWeightHttpWagon
>> > > > thread-safe
>> > > > > > despite the
>> > > > > > > java.net.Authenticator static
>> > singleton, is
>> > > > to have a
>> > > > > > custom Authenticator
>> > > > > > > shared component and callback
>> > methods to the
>> > > > wagon
>> > > > > > instance, using a
>> > > > > > > ThreadLocal to keep track of
>> > "current"
>> > > > wagon
>> > > > > > >
>> > > > > > > For WAGON-347 the preemptive
>> > authentication
>> > > > can be
>> > > > > > configured either per
>> > > > > > > repository using a
>> > > > "preemptiveAuthentication"
>> > > > > > parameter, or system wide
>> > > > > > > using
>> > > > > >
>> > -Dmaven.wagon.http.preemptiveAuthentication=true
>> > > > > > >
>> > > > > >
>> > > > >
>> > > > >
>> > > >
>> > ---------------------------------------------------------------------
>> > > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> > > > > For additional commands, e-mail: dev-help@maven.apache.org
>> > > > >
>> > > > >
>> > > >
>> > >
>> > >
>> > ---------------------------------------------------------------------
>> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> > > For additional commands, e-mail: dev-help@maven.apache.org
>> > >
>> > >
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
Re: fix wagon http lightweight
Posted by nicolas de loof <ni...@gmail.com>.
except for getting volunteers, why shouldn't we be able to release pretty
quickly ?
jenkins releases every week :P
2011/8/28 Mark Struberg <st...@yahoo.de>
> yea, wagon-http-lightweight has lots of systematic problems. Mainly the
> inability to correctly handle files which are bigger than the memory given
> via -Xmx
>
> I think John tried once to deprecate the lightweight provider, but then
> reverted it back because we got quite a few bugs reported for wagon-http. I
> think it is worth it to try it again and this time to just fix the bugs in
> wagon-http.
>
> Of course this would mean that we should be ready to release 2 or 3 new
> wagon + maven versions pretty quickly...
>
> LieGrue,
> strub
>
> --- On Sun, 8/28/11, nicolas de loof <ni...@gmail.com> wrote:
>
> > From: nicolas de loof <ni...@gmail.com>
> > Subject: Re: fix wagon http lightweight
> > To: "Maven Developers List" <de...@maven.apache.org>
> > Date: Sunday, August 28, 2011, 8:04 AM
> > lightweight-http-wagon
> > http-wagon could replace it
> >
> > 2011/8/28 Mark Struberg <st...@yahoo.de>
> >
> > > Hi Nicolas!
> > >
> > > Not really sure what you are talking of. Which
> > parts/versions do you like
> > > to deprecate and which part of wagon-webdav got
> > deprecated?
> > >
> > > LieGrue,
> > > strub
> > >
> > >
> > > --- On Sun, 8/28/11, nicolas de loof <ni...@gmail.com>
> > wrote:
> > >
> > > > From: nicolas de loof <ni...@gmail.com>
> > > > Subject: Re: fix wagon http lightweight
> > > > To: "Maven Developers List" <de...@maven.apache.org>
> > > > Date: Sunday, August 28, 2011, 7:30 AM
> > > > Merge fails, need some rework to
> > > > match trunk changes
> > > > would be simpler to deprecate and drop this shit
> > out from
> > > > repository as we
> > > > did for wagon-webdav
> > > >
> > > > 2011/8/27 Mark Struberg <st...@yahoo.de>
> > > >
> > > > > Nicolas,
> > > > >
> > > > > I'm currently reviewing your github work. It
> > basically
> > > > looks good, but it
> > > > > should be applied to trunk (maven-2.x). The
> > changes
> > > > you did needs java5, but
> > > > > wagon-1.x is still java-1.4 only. Switching
> > to java5
> > > > is one of the main
> > > > > difference between wagon-1.x and wagon-2.x
> > > > >
> > > > > The patch should pretty much apply without
> > much
> > > > changes.
> > > > >
> > > > > txs and LieGrue,
> > > > > strub
> > > > >
> > > > > --- On Sat, 8/27/11, nicolas de loof <ni...@gmail.com>
> > > > wrote:
> > > > >
> > > > > > From: nicolas de loof <ni...@gmail.com>
> > > > > > Subject: Re: fix wagon http
> > lightweight
> > > > > > To: "Maven Developers List" <de...@maven.apache.org>
> > > > > > Date: Saturday, August 27, 2011, 5:27
> > AM
> > > > > > I just can't get git svn to work and
> > > > > > push my changes to wagon 1.x branch
> > > > > > feel free to pick-up those changes if
> > you like
> > > > them
> > > > > >
> > > > > > 2011/8/24 nicolas de loof <ni...@gmail.com>
> > > > > >
> > > > > > > I'm testing a fix for
> > WAGON-346<
> > > > > http://jira.codehaus.org/browse/WAGON-346> and
> > > > > > > WAGON-347 <http://jira.codehaus.org/browse/WAGON-347>
> > > > > > > Before I commit anything to svn
> > I'd like
> > > > your advice :
> > > > > > see
> > > > > > > https://github.com/ndeloof/maven-wagon/tree/wagon-1.x
> > > > > > >
> > > > > > > The idea to make
> > LightWeightHttpWagon
> > > > thread-safe
> > > > > > despite the
> > > > > > > java.net.Authenticator static
> > singleton, is
> > > > to have a
> > > > > > custom Authenticator
> > > > > > > shared component and callback
> > methods to the
> > > > wagon
> > > > > > instance, using a
> > > > > > > ThreadLocal to keep track of
> > "current"
> > > > wagon
> > > > > > >
> > > > > > > For WAGON-347 the preemptive
> > authentication
> > > > can be
> > > > > > configured either per
> > > > > > > repository using a
> > > > "preemptiveAuthentication"
> > > > > > parameter, or system wide
> > > > > > > using
> > > > > >
> > -Dmaven.wagon.http.preemptiveAuthentication=true
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > >
> > ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > > >
> > > > >
> > > >
> > >
> > >
> > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > For additional commands, e-mail: dev-help@maven.apache.org
> > >
> > >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: fix wagon http lightweight
Posted by nicolas de loof <ni...@gmail.com>.
I merged my fix to 2.x / trunk and committed
I'll no look for a fix on java 1.4 - will probably be a brute force
syncrhonized(LightWeightHttpWagon.class) { ... }
2011/8/28 Mark Struberg <st...@yahoo.de>
> In wagon-2.0 we also upgraded from commons-httpclient-3.x to
> httpcomponents.client-4.x. There have been lots of changes under the hood.
> I'd not be surprised if they have also changed the logging. But would need
> to check that.
>
> LieGrue,
> strub
>
> --- On Sun, 8/28/11, nicolas de loof <ni...@gmail.com> wrote:
>
> > From: nicolas de loof <ni...@gmail.com>
> > Subject: Re: fix wagon http lightweight
> > To: "Maven Developers List" <de...@maven.apache.org>
> > Date: Sunday, August 28, 2011, 9:30 AM
> > can't we use slf4j to redirect such
> > log to whatever logging system ?
> >
> > 2011/8/28 Olivier Lamy <ol...@apache.org>
> >
> > > Hello
> > > Not so easy for core distrib due to commons-logging
> > dependency which is
> > > exclude.
> > >
> > > --
> > > Olivier
> > > send from a mobile
> > > Le 28 août 2011 10:05, "nicolas de loof" <ni...@gmail.com>
> > a
> > > écrit :
> > > > lightweight-http-wagon
> > > > http-wagon could replace it
> > > >
> > > > 2011/8/28 Mark Struberg <st...@yahoo.de>
> > > >
> > > >> Hi Nicolas!
> > > >>
> > > >> Not really sure what you are talking of.
> > Which parts/versions do you
> > > like
> > > >> to deprecate and which part of wagon-webdav
> > got deprecated?
> > > >>
> > > >> LieGrue,
> > > >> strub
> > > >>
> > > >>
> > > >> --- On Sun, 8/28/11, nicolas de loof <ni...@gmail.com>
> > wrote:
> > > >>
> > > >> > From: nicolas de loof <ni...@gmail.com>
> > > >> > Subject: Re: fix wagon http lightweight
> > > >> > To: "Maven Developers List" <de...@maven.apache.org>
> > > >> > Date: Sunday, August 28, 2011, 7:30 AM
> > > >> > Merge fails, need some rework to
> > > >> > match trunk changes
> > > >> > would be simpler to deprecate and drop
> > this shit out from
> > > >> > repository as we
> > > >> > did for wagon-webdav
> > > >> >
> > > >> > 2011/8/27 Mark Struberg <st...@yahoo.de>
> > > >> >
> > > >> > > Nicolas,
> > > >> > >
> > > >> > > I'm currently reviewing your github
> > work. It basically
> > > >> > looks good, but it
> > > >> > > should be applied to trunk
> > (maven-2.x). The changes
> > > >> > you did needs java5, but
> > > >> > > wagon-1.x is still java-1.4 only.
> > Switching to java5
> > > >> > is one of the main
> > > >> > > difference between wagon-1.x and
> > wagon-2.x
> > > >> > >
> > > >> > > The patch should pretty much apply
> > without much
> > > >> > changes.
> > > >> > >
> > > >> > > txs and LieGrue,
> > > >> > > strub
> > > >> > >
> > > >> > > --- On Sat, 8/27/11, nicolas de
> > loof <ni...@gmail.com>
> > > >> > wrote:
> > > >> > >
> > > >> > > > From: nicolas de loof <ni...@gmail.com>
> > > >> > > > Subject: Re: fix wagon http
> > lightweight
> > > >> > > > To: "Maven Developers List"
> > <de...@maven.apache.org>
> > > >> > > > Date: Saturday, August 27,
> > 2011, 5:27 AM
> > > >> > > > I just can't get git svn to
> > work and
> > > >> > > > push my changes to wagon 1.x
> > branch
> > > >> > > > feel free to pick-up those
> > changes if you like
> > > >> > them
> > > >> > > >
> > > >> > > > 2011/8/24 nicolas de loof
> > <ni...@gmail.com>
> > > >> > > >
> > > >> > > > > I'm testing a fix for
> > WAGON-346<
> > > >> > > http://jira.codehaus.org/browse/WAGON-346> and
> > > >> > > > > WAGON-347 <http://jira.codehaus.org/browse/WAGON-347>
> > > >> > > > > Before I commit anything
> > to svn I'd like
> > > >> > your advice :
> > > >> > > > see
> > > >> > > > > https://github.com/ndeloof/maven-wagon/tree/wagon-1.x
> > > >> > > > >
> > > >> > > > > The idea to make
> > LightWeightHttpWagon
> > > >> > thread-safe
> > > >> > > > despite the
> > > >> > > > > java.net.Authenticator
> > static singleton, is
> > > >> > to have a
> > > >> > > > custom Authenticator
> > > >> > > > > shared component and
> > callback methods to the
> > > >> > wagon
> > > >> > > > instance, using a
> > > >> > > > > ThreadLocal to keep track
> > of "current"
> > > >> > wagon
> > > >> > > > >
> > > >> > > > > For WAGON-347 the
> > preemptive authentication
> > > >> > can be
> > > >> > > > configured either per
> > > >> > > > > repository using a
> > > >> > "preemptiveAuthentication"
> > > >> > > > parameter, or system wide
> > > >> > > > > using
> > > >> > > >
> > -Dmaven.wagon.http.preemptiveAuthentication=true
> > > >> > > > >
> > > >> > > >
> > > >> > >
> > > >> > >
> > > >> >
> > ---------------------------------------------------------------------
> > > >> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > >> > > For additional commands, e-mail: dev-help@maven.apache.org
> > > >> > >
> > > >> > >
> > > >> >
> > > >>
> > > >>
> > ---------------------------------------------------------------------
> > > >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > >> For additional commands, e-mail: dev-help@maven.apache.org
> > > >>
> > > >>
> > >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: fix wagon http lightweight
Posted by Olivier Lamy <ol...@apache.org>.
Hello,
Personally, I would prefer a shading mechanism rather than introducing
slf4j dependency in core distrib.
2011/8/28 nicolas de loof <ni...@gmail.com>:
> can't we use slf4j to redirect such log to whatever logging system ?
>
> 2011/8/28 Olivier Lamy <ol...@apache.org>
>
>> Hello
>> Not so easy for core distrib due to commons-logging dependency which is
>> exclude.
>>
>> --
>> Olivier
>> send from a mobile
>> Le 28 août 2011 10:05, "nicolas de loof" <ni...@gmail.com> a
>> écrit :
>> > lightweight-http-wagon
>> > http-wagon could replace it
>> >
>> > 2011/8/28 Mark Struberg <st...@yahoo.de>
>> >
>> >> Hi Nicolas!
>> >>
>> >> Not really sure what you are talking of. Which parts/versions do you
>> like
>> >> to deprecate and which part of wagon-webdav got deprecated?
>> >>
>> >> LieGrue,
>> >> strub
>> >>
>> >>
>> >> --- On Sun, 8/28/11, nicolas de loof <ni...@gmail.com> wrote:
>> >>
>> >> > From: nicolas de loof <ni...@gmail.com>
>> >> > Subject: Re: fix wagon http lightweight
>> >> > To: "Maven Developers List" <de...@maven.apache.org>
>> >> > Date: Sunday, August 28, 2011, 7:30 AM
>> >> > Merge fails, need some rework to
>> >> > match trunk changes
>> >> > would be simpler to deprecate and drop this shit out from
>> >> > repository as we
>> >> > did for wagon-webdav
>> >> >
>> >> > 2011/8/27 Mark Struberg <st...@yahoo.de>
>> >> >
>> >> > > Nicolas,
>> >> > >
>> >> > > I'm currently reviewing your github work. It basically
>> >> > looks good, but it
>> >> > > should be applied to trunk (maven-2.x). The changes
>> >> > you did needs java5, but
>> >> > > wagon-1.x is still java-1.4 only. Switching to java5
>> >> > is one of the main
>> >> > > difference between wagon-1.x and wagon-2.x
>> >> > >
>> >> > > The patch should pretty much apply without much
>> >> > changes.
>> >> > >
>> >> > > txs and LieGrue,
>> >> > > strub
>> >> > >
>> >> > > --- On Sat, 8/27/11, nicolas de loof <ni...@gmail.com>
>> >> > wrote:
>> >> > >
>> >> > > > From: nicolas de loof <ni...@gmail.com>
>> >> > > > Subject: Re: fix wagon http lightweight
>> >> > > > To: "Maven Developers List" <de...@maven.apache.org>
>> >> > > > Date: Saturday, August 27, 2011, 5:27 AM
>> >> > > > I just can't get git svn to work and
>> >> > > > push my changes to wagon 1.x branch
>> >> > > > feel free to pick-up those changes if you like
>> >> > them
>> >> > > >
>> >> > > > 2011/8/24 nicolas de loof <ni...@gmail.com>
>> >> > > >
>> >> > > > > I'm testing a fix for WAGON-346<
>> >> > > http://jira.codehaus.org/browse/WAGON-346> and
>> >> > > > > WAGON-347 <http://jira.codehaus.org/browse/WAGON-347>
>> >> > > > > Before I commit anything to svn I'd like
>> >> > your advice :
>> >> > > > see
>> >> > > > > https://github.com/ndeloof/maven-wagon/tree/wagon-1.x
>> >> > > > >
>> >> > > > > The idea to make LightWeightHttpWagon
>> >> > thread-safe
>> >> > > > despite the
>> >> > > > > java.net.Authenticator static singleton, is
>> >> > to have a
>> >> > > > custom Authenticator
>> >> > > > > shared component and callback methods to the
>> >> > wagon
>> >> > > > instance, using a
>> >> > > > > ThreadLocal to keep track of "current"
>> >> > wagon
>> >> > > > >
>> >> > > > > For WAGON-347 the preemptive authentication
>> >> > can be
>> >> > > > configured either per
>> >> > > > > repository using a
>> >> > "preemptiveAuthentication"
>> >> > > > parameter, or system wide
>> >> > > > > using
>> >> > > > -Dmaven.wagon.http.preemptiveAuthentication=true
>> >> > > > >
>> >> > > >
>> >> > >
>> >> > >
>> >> > ---------------------------------------------------------------------
>> >> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> >> > > For additional commands, e-mail: dev-help@maven.apache.org
>> >> > >
>> >> > >
>> >> >
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> >> For additional commands, e-mail: dev-help@maven.apache.org
>> >>
>> >>
>>
>
--
Olivier Lamy
Talend : http://talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: fix wagon http lightweight
Posted by Mark Struberg <st...@yahoo.de>.
In wagon-2.0 we also upgraded from commons-httpclient-3.x to httpcomponents.client-4.x. There have been lots of changes under the hood. I'd not be surprised if they have also changed the logging. But would need to check that.
LieGrue,
strub
--- On Sun, 8/28/11, nicolas de loof <ni...@gmail.com> wrote:
> From: nicolas de loof <ni...@gmail.com>
> Subject: Re: fix wagon http lightweight
> To: "Maven Developers List" <de...@maven.apache.org>
> Date: Sunday, August 28, 2011, 9:30 AM
> can't we use slf4j to redirect such
> log to whatever logging system ?
>
> 2011/8/28 Olivier Lamy <ol...@apache.org>
>
> > Hello
> > Not so easy for core distrib due to commons-logging
> dependency which is
> > exclude.
> >
> > --
> > Olivier
> > send from a mobile
> > Le 28 août 2011 10:05, "nicolas de loof" <ni...@gmail.com>
> a
> > écrit :
> > > lightweight-http-wagon
> > > http-wagon could replace it
> > >
> > > 2011/8/28 Mark Struberg <st...@yahoo.de>
> > >
> > >> Hi Nicolas!
> > >>
> > >> Not really sure what you are talking of.
> Which parts/versions do you
> > like
> > >> to deprecate and which part of wagon-webdav
> got deprecated?
> > >>
> > >> LieGrue,
> > >> strub
> > >>
> > >>
> > >> --- On Sun, 8/28/11, nicolas de loof <ni...@gmail.com>
> wrote:
> > >>
> > >> > From: nicolas de loof <ni...@gmail.com>
> > >> > Subject: Re: fix wagon http lightweight
> > >> > To: "Maven Developers List" <de...@maven.apache.org>
> > >> > Date: Sunday, August 28, 2011, 7:30 AM
> > >> > Merge fails, need some rework to
> > >> > match trunk changes
> > >> > would be simpler to deprecate and drop
> this shit out from
> > >> > repository as we
> > >> > did for wagon-webdav
> > >> >
> > >> > 2011/8/27 Mark Struberg <st...@yahoo.de>
> > >> >
> > >> > > Nicolas,
> > >> > >
> > >> > > I'm currently reviewing your github
> work. It basically
> > >> > looks good, but it
> > >> > > should be applied to trunk
> (maven-2.x). The changes
> > >> > you did needs java5, but
> > >> > > wagon-1.x is still java-1.4 only.
> Switching to java5
> > >> > is one of the main
> > >> > > difference between wagon-1.x and
> wagon-2.x
> > >> > >
> > >> > > The patch should pretty much apply
> without much
> > >> > changes.
> > >> > >
> > >> > > txs and LieGrue,
> > >> > > strub
> > >> > >
> > >> > > --- On Sat, 8/27/11, nicolas de
> loof <ni...@gmail.com>
> > >> > wrote:
> > >> > >
> > >> > > > From: nicolas de loof <ni...@gmail.com>
> > >> > > > Subject: Re: fix wagon http
> lightweight
> > >> > > > To: "Maven Developers List"
> <de...@maven.apache.org>
> > >> > > > Date: Saturday, August 27,
> 2011, 5:27 AM
> > >> > > > I just can't get git svn to
> work and
> > >> > > > push my changes to wagon 1.x
> branch
> > >> > > > feel free to pick-up those
> changes if you like
> > >> > them
> > >> > > >
> > >> > > > 2011/8/24 nicolas de loof
> <ni...@gmail.com>
> > >> > > >
> > >> > > > > I'm testing a fix for
> WAGON-346<
> > >> > > http://jira.codehaus.org/browse/WAGON-346> and
> > >> > > > > WAGON-347 <http://jira.codehaus.org/browse/WAGON-347>
> > >> > > > > Before I commit anything
> to svn I'd like
> > >> > your advice :
> > >> > > > see
> > >> > > > > https://github.com/ndeloof/maven-wagon/tree/wagon-1.x
> > >> > > > >
> > >> > > > > The idea to make
> LightWeightHttpWagon
> > >> > thread-safe
> > >> > > > despite the
> > >> > > > > java.net.Authenticator
> static singleton, is
> > >> > to have a
> > >> > > > custom Authenticator
> > >> > > > > shared component and
> callback methods to the
> > >> > wagon
> > >> > > > instance, using a
> > >> > > > > ThreadLocal to keep track
> of "current"
> > >> > wagon
> > >> > > > >
> > >> > > > > For WAGON-347 the
> preemptive authentication
> > >> > can be
> > >> > > > configured either per
> > >> > > > > repository using a
> > >> > "preemptiveAuthentication"
> > >> > > > parameter, or system wide
> > >> > > > > using
> > >> > > >
> -Dmaven.wagon.http.preemptiveAuthentication=true
> > >> > > > >
> > >> > > >
> > >> > >
> > >> > >
> > >> >
> ---------------------------------------------------------------------
> > >> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >> > > For additional commands, e-mail: dev-help@maven.apache.org
> > >> > >
> > >> > >
> > >> >
> > >>
> > >>
> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >> For additional commands, e-mail: dev-help@maven.apache.org
> > >>
> > >>
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: fix wagon http lightweight
Posted by nicolas de loof <ni...@gmail.com>.
can't we use slf4j to redirect such log to whatever logging system ?
2011/8/28 Olivier Lamy <ol...@apache.org>
> Hello
> Not so easy for core distrib due to commons-logging dependency which is
> exclude.
>
> --
> Olivier
> send from a mobile
> Le 28 août 2011 10:05, "nicolas de loof" <ni...@gmail.com> a
> écrit :
> > lightweight-http-wagon
> > http-wagon could replace it
> >
> > 2011/8/28 Mark Struberg <st...@yahoo.de>
> >
> >> Hi Nicolas!
> >>
> >> Not really sure what you are talking of. Which parts/versions do you
> like
> >> to deprecate and which part of wagon-webdav got deprecated?
> >>
> >> LieGrue,
> >> strub
> >>
> >>
> >> --- On Sun, 8/28/11, nicolas de loof <ni...@gmail.com> wrote:
> >>
> >> > From: nicolas de loof <ni...@gmail.com>
> >> > Subject: Re: fix wagon http lightweight
> >> > To: "Maven Developers List" <de...@maven.apache.org>
> >> > Date: Sunday, August 28, 2011, 7:30 AM
> >> > Merge fails, need some rework to
> >> > match trunk changes
> >> > would be simpler to deprecate and drop this shit out from
> >> > repository as we
> >> > did for wagon-webdav
> >> >
> >> > 2011/8/27 Mark Struberg <st...@yahoo.de>
> >> >
> >> > > Nicolas,
> >> > >
> >> > > I'm currently reviewing your github work. It basically
> >> > looks good, but it
> >> > > should be applied to trunk (maven-2.x). The changes
> >> > you did needs java5, but
> >> > > wagon-1.x is still java-1.4 only. Switching to java5
> >> > is one of the main
> >> > > difference between wagon-1.x and wagon-2.x
> >> > >
> >> > > The patch should pretty much apply without much
> >> > changes.
> >> > >
> >> > > txs and LieGrue,
> >> > > strub
> >> > >
> >> > > --- On Sat, 8/27/11, nicolas de loof <ni...@gmail.com>
> >> > wrote:
> >> > >
> >> > > > From: nicolas de loof <ni...@gmail.com>
> >> > > > Subject: Re: fix wagon http lightweight
> >> > > > To: "Maven Developers List" <de...@maven.apache.org>
> >> > > > Date: Saturday, August 27, 2011, 5:27 AM
> >> > > > I just can't get git svn to work and
> >> > > > push my changes to wagon 1.x branch
> >> > > > feel free to pick-up those changes if you like
> >> > them
> >> > > >
> >> > > > 2011/8/24 nicolas de loof <ni...@gmail.com>
> >> > > >
> >> > > > > I'm testing a fix for WAGON-346<
> >> > > http://jira.codehaus.org/browse/WAGON-346> and
> >> > > > > WAGON-347 <http://jira.codehaus.org/browse/WAGON-347>
> >> > > > > Before I commit anything to svn I'd like
> >> > your advice :
> >> > > > see
> >> > > > > https://github.com/ndeloof/maven-wagon/tree/wagon-1.x
> >> > > > >
> >> > > > > The idea to make LightWeightHttpWagon
> >> > thread-safe
> >> > > > despite the
> >> > > > > java.net.Authenticator static singleton, is
> >> > to have a
> >> > > > custom Authenticator
> >> > > > > shared component and callback methods to the
> >> > wagon
> >> > > > instance, using a
> >> > > > > ThreadLocal to keep track of "current"
> >> > wagon
> >> > > > >
> >> > > > > For WAGON-347 the preemptive authentication
> >> > can be
> >> > > > configured either per
> >> > > > > repository using a
> >> > "preemptiveAuthentication"
> >> > > > parameter, or system wide
> >> > > > > using
> >> > > > -Dmaven.wagon.http.preemptiveAuthentication=true
> >> > > > >
> >> > > >
> >> > >
> >> > >
> >> > ---------------------------------------------------------------------
> >> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> > > For additional commands, e-mail: dev-help@maven.apache.org
> >> > >
> >> > >
> >> >
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> For additional commands, e-mail: dev-help@maven.apache.org
> >>
> >>
>
Re: fix wagon http lightweight
Posted by Olivier Lamy <ol...@apache.org>.
Hello
Not so easy for core distrib due to commons-logging dependency which is
exclude.
--
Olivier
send from a mobile
Le 28 août 2011 10:05, "nicolas de loof" <ni...@gmail.com> a
écrit :
> lightweight-http-wagon
> http-wagon could replace it
>
> 2011/8/28 Mark Struberg <st...@yahoo.de>
>
>> Hi Nicolas!
>>
>> Not really sure what you are talking of. Which parts/versions do you like
>> to deprecate and which part of wagon-webdav got deprecated?
>>
>> LieGrue,
>> strub
>>
>>
>> --- On Sun, 8/28/11, nicolas de loof <ni...@gmail.com> wrote:
>>
>> > From: nicolas de loof <ni...@gmail.com>
>> > Subject: Re: fix wagon http lightweight
>> > To: "Maven Developers List" <de...@maven.apache.org>
>> > Date: Sunday, August 28, 2011, 7:30 AM
>> > Merge fails, need some rework to
>> > match trunk changes
>> > would be simpler to deprecate and drop this shit out from
>> > repository as we
>> > did for wagon-webdav
>> >
>> > 2011/8/27 Mark Struberg <st...@yahoo.de>
>> >
>> > > Nicolas,
>> > >
>> > > I'm currently reviewing your github work. It basically
>> > looks good, but it
>> > > should be applied to trunk (maven-2.x). The changes
>> > you did needs java5, but
>> > > wagon-1.x is still java-1.4 only. Switching to java5
>> > is one of the main
>> > > difference between wagon-1.x and wagon-2.x
>> > >
>> > > The patch should pretty much apply without much
>> > changes.
>> > >
>> > > txs and LieGrue,
>> > > strub
>> > >
>> > > --- On Sat, 8/27/11, nicolas de loof <ni...@gmail.com>
>> > wrote:
>> > >
>> > > > From: nicolas de loof <ni...@gmail.com>
>> > > > Subject: Re: fix wagon http lightweight
>> > > > To: "Maven Developers List" <de...@maven.apache.org>
>> > > > Date: Saturday, August 27, 2011, 5:27 AM
>> > > > I just can't get git svn to work and
>> > > > push my changes to wagon 1.x branch
>> > > > feel free to pick-up those changes if you like
>> > them
>> > > >
>> > > > 2011/8/24 nicolas de loof <ni...@gmail.com>
>> > > >
>> > > > > I'm testing a fix for WAGON-346<
>> > > http://jira.codehaus.org/browse/WAGON-346> and
>> > > > > WAGON-347 <http://jira.codehaus.org/browse/WAGON-347>
>> > > > > Before I commit anything to svn I'd like
>> > your advice :
>> > > > see
>> > > > > https://github.com/ndeloof/maven-wagon/tree/wagon-1.x
>> > > > >
>> > > > > The idea to make LightWeightHttpWagon
>> > thread-safe
>> > > > despite the
>> > > > > java.net.Authenticator static singleton, is
>> > to have a
>> > > > custom Authenticator
>> > > > > shared component and callback methods to the
>> > wagon
>> > > > instance, using a
>> > > > > ThreadLocal to keep track of "current"
>> > wagon
>> > > > >
>> > > > > For WAGON-347 the preemptive authentication
>> > can be
>> > > > configured either per
>> > > > > repository using a
>> > "preemptiveAuthentication"
>> > > > parameter, or system wide
>> > > > > using
>> > > > -Dmaven.wagon.http.preemptiveAuthentication=true
>> > > > >
>> > > >
>> > >
>> > >
>> > ---------------------------------------------------------------------
>> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> > > For additional commands, e-mail: dev-help@maven.apache.org
>> > >
>> > >
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
Re: fix wagon http lightweight
Posted by Mark Struberg <st...@yahoo.de>.
yea, wagon-http-lightweight has lots of systematic problems. Mainly the inability to correctly handle files which are bigger than the memory given via -Xmx
I think John tried once to deprecate the lightweight provider, but then reverted it back because we got quite a few bugs reported for wagon-http. I think it is worth it to try it again and this time to just fix the bugs in wagon-http.
Of course this would mean that we should be ready to release 2 or 3 new wagon + maven versions pretty quickly...
LieGrue,
strub
--- On Sun, 8/28/11, nicolas de loof <ni...@gmail.com> wrote:
> From: nicolas de loof <ni...@gmail.com>
> Subject: Re: fix wagon http lightweight
> To: "Maven Developers List" <de...@maven.apache.org>
> Date: Sunday, August 28, 2011, 8:04 AM
> lightweight-http-wagon
> http-wagon could replace it
>
> 2011/8/28 Mark Struberg <st...@yahoo.de>
>
> > Hi Nicolas!
> >
> > Not really sure what you are talking of. Which
> parts/versions do you like
> > to deprecate and which part of wagon-webdav got
> deprecated?
> >
> > LieGrue,
> > strub
> >
> >
> > --- On Sun, 8/28/11, nicolas de loof <ni...@gmail.com>
> wrote:
> >
> > > From: nicolas de loof <ni...@gmail.com>
> > > Subject: Re: fix wagon http lightweight
> > > To: "Maven Developers List" <de...@maven.apache.org>
> > > Date: Sunday, August 28, 2011, 7:30 AM
> > > Merge fails, need some rework to
> > > match trunk changes
> > > would be simpler to deprecate and drop this shit
> out from
> > > repository as we
> > > did for wagon-webdav
> > >
> > > 2011/8/27 Mark Struberg <st...@yahoo.de>
> > >
> > > > Nicolas,
> > > >
> > > > I'm currently reviewing your github work. It
> basically
> > > looks good, but it
> > > > should be applied to trunk (maven-2.x). The
> changes
> > > you did needs java5, but
> > > > wagon-1.x is still java-1.4 only. Switching
> to java5
> > > is one of the main
> > > > difference between wagon-1.x and wagon-2.x
> > > >
> > > > The patch should pretty much apply without
> much
> > > changes.
> > > >
> > > > txs and LieGrue,
> > > > strub
> > > >
> > > > --- On Sat, 8/27/11, nicolas de loof <ni...@gmail.com>
> > > wrote:
> > > >
> > > > > From: nicolas de loof <ni...@gmail.com>
> > > > > Subject: Re: fix wagon http
> lightweight
> > > > > To: "Maven Developers List" <de...@maven.apache.org>
> > > > > Date: Saturday, August 27, 2011, 5:27
> AM
> > > > > I just can't get git svn to work and
> > > > > push my changes to wagon 1.x branch
> > > > > feel free to pick-up those changes if
> you like
> > > them
> > > > >
> > > > > 2011/8/24 nicolas de loof <ni...@gmail.com>
> > > > >
> > > > > > I'm testing a fix for
> WAGON-346<
> > > > http://jira.codehaus.org/browse/WAGON-346> and
> > > > > > WAGON-347 <http://jira.codehaus.org/browse/WAGON-347>
> > > > > > Before I commit anything to svn
> I'd like
> > > your advice :
> > > > > see
> > > > > > https://github.com/ndeloof/maven-wagon/tree/wagon-1.x
> > > > > >
> > > > > > The idea to make
> LightWeightHttpWagon
> > > thread-safe
> > > > > despite the
> > > > > > java.net.Authenticator static
> singleton, is
> > > to have a
> > > > > custom Authenticator
> > > > > > shared component and callback
> methods to the
> > > wagon
> > > > > instance, using a
> > > > > > ThreadLocal to keep track of
> "current"
> > > wagon
> > > > > >
> > > > > > For WAGON-347 the preemptive
> authentication
> > > can be
> > > > > configured either per
> > > > > > repository using a
> > > "preemptiveAuthentication"
> > > > > parameter, or system wide
> > > > > > using
> > > > >
> -Dmaven.wagon.http.preemptiveAuthentication=true
> > > > > >
> > > > >
> > > >
> > > >
> > >
> ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > >
> > > >
> > >
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: fix wagon http lightweight
Posted by nicolas de loof <ni...@gmail.com>.
lightweight-http-wagon
http-wagon could replace it
2011/8/28 Mark Struberg <st...@yahoo.de>
> Hi Nicolas!
>
> Not really sure what you are talking of. Which parts/versions do you like
> to deprecate and which part of wagon-webdav got deprecated?
>
> LieGrue,
> strub
>
>
> --- On Sun, 8/28/11, nicolas de loof <ni...@gmail.com> wrote:
>
> > From: nicolas de loof <ni...@gmail.com>
> > Subject: Re: fix wagon http lightweight
> > To: "Maven Developers List" <de...@maven.apache.org>
> > Date: Sunday, August 28, 2011, 7:30 AM
> > Merge fails, need some rework to
> > match trunk changes
> > would be simpler to deprecate and drop this shit out from
> > repository as we
> > did for wagon-webdav
> >
> > 2011/8/27 Mark Struberg <st...@yahoo.de>
> >
> > > Nicolas,
> > >
> > > I'm currently reviewing your github work. It basically
> > looks good, but it
> > > should be applied to trunk (maven-2.x). The changes
> > you did needs java5, but
> > > wagon-1.x is still java-1.4 only. Switching to java5
> > is one of the main
> > > difference between wagon-1.x and wagon-2.x
> > >
> > > The patch should pretty much apply without much
> > changes.
> > >
> > > txs and LieGrue,
> > > strub
> > >
> > > --- On Sat, 8/27/11, nicolas de loof <ni...@gmail.com>
> > wrote:
> > >
> > > > From: nicolas de loof <ni...@gmail.com>
> > > > Subject: Re: fix wagon http lightweight
> > > > To: "Maven Developers List" <de...@maven.apache.org>
> > > > Date: Saturday, August 27, 2011, 5:27 AM
> > > > I just can't get git svn to work and
> > > > push my changes to wagon 1.x branch
> > > > feel free to pick-up those changes if you like
> > them
> > > >
> > > > 2011/8/24 nicolas de loof <ni...@gmail.com>
> > > >
> > > > > I'm testing a fix for WAGON-346<
> > > http://jira.codehaus.org/browse/WAGON-346> and
> > > > > WAGON-347 <http://jira.codehaus.org/browse/WAGON-347>
> > > > > Before I commit anything to svn I'd like
> > your advice :
> > > > see
> > > > > https://github.com/ndeloof/maven-wagon/tree/wagon-1.x
> > > > >
> > > > > The idea to make LightWeightHttpWagon
> > thread-safe
> > > > despite the
> > > > > java.net.Authenticator static singleton, is
> > to have a
> > > > custom Authenticator
> > > > > shared component and callback methods to the
> > wagon
> > > > instance, using a
> > > > > ThreadLocal to keep track of "current"
> > wagon
> > > > >
> > > > > For WAGON-347 the preemptive authentication
> > can be
> > > > configured either per
> > > > > repository using a
> > "preemptiveAuthentication"
> > > > parameter, or system wide
> > > > > using
> > > > -Dmaven.wagon.http.preemptiveAuthentication=true
> > > > >
> > > >
> > >
> > >
> > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > For additional commands, e-mail: dev-help@maven.apache.org
> > >
> > >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: fix wagon http lightweight
Posted by Mark Struberg <st...@yahoo.de>.
Hi Nicolas!
Not really sure what you are talking of. Which parts/versions do you like to deprecate and which part of wagon-webdav got deprecated?
LieGrue,
strub
--- On Sun, 8/28/11, nicolas de loof <ni...@gmail.com> wrote:
> From: nicolas de loof <ni...@gmail.com>
> Subject: Re: fix wagon http lightweight
> To: "Maven Developers List" <de...@maven.apache.org>
> Date: Sunday, August 28, 2011, 7:30 AM
> Merge fails, need some rework to
> match trunk changes
> would be simpler to deprecate and drop this shit out from
> repository as we
> did for wagon-webdav
>
> 2011/8/27 Mark Struberg <st...@yahoo.de>
>
> > Nicolas,
> >
> > I'm currently reviewing your github work. It basically
> looks good, but it
> > should be applied to trunk (maven-2.x). The changes
> you did needs java5, but
> > wagon-1.x is still java-1.4 only. Switching to java5
> is one of the main
> > difference between wagon-1.x and wagon-2.x
> >
> > The patch should pretty much apply without much
> changes.
> >
> > txs and LieGrue,
> > strub
> >
> > --- On Sat, 8/27/11, nicolas de loof <ni...@gmail.com>
> wrote:
> >
> > > From: nicolas de loof <ni...@gmail.com>
> > > Subject: Re: fix wagon http lightweight
> > > To: "Maven Developers List" <de...@maven.apache.org>
> > > Date: Saturday, August 27, 2011, 5:27 AM
> > > I just can't get git svn to work and
> > > push my changes to wagon 1.x branch
> > > feel free to pick-up those changes if you like
> them
> > >
> > > 2011/8/24 nicolas de loof <ni...@gmail.com>
> > >
> > > > I'm testing a fix for WAGON-346<
> > http://jira.codehaus.org/browse/WAGON-346> and
> > > > WAGON-347 <http://jira.codehaus.org/browse/WAGON-347>
> > > > Before I commit anything to svn I'd like
> your advice :
> > > see
> > > > https://github.com/ndeloof/maven-wagon/tree/wagon-1.x
> > > >
> > > > The idea to make LightWeightHttpWagon
> thread-safe
> > > despite the
> > > > java.net.Authenticator static singleton, is
> to have a
> > > custom Authenticator
> > > > shared component and callback methods to the
> wagon
> > > instance, using a
> > > > ThreadLocal to keep track of "current"
> wagon
> > > >
> > > > For WAGON-347 the preemptive authentication
> can be
> > > configured either per
> > > > repository using a
> "preemptiveAuthentication"
> > > parameter, or system wide
> > > > using
> > > -Dmaven.wagon.http.preemptiveAuthentication=true
> > > >
> > >
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: fix wagon http lightweight
Posted by nicolas de loof <ni...@gmail.com>.
Merge fails, need some rework to match trunk changes
would be simpler to deprecate and drop this shit out from repository as we
did for wagon-webdav
2011/8/27 Mark Struberg <st...@yahoo.de>
> Nicolas,
>
> I'm currently reviewing your github work. It basically looks good, but it
> should be applied to trunk (maven-2.x). The changes you did needs java5, but
> wagon-1.x is still java-1.4 only. Switching to java5 is one of the main
> difference between wagon-1.x and wagon-2.x
>
> The patch should pretty much apply without much changes.
>
> txs and LieGrue,
> strub
>
> --- On Sat, 8/27/11, nicolas de loof <ni...@gmail.com> wrote:
>
> > From: nicolas de loof <ni...@gmail.com>
> > Subject: Re: fix wagon http lightweight
> > To: "Maven Developers List" <de...@maven.apache.org>
> > Date: Saturday, August 27, 2011, 5:27 AM
> > I just can't get git svn to work and
> > push my changes to wagon 1.x branch
> > feel free to pick-up those changes if you like them
> >
> > 2011/8/24 nicolas de loof <ni...@gmail.com>
> >
> > > I'm testing a fix for WAGON-346<
> http://jira.codehaus.org/browse/WAGON-346> and
> > > WAGON-347 <http://jira.codehaus.org/browse/WAGON-347>
> > > Before I commit anything to svn I'd like your advice :
> > see
> > > https://github.com/ndeloof/maven-wagon/tree/wagon-1.x
> > >
> > > The idea to make LightWeightHttpWagon thread-safe
> > despite the
> > > java.net.Authenticator static singleton, is to have a
> > custom Authenticator
> > > shared component and callback methods to the wagon
> > instance, using a
> > > ThreadLocal to keep track of "current" wagon
> > >
> > > For WAGON-347 the preemptive authentication can be
> > configured either per
> > > repository using a "preemptiveAuthentication"
> > parameter, or system wide
> > > using
> > -Dmaven.wagon.http.preemptiveAuthentication=true
> > >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: fix wagon http lightweight
Posted by Mark Struberg <st...@yahoo.de>.
Hi Nicolas!
Just do a git diff and patch it into your svn checkout directory.
You are a maven committer, and if you did the changes, then you should also be the one who committed it into our repo.
txs and LieGrue,
strub
--- On Sat, 8/27/11, nicolas de loof <ni...@gmail.com> wrote:
> From: nicolas de loof <ni...@gmail.com>
> Subject: Re: fix wagon http lightweight
> To: "Maven Developers List" <de...@maven.apache.org>
> Date: Saturday, August 27, 2011, 5:27 AM
> I just can't get git svn to work and
> push my changes to wagon 1.x branch
> feel free to pick-up those changes if you like them
>
> 2011/8/24 nicolas de loof <ni...@gmail.com>
>
> > I'm testing a fix for WAGON-346<http://jira.codehaus.org/browse/WAGON-346> and
> > WAGON-347 <http://jira.codehaus.org/browse/WAGON-347>
> > Before I commit anything to svn I'd like your advice :
> see
> > https://github.com/ndeloof/maven-wagon/tree/wagon-1.x
> >
> > The idea to make LightWeightHttpWagon thread-safe
> despite the
> > java.net.Authenticator static singleton, is to have a
> custom Authenticator
> > shared component and callback methods to the wagon
> instance, using a
> > ThreadLocal to keep track of "current" wagon
> >
> > For WAGON-347 the preemptive authentication can be
> configured either per
> > repository using a "preemptiveAuthentication"
> parameter, or system wide
> > using
> -Dmaven.wagon.http.preemptiveAuthentication=true
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: fix wagon http lightweight
Posted by Mark Struberg <st...@yahoo.de>.
Nicolas,
I'm currently reviewing your github work. It basically looks good, but it should be applied to trunk (maven-2.x). The changes you did needs java5, but wagon-1.x is still java-1.4 only. Switching to java5 is one of the main difference between wagon-1.x and wagon-2.x
The patch should pretty much apply without much changes.
txs and LieGrue,
strub
--- On Sat, 8/27/11, nicolas de loof <ni...@gmail.com> wrote:
> From: nicolas de loof <ni...@gmail.com>
> Subject: Re: fix wagon http lightweight
> To: "Maven Developers List" <de...@maven.apache.org>
> Date: Saturday, August 27, 2011, 5:27 AM
> I just can't get git svn to work and
> push my changes to wagon 1.x branch
> feel free to pick-up those changes if you like them
>
> 2011/8/24 nicolas de loof <ni...@gmail.com>
>
> > I'm testing a fix for WAGON-346<http://jira.codehaus.org/browse/WAGON-346> and
> > WAGON-347 <http://jira.codehaus.org/browse/WAGON-347>
> > Before I commit anything to svn I'd like your advice :
> see
> > https://github.com/ndeloof/maven-wagon/tree/wagon-1.x
> >
> > The idea to make LightWeightHttpWagon thread-safe
> despite the
> > java.net.Authenticator static singleton, is to have a
> custom Authenticator
> > shared component and callback methods to the wagon
> instance, using a
> > ThreadLocal to keep track of "current" wagon
> >
> > For WAGON-347 the preemptive authentication can be
> configured either per
> > repository using a "preemptiveAuthentication"
> parameter, or system wide
> > using
> -Dmaven.wagon.http.preemptiveAuthentication=true
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: fix wagon http lightweight
Posted by nicolas de loof <ni...@gmail.com>.
I just can't get git svn to work and push my changes to wagon 1.x branch
feel free to pick-up those changes if you like them
2011/8/24 nicolas de loof <ni...@gmail.com>
> I'm testing a fix for WAGON-346<http://jira.codehaus.org/browse/WAGON-346> and
> WAGON-347 <http://jira.codehaus.org/browse/WAGON-347>
> Before I commit anything to svn I'd like your advice : see
> https://github.com/ndeloof/maven-wagon/tree/wagon-1.x
>
> The idea to make LightWeightHttpWagon thread-safe despite the
> java.net.Authenticator static singleton, is to have a custom Authenticator
> shared component and callback methods to the wagon instance, using a
> ThreadLocal to keep track of "current" wagon
>
> For WAGON-347 the preemptive authentication can be configured either per
> repository using a "preemptiveAuthentication" parameter, or system wide
> using -Dmaven.wagon.http.preemptiveAuthentication=true
>