You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by gr...@apache.org on 2019/02/16 22:16:16 UTC

[kudu] branch branch-1.9.x updated (c7a994d -> 8f16041)

This is an automated email from the ASF dual-hosted git repository.

granthenke pushed a change to branch branch-1.9.x
in repository https://gitbox.apache.org/repos/asf/kudu.git.


    from c7a994d  [CMakeLists] get rid of warnings in ASAN builds
     new 64ba18d  docs: fix two broken links in the installation doc
     new 086b699  KUDU-2508: [DOCS] Recommend nscd even for static name resolutions
     new 5f09674  Reduce "Overwriting operations" log spam on bootstrap
     new b3df25c  [rebalancer] fix LOG() misprint in rebalancer
     new 8f16041  log_block_manager: fix invalid pointer

The 5 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 docs/installation.adoc              |  4 ++--
 docs/troubleshooting.adoc           | 12 +++++++++---
 src/kudu/fs/log_block_manager.cc    |  2 +-
 src/kudu/tablet/tablet_bootstrap.cc |  8 ++++----
 src/kudu/tools/rebalancer.cc        |  2 +-
 5 files changed, 17 insertions(+), 11 deletions(-)


[kudu] 05/05: log_block_manager: fix invalid pointer

Posted by gr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

granthenke pushed a commit to branch branch-1.9.x
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit 8f16041589d912e4fe138b780ed722efb71083f8
Author: Andrew Wong <aw...@cloudera.com>
AuthorDate: Wed Feb 13 15:15:37 2019 -0800

    log_block_manager: fix invalid pointer
    
    We saw a core dump after enabling VLOGing caused by an invalid pointer
    during OpenBlock(). We seem to be dereferencing a block that has been
    moved already.
    
    Change-Id: Ic6567f43a30c74abc4fcf677671737035e845c1a
    Reviewed-on: http://gerrit.cloudera.org:8080/12477
    Reviewed-by: Adar Dembo <ad...@cloudera.com>
    Reviewed-by: Hao Hao <ha...@cloudera.com>
    Tested-by: Kudu Jenkins
    (cherry picked from commit 57f0dae3678b7514d1fcf9231f21930287ac3e13)
    Reviewed-on: http://gerrit.cloudera.org:8080/12510
    Reviewed-by: Andrew Wong <aw...@cloudera.com>
    Tested-by: Grant Henke <gr...@apache.org>
---
 src/kudu/fs/log_block_manager.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/kudu/fs/log_block_manager.cc b/src/kudu/fs/log_block_manager.cc
index 52effeb..7692050 100644
--- a/src/kudu/fs/log_block_manager.cc
+++ b/src/kudu/fs/log_block_manager.cc
@@ -2060,7 +2060,7 @@ Status LogBlockManager::OpenBlock(const BlockId& block_id,
     return Status::NotFound("Can't find block", block_id.ToString());
   }
 
-  VLOG(3) << "Opened block " << (*block)->id()
+  VLOG(3) << "Opened block " << block_id
           << " from container " << lb->container()->ToString();
   block->reset(new internal::LogReadableBlock(std::move(lb)));
   return Status::OK();


[kudu] 04/05: [rebalancer] fix LOG() misprint in rebalancer

Posted by gr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

granthenke pushed a commit to branch branch-1.9.x
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit b3df25cc66213723692a9aa7ba7c54288c2e3f43
Author: Yingchun Lai <40...@qq.com>
AuthorDate: Tue Feb 12 10:50:54 2019 +0800

    [rebalancer] fix LOG() misprint in rebalancer
    
    Fix misprint of table name and table id.
    This changelist does not contain any functional modifications.
    
    Change-Id: Id58029e11adc06b556821eac56a3ee19d873efb7
    Reviewed-on: http://gerrit.cloudera.org:8080/12453
    Reviewed-by: Todd Lipcon <to...@apache.org>
    Tested-by: Todd Lipcon <to...@apache.org>
    (cherry picked from commit 5f3470a77aba10d8c784405bda987a01d6b33035)
    Reviewed-on: http://gerrit.cloudera.org:8080/12511
    Reviewed-by: Andrew Wong <aw...@cloudera.com>
    Tested-by: Kudu Jenkins
---
 src/kudu/tools/rebalancer.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/kudu/tools/rebalancer.cc b/src/kudu/tools/rebalancer.cc
index a1548b4..4291806 100644
--- a/src/kudu/tools/rebalancer.cc
+++ b/src/kudu/tools/rebalancer.cc
@@ -741,7 +741,7 @@ Status Rebalancer::BuildClusterInfo(const ClusterRawInfo& raw_info,
   for (const auto& tablet : raw_info.tablet_summaries) {
     if (!config_.move_rf1_replicas) {
       if (rf1_tables.find(tablet.table_id) != rf1_tables.end()) {
-        LOG(INFO) << Substitute("tablet $0 of table '$0' ($1) has single replica, skipping",
+        LOG(INFO) << Substitute("tablet $0 of table '$1' ($2) has single replica, skipping",
                                 tablet.id, tablet.table_name, tablet.table_id);
         continue;
       }


[kudu] 03/05: Reduce "Overwriting operations" log spam on bootstrap

Posted by gr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

granthenke pushed a commit to branch branch-1.9.x
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit 5f096744f7fc0e12871f52a3d632251967a72c32
Author: Will Berkeley <wd...@gmail.org>
AuthorDate: Thu Feb 14 17:13:09 2019 -0800

    Reduce "Overwriting operations" log spam on bootstrap
    
    While messing around on a cluster, I noticed that when bootstrapping
    tablets it would absolutely spew messages like the following:
    
    I0214 17:18:28.358758 13664 tablet_bootstrap.cc:910] T 97537c2af52940f48f06d32ecfdde2a2 P 09d6bf7a02124145b43f43cb7a667b3d: Overwriting operations starting at: 283482.180847 up to 283482.180847 with operation: 283483.180847
    
    This is an expected outcome when a leader or follower has uncommitted
    operations that get rolled back because of updates from a new leader in
    a later term. There's nothing unusual or noteworthy about it. So, let's
    not bother logging at INFO. I lowered the level to VLOG(1) in case
    someone finds a need to see it in the future.
    
    Change-Id: I965f5950d2076c7a1147b943003b5e5df9a2246b
    Reviewed-on: http://gerrit.cloudera.org:8080/12492
    Tested-by: Kudu Jenkins
    Reviewed-by: Andrew Wong <aw...@cloudera.com>
    Reviewed-by: Alexey Serbin <as...@cloudera.com>
    (cherry picked from commit 812955ee0983a5b0dfba2d50529f8972c25bf411)
    Reviewed-on: http://gerrit.cloudera.org:8080/12508
---
 src/kudu/tablet/tablet_bootstrap.cc | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/kudu/tablet/tablet_bootstrap.cc b/src/kudu/tablet/tablet_bootstrap.cc
index 084b1e0..e62549e 100644
--- a/src/kudu/tablet/tablet_bootstrap.cc
+++ b/src/kudu/tablet/tablet_bootstrap.cc
@@ -907,10 +907,10 @@ Status TabletBootstrap::HandleReplicateMessage(ReplayState* state,
     DCHECK(OpIdEquals(iter->second->replicate().id(), existing_entry->replicate().id()));
 
     const auto& last_entry = state->pending_replicates.rbegin()->second;
-    LOG_WITH_PREFIX(INFO) << "Overwriting operations starting at: "
-                          << existing_entry->replicate().id()
-                          << " up to: " << last_entry->replicate().id()
-                          << " with operation: " << replicate.id();
+    VLOG_WITH_PREFIX(1) << "Overwriting operations starting at: "
+                        << existing_entry->replicate().id()
+                        << " up to: " << last_entry->replicate().id()
+                        << " with operation: " << replicate.id();
 
     while (iter != state->pending_replicates.end()) {
       iter = state->pending_replicates.erase(iter);


[kudu] 02/05: KUDU-2508: [DOCS] Recommend nscd even for static name resolutions

Posted by gr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

granthenke pushed a commit to branch branch-1.9.x
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit 086b699533385d4e1eb12a318df28e5281e629dc
Author: Alex Rodoni <ar...@cloudera.com>
AuthorDate: Thu Feb 14 17:36:41 2019 -0800

    KUDU-2508: [DOCS] Recommend nscd even for static name resolutions
    
    Change-Id: I93b192a2c664262477200f34f3819e48bcbbfc26
    Reviewed-on: http://gerrit.cloudera.org:8080/12493
    Reviewed-by: Adar Dembo <ad...@cloudera.com>
    Tested-by: Adar Dembo <ad...@cloudera.com>
    Reviewed-by: Grant Henke <gr...@apache.org>
    (cherry picked from commit 2be008763cda5eb28c0dfa8863e396575fce91ab)
    Reviewed-on: http://gerrit.cloudera.org:8080/12506
    Reviewed-by: Andrew Wong <aw...@cloudera.com>
    Tested-by: Kudu Jenkins
---
 docs/troubleshooting.adoc | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/docs/troubleshooting.adoc b/docs/troubleshooting.adoc
index c3f8fbf..670c355 100644
--- a/docs/troubleshooting.adoc
+++ b/docs/troubleshooting.adoc
@@ -662,14 +662,20 @@ confidential or sensitive data.
 [[slow_dns_nscd]]
 === Slow DNS Lookups and `nscd`
 
-If the logs contain messages about slow name resolution like
+For better scalability on nodes hosting many replicas, we recommend that you use
+`nscd` (name service cache daemon) to cache both DNS name resolution and static name resolution (via `/etc/hosts`).
+
+When DNS lookups are slow, you will see a log message similar to the following:
 
 ----
 W0926 11:19:01.339553 27231 net_util.cc:129] Time spent resolving address for kudu-tserver.example.com: real 4.647s    user 0.000s     sys 0.000s
 ----
 
-then it may help to run `nscd` (the name service cache daemon). Consult your
-operating system's documentation for how to install and enable `nscd`.
+`nscd` (name service cache daemon) can alleviate slow name resolution by providing
+a cache for the most common name service requests, such as for passwords, groups,
+and hosts.
+
+Refer to your operating system documentation for how to install and enable `nscd`.
 
 == Issues using Kudu
 


[kudu] 01/05: docs: fix two broken links in the installation doc

Posted by gr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

granthenke pushed a commit to branch branch-1.9.x
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit 64ba18d2202d568e89460e219f2ef5451654d298
Author: Greg Solovyev <fi...@gmail.com>
AuthorDate: Wed Feb 13 18:20:33 2019 -0800

    docs: fix two broken links in the installation doc
    
    Change-Id: I249df2ac3a88bda9825419a852a752423a5cb04f
    Reviewed-on: http://gerrit.cloudera.org:8080/12480
    Tested-by: Kudu Jenkins
    Reviewed-by: Grant Henke <gr...@apache.org>
    (cherry picked from commit 794a9ecf8a23652ab8d5f65b4536f3850de1d445)
    Reviewed-on: http://gerrit.cloudera.org:8080/12507
    Reviewed-by: Andrew Wong <aw...@cloudera.com>
    Tested-by: Grant Henke <gr...@apache.org>
---
 docs/installation.adoc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/installation.adoc b/docs/installation.adoc
index 443bedb..7d219f2 100644
--- a/docs/installation.adoc
+++ b/docs/installation.adoc
@@ -34,7 +34,7 @@ from source. To run Kudu without installing anything, use the link:quickstart.ht
 NOTE: Cloudera Manager users can install and manage Kudu with
 link:http://www.cloudera.com/content/www/en-us/products/cloudera-manager.html[Cloudera Manager],
 instead of following these instructions. For more information, see Cloudera's
-link:http://www.cloudera.com/documentation/kudu/latest/topics/kudu_installation.html[Kudu documentation].
+link:http://www.cloudera.com/documentation/enterprise/latest/topics/kudu_install_upgrade_intro.html[Kudu documentation].
 
 .Upgrading Kudu
 To upgrade Kudu from a previous version, see <<upgrade>>.
@@ -573,7 +573,7 @@ $ sudo xcode-select --install
 .macOS Known Issues
 ====
 Kudu support for macOS is experimental, and should only be used for development.
-See link:https://issues.apache.org/browse/KUDU-1219[macOS Limitations & Known Issues]
+See link:https://issues.apache.org/jira/browse/KUDU-1219[macOS Limitations & Known Issues]
 for more information.
 ====