You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2017/01/28 05:18:17 UTC
[GitHub] incubator-guacamole-client pull request #115: GUACAMOLE-129: Set "Content-Di...
GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/115
GUACAMOLE-129: Set "Content-Disposition: attachment" for "application/octet-stream".
Lacking the `Content-Disposition: attachment` header, IE will attempt mimetype detection for the downloaded file (bad), and will possibly rename the file with the wrong extension (even worse).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-client content-disposition
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-client/pull/115.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #115
----
commit b32ee2e9e7a6310a681df09db8a1b5fb7de95568
Author: Michael Jumper <mj...@apache.org>
Date: 2017-01-28T05:15:57Z
GUACAMOLE-129: Set "Content-Disposition: attachment" for "application/octet-stream" downloads to ensure browser doesn't attempt mimetype detection.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request #115: GUACAMOLE-129: Set "Content-Di...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-guacamole-client/pull/115
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---