You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Paulex Yang (JIRA)" <ji...@apache.org> on 2006/04/14 04:09:00 UTC
[jira] Created: (HARMONY-346) java.text.DecimalFormat serialization
is to be implemented
java.text.DecimalFormat serialization is to be implemented
----------------------------------------------------------
Key: HARMONY-346
URL: http://issues.apache.org/jira/browse/HARMONY-346
Project: Harmony
Type: Bug
Components: Classlib
Reporter: Paulex Yang
Java 5 spec redefins DecimalFormat serialization form, meanwhile DecimalFormat wraps ICU now. So the serialization related methods readObject/writeObject needs to be reimplemented. I'll attach the testcase and related resource.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-346) java.text.DecimalFormat
serialization is to be implemented
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-346?page=comments#action_12378397 ]
George Harley commented on HARMONY-346:
---------------------------------------
Forgot to respond to your comment about the continuing number of failures in DecimalFormatTest. Yes, I see these too but committed your changes on the basis that they do not appear to influence the existing problems and your new tests pass OK.
Best regards,
George
> java.text.DecimalFormat serialization is to be implemented
> ----------------------------------------------------------
>
> Key: HARMONY-346
> URL: http://issues.apache.org/jira/browse/HARMONY-346
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Paulex Yang
> Assignee: George Harley
> Attachments: 01.JIRA346-v2.sh, 01.JIRA346.sh, 02.JIRA346-v2.diff, 02.JIRA346.diff, DecimalFormat-v2.ser, DecimalFormat.ser
>
> Java 5 spec redefins DecimalFormat serialization form, meanwhile DecimalFormat wraps ICU now. So the serialization related methods readObject/writeObject needs to be reimplemented. I'll attach the testcase and related resource.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-346) java.text.DecimalFormat
serialization is to be implemented
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-346?page=comments#action_12374861 ]
Paulex Yang commented on HARMONY-346:
-------------------------------------
Here goes the testcase to reproduce the bug:
public void test_serialization() {
DecimalFormat decimalFormat = new DecimalFormat();
try {
// serialize
ByteArrayOutputStream byteOStream = new ByteArrayOutputStream();
ObjectOutputStream objectOStream = new ObjectOutputStream(
byteOStream);
objectOStream.writeObject(decimalFormat);
// and deserialize
ObjectInputStream objectIStream = new ObjectInputStream(
new ByteArrayInputStream(byteOStream.toByteArray()));
objectIStream
.readObject();
} catch (Exception e1) {
fail("Errors occur during serialization");
}
}
RI: pass, Harmony, NotYetImplementedException thrown
> java.text.DecimalFormat serialization is to be implemented
> ----------------------------------------------------------
>
> Key: HARMONY-346
> URL: http://issues.apache.org/jira/browse/HARMONY-346
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Paulex Yang
>
> Java 5 spec redefins DecimalFormat serialization form, meanwhile DecimalFormat wraps ICU now. So the serialization related methods readObject/writeObject needs to be reimplemented. I'll attach the testcase and related resource.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-346) java.text.DecimalFormat
serialization is to be implemented
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-346?page=all ]
George Harley resolved HARMONY-346:
-----------------------------------
Resolution: Fixed
Hi Paulex,
Thank you for the refresh of your patches which have been committed in revsion 404992. Please could you check that they were applied as you expected.
Thank you for this enhancement.
Best regards,
George
> java.text.DecimalFormat serialization is to be implemented
> ----------------------------------------------------------
>
> Key: HARMONY-346
> URL: http://issues.apache.org/jira/browse/HARMONY-346
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Paulex Yang
> Assignee: George Harley
> Attachments: 01.JIRA346-v2.sh, 01.JIRA346.sh, 02.JIRA346-v2.diff, 02.JIRA346.diff, DecimalFormat-v2.ser, DecimalFormat.ser
>
> Java 5 spec redefins DecimalFormat serialization form, meanwhile DecimalFormat wraps ICU now. So the serialization related methods readObject/writeObject needs to be reimplemented. I'll attach the testcase and related resource.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-346) java.text.DecimalFormat serialization
is to be implemented
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-346?page=all ]
George Harley closed HARMONY-346:
---------------------------------
Verified by Paulex.
> java.text.DecimalFormat serialization is to be implemented
> ----------------------------------------------------------
>
> Key: HARMONY-346
> URL: http://issues.apache.org/jira/browse/HARMONY-346
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Paulex Yang
> Assignee: George Harley
> Attachments: 01.JIRA346-v2.sh, 01.JIRA346.sh, 02.JIRA346-v2.diff, 02.JIRA346.diff, DecimalFormat-v2.ser, DecimalFormat.ser
>
> Java 5 spec redefins DecimalFormat serialization form, meanwhile DecimalFormat wraps ICU now. So the serialization related methods readObject/writeObject needs to be reimplemented. I'll attach the testcase and related resource.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-346) java.text.DecimalFormat
serialization is to be implemented
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-346?page=all ]
George Harley reassigned HARMONY-346:
-------------------------------------
Assign To: George Harley
> java.text.DecimalFormat serialization is to be implemented
> ----------------------------------------------------------
>
> Key: HARMONY-346
> URL: http://issues.apache.org/jira/browse/HARMONY-346
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Paulex Yang
> Assignee: George Harley
>
> Java 5 spec redefins DecimalFormat serialization form, meanwhile DecimalFormat wraps ICU now. So the serialization related methods readObject/writeObject needs to be reimplemented. I'll attach the testcase and related resource.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-346) java.text.DecimalFormat
serialization is to be implemented
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-346?page=comments#action_12383188 ]
Paulex Yang commented on HARMONY-346:
-------------------------------------
The new revision looks fine, thank you, George. And I agree with you about the failed tests.
> java.text.DecimalFormat serialization is to be implemented
> ----------------------------------------------------------
>
> Key: HARMONY-346
> URL: http://issues.apache.org/jira/browse/HARMONY-346
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Paulex Yang
> Assignee: George Harley
> Attachments: 01.JIRA346-v2.sh, 01.JIRA346.sh, 02.JIRA346-v2.diff, 02.JIRA346.diff, DecimalFormat-v2.ser, DecimalFormat.ser
>
> Java 5 spec redefins DecimalFormat serialization form, meanwhile DecimalFormat wraps ICU now. So the serialization related methods readObject/writeObject needs to be reimplemented. I'll attach the testcase and related resource.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-346) java.text.DecimalFormat serialization
is to be implemented
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-346?page=all ]
Paulex Yang updated HARMONY-346:
--------------------------------
Attachment: 01.JIRA346-v2.sh
02.JIRA346-v2.diff
DecimalFormat-v2.ser
George, here goes the modified patch.
I noticed the merged testcase from original tests.api.java.text.DecimalFormat still fail on RI or Harmony(they are exclued before), I'll investigate later on these failures.
> java.text.DecimalFormat serialization is to be implemented
> ----------------------------------------------------------
>
> Key: HARMONY-346
> URL: http://issues.apache.org/jira/browse/HARMONY-346
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Paulex Yang
> Assignee: George Harley
> Attachments: 01.JIRA346-v2.sh, 01.JIRA346.sh, 02.JIRA346-v2.diff, 02.JIRA346.diff, DecimalFormat-v2.ser, DecimalFormat.ser
>
> Java 5 spec redefins DecimalFormat serialization form, meanwhile DecimalFormat wraps ICU now. So the serialization related methods readObject/writeObject needs to be reimplemented. I'll attach the testcase and related resource.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-346) java.text.DecimalFormat
serialization is to be implemented
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-346?page=comments#action_12376721 ]
George Harley commented on HARMONY-346:
---------------------------------------
Hi Paulex,
There have been a couple of big changes in the text test code since you supplied your attachments and they are making it very hard/impossible to easily apply the patch to DecimalFormatTest.java (the other parts of the patch go on fine).
Please could you supply a refresh of the patch just for the DecimalFormatTest.java file ?
Best regards,
George
> java.text.DecimalFormat serialization is to be implemented
> ----------------------------------------------------------
>
> Key: HARMONY-346
> URL: http://issues.apache.org/jira/browse/HARMONY-346
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Paulex Yang
> Assignee: George Harley
> Attachments: 01.JIRA346.sh, 02.JIRA346.diff, DecimalFormat.ser
>
> Java 5 spec redefins DecimalFormat serialization form, meanwhile DecimalFormat wraps ICU now. So the serialization related methods readObject/writeObject needs to be reimplemented. I'll attach the testcase and related resource.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-346) java.text.DecimalFormat serialization
is to be implemented
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-346?page=all ]
Paulex Yang updated HARMONY-346:
--------------------------------
Attachment: 01.JIRA346.sh
02.JIRA346.diff
DecimalFormat.ser
These files include implementation and test of serialization for DecimalFormat. thx.
> java.text.DecimalFormat serialization is to be implemented
> ----------------------------------------------------------
>
> Key: HARMONY-346
> URL: http://issues.apache.org/jira/browse/HARMONY-346
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Paulex Yang
> Assignee: George Harley
> Attachments: 01.JIRA346.sh, 02.JIRA346.diff, DecimalFormat.ser
>
> Java 5 spec redefins DecimalFormat serialization form, meanwhile DecimalFormat wraps ICU now. So the serialization related methods readObject/writeObject needs to be reimplemented. I'll attach the testcase and related resource.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira