[GitHub] rabbah commented on issue #3459: Wrap producer.send with Future

[GitBox <gi...@apache.org>]

rabbah commented on issue #3459: Wrap producer.send with Future
URL: https://github.com/apache/incubator-openwhisk/pull/3459#issuecomment-374456632
 
 
   Thanks for this patch. The culprit is `waitOnMetadata` in the `send` method
   ```
               ClusterAndWaitTime clusterAndWaitTime = waitOnMetadata(record.topic(), record.partition(), maxBlockTimeMs);
   ```
   
   I generally agree then with the fix. Since now the code would use a Scala future, we can eliminate the callback passed to the Java future and just use `andThen`.
   
   @markusthoemmes @cbickel one of you please also have a look.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services