You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/18 18:29:12 UTC
[GitHub] [arrow-datafusion] sarahyurick opened a new issue, #3195: Support "IS [NOT] UNKNOWN" syntax
sarahyurick opened a new issue, #3195:
URL: https://github.com/apache/arrow-datafusion/issues/3195
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
Similar to the issues regarding "IS NOT TRUE/FALSE" (#2265) and "IS TRUE/FALSE" (#3159), we should also support the "IS [NOT] UNKNOWN" boolean operator as well. Here is the Postgres documentation about how it works: https://www.postgresql.org/docs/current/functions-comparison.html
**Describe the solution you'd like**
This should be possible now that https://github.com/sqlparser-rs/sqlparser-rs/pull/583 has been merged. I believe the implementation should be similar to the one in #3189
**Describe alternatives you've considered**
None.
**Additional context**
None.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove closed issue #3195: Support "IS [NOT] UNKNOWN" syntax
Posted by GitBox <gi...@apache.org>.
andygrove closed issue #3195: Support "IS [NOT] UNKNOWN" syntax
URL: https://github.com/apache/arrow-datafusion/issues/3195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] isidentical commented on issue #3195: Support "IS [NOT] UNKNOWN" syntax
Posted by GitBox <gi...@apache.org>.
isidentical commented on issue #3195:
URL: https://github.com/apache/arrow-datafusion/issues/3195#issuecomment-1221089349
Thanks a lot for your answer @sarahyurick! Really happy to work on it (I'll probably wait for #3189 to be merged first to send the PR, so we can reduce the number of conflicts).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] sarahyurick commented on issue #3195: Support "IS [NOT] UNKNOWN" syntax
Posted by GitBox <gi...@apache.org>.
sarahyurick commented on issue #3195:
URL: https://github.com/apache/arrow-datafusion/issues/3195#issuecomment-1220849822
> @sarahyurick are you currently working on this (or interested in it) (was wondering whether I can pick it up as my first contribution)?
Sure, go for it! Feel free to tag me when you open the PR, too.
> Also quick question (to both you and @andygrove), I was briefly looking into the implementation of `IS UNKNOWN` and noticed that Arrow doesn't have a one-to-one mapping of `unknown` type. Does that mean `IS UNKNOWN` is going to check whether the value is null or not (like `is null`)?
From what I understand, `IS UNKNOWN` should only work on boolean and null types (as opposed to `IS NULL` which works on all types). This would be consistent with the Postgres documentation.
In my current PR #3189, `IS TRUE/FALSE` only works on boolean and null types as well. My guess is that you can do pretty much the exact same implementation, and then in `common/src/scalar.rs` make `is_unknown` and/or `is_not_unknown` that are like the existing `is_null` function, except they only allow 2 types and error for all other types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] isidentical commented on issue #3195: Support "IS [NOT] UNKNOWN" syntax
Posted by GitBox <gi...@apache.org>.
isidentical commented on issue #3195:
URL: https://github.com/apache/arrow-datafusion/issues/3195#issuecomment-1220705515
@sarahyurick are you currently working on this (or interested in it) (was wondering whether I can pick it up as my first contribution)?
Also quick question (to both you and @andygrove), I was briefly looking into the implementation of `IS UNKNOWN` and noticed that Arrow doesn't have a one-to-one mapping of `unknown` type. Does that mean `IS UNKNOWN` is going to check whether the value is null or not (like `is null`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] sarahyurick commented on issue #3195: Support "IS [NOT] UNKNOWN" syntax
Posted by GitBox <gi...@apache.org>.
sarahyurick commented on issue #3195:
URL: https://github.com/apache/arrow-datafusion/issues/3195#issuecomment-1221093272
Sounds good to me - I'll also be opening a PR for #2265 after #3189 merges, so hopefully with both of our contributions we can get all of the boolean operations working!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org