Re: [PR] fix: size aggregate spill batches by bytes as well as rows [datafusion]

["EmilyMatt (via GitHub)" <gi...@apache.org>]

EmilyMatt commented on PR #25853:
URL: https://github.com/apache/datafusion/pull/25853#issuecomment-5929231866

   While this can be a useful mechanism, I don't think it's the right solution for the problem at hand, I think the aggregate estimations can and should be improved, this ties us into behaviour that can be both bad for perf, and complex to maintain (and is also not very accurate since it uses averages)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org