You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/09/15 12:32:09 UTC

[GitHub] [netbeans] dukescript opened a new pull request #2371: Fixing nbjdk.home behavior broken by #2337

dukescript opened a new pull request #2371:
URL: https://github.com/apache/netbeans/pull/2371


   >  matthiasblaesing commented 6 hours ago in #2369:
   >  @mcdonnell-john I was able to reproduce your problem. It happens if the build JDK and the target JDK are not the same. I had this in my ".nbbuild.properties":
   ```
   #permit.jdk9.builds=true
   nbjdk.home=/home/matthias/bin/jdk-8
   ```
   > This will lead to ant finding the desktop classes, while in the compile run they are not present. 
   
   Please accept apology for not spotting this problem sooner. This is an additional fix for #2337 to make it work `nbjdk.home=` set.
   
   Up to @lkishalmi to decide whether to merge this, merge #2369 or merge both. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] matthiasblaesing commented on pull request #2371: Fixing nbjdk.home behavior broken by #2337

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2371:
URL: https://github.com/apache/netbeans/pull/2371#issuecomment-692708371


   There is talk about reverting #2337, as that commit is at least controversial.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] lkishalmi merged pull request #2371: Fixing nbjdk.home behavior broken by #2337

Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #2371:
URL: https://github.com/apache/netbeans/pull/2371


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists