You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/03 02:03:08 UTC

[GitHub] [rocketmq-dashboard] meateggmilk opened a new pull request #49: [ISSUE #48] Fix query message bug

meateggmilk opened a new pull request #49:
URL: https://github.com/apache/rocketmq-dashboard/pull/49


   ## What is the purpose of the change
   
   Fix a BUG when query messge by topic
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-dashboard] StyleTang commented on pull request #49: [ISSUE #48] Fix query message bug

Posted by GitBox <gi...@apache.org>.
StyleTang commented on pull request #49:
URL: https://github.com/apache/rocketmq-dashboard/pull/49#issuecomment-986268040


   LGTM
   According to [ConsumeQueue.java](https://github.com/apache/rocketmq/blob/master/store/src/main/java/org/apache/rocketmq/store/ConsumeQueue.java#L198-L213), the `consumer.searchOffset` response may be larger or smaller than what we expect, so RocketMQ Dashboard should use `start++`/`end--` logic, this workaround is a little tricky.
   Next time could you provide the test evidence, it is convenient for others to review.
   Thanks~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-dashboard] StyleTang merged pull request #49: [ISSUE #48] Fix query message bug

Posted by GitBox <gi...@apache.org>.
StyleTang merged pull request #49:
URL: https://github.com/apache/rocketmq-dashboard/pull/49


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org