[GitHub] [beam] alexeyinkin commented on a diff in pull request #22794: [Tour of Beam]: Welcome Screen frontend layout

[GitBox <gi...@apache.org>]

alexeyinkin commented on code in PR #22794:
URL: https://github.com/apache/beam/pull/22794#discussion_r960371056


##########
learning/tour-of-beam/frontend/lib/pages/welcome/screen.dart:
##########
@@ -65,15 +65,23 @@ class _SdkSelection extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    return ColoredBox(
+    return Container(
+      constraints: BoxConstraints(
+        minHeight: MediaQuery.of(context).size.height -

Review Comment:
   Explicit sizes should be the last resort. Can this be done with this?
   
   For two columns:
   ```
   WelcomeScreen
   +- PageContainer
      +- SingleChildScrollView
         +- Stack
            +- Row
               +- Left column without laptop but with blank container with the height of the laptop
               +- Right column
            +- Laptop sticked to the bottom
   ```
   
   For one column:
   ```
   WelcomeScreen
   +- PageContainer
      +- SingleChildScrollView
         +- Column
            +- Left column without laptop but with blank container
            +- Laptop
            +- Right column
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org