You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2023/01/17 16:57:21 UTC
[GitHub] [daffodil-vscode] Shanedell opened a new pull request, #424: Update README.md
Shanedell opened a new pull request, #424:
URL: https://github.com/apache/daffodil-vscode/pull/424
Update README.md:
- Add Nightly Tests GitHub action badge.
- Update build reqs to list Java 8 or higher instead of Java 11.
- Add information to install the extension from VS Code marketplace.
- Update download of Prebuilt file to point the VSIX file on Apache Daffodil Website.
Closes #411
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on a diff in pull request #424: Update README.md
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on code in PR #424:
URL: https://github.com/apache/daffodil-vscode/pull/424#discussion_r1072613597
##########
README.md:
##########
@@ -23,21 +23,38 @@
# Apache Daffodilâ„¢ Extension for Visual Studio Code
[](https://github.com/apache/daffodil-vscode/actions/workflows/CI.yml)
+[](https://github.com/apache/daffodil-vscode/actions/workflows/nightly.yml)
</div>
This is an extension for Visual Studio Code (VS Code) which enables the interactive debugging of DFDL schema parsing using [Apache Daffodil](https://daffodil.apache.org/).
## Build Requirements
-- Java Development Kit (JDK) 11 or higher
+- Java Development Kit (JDK) 8 or higher
- SBT 0.13.8 or higher
- Node 10 or higher
- Yarn (https://yarnpkg.com/getting-started/install)
-## Download - Prebuilt
+## Download
-Until the extension is available in the [VS Code Extension Marketplace](https://marketplace.visualstudio.com/vscode), please download the latest `.vsix` file from the [releases page](https://github.com/apache/daffodil-vscode/releases).
+### VS Code Marketplace
+
+The easiest way to install the extension is through the VS Code Extension Marketplace. The steps are as follow:
+
+- Open VS Code.
+- Navigate to extension marketplace (icon looks like stacked blocks).
+- Search for `Apache Daffodil VS Code Extension`.
+- The first result will be the item you want, click `Install`.
Review Comment:
Yep :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #424: Update README.md
Posted by GitBox <gi...@apache.org>.
Shanedell commented on code in PR #424:
URL: https://github.com/apache/daffodil-vscode/pull/424#discussion_r1072605658
##########
README.md:
##########
@@ -23,21 +23,38 @@
# Apache Daffodilâ„¢ Extension for Visual Studio Code
[](https://github.com/apache/daffodil-vscode/actions/workflows/CI.yml)
+[](https://github.com/apache/daffodil-vscode/actions/workflows/nightly.yml)
</div>
This is an extension for Visual Studio Code (VS Code) which enables the interactive debugging of DFDL schema parsing using [Apache Daffodil](https://daffodil.apache.org/).
## Build Requirements
-- Java Development Kit (JDK) 11 or higher
+- Java Development Kit (JDK) 8 or higher
- SBT 0.13.8 or higher
- Node 10 or higher
- Yarn (https://yarnpkg.com/getting-started/install)
-## Download - Prebuilt
+## Download
-Until the extension is available in the [VS Code Extension Marketplace](https://marketplace.visualstudio.com/vscode), please download the latest `.vsix` file from the [releases page](https://github.com/apache/daffodil-vscode/releases).
+### VS Code Marketplace
+
+The easiest way to install the extension is through the VS Code Extension Marketplace. The steps are as follow:
+
+- Open VS Code.
+- Navigate to extension marketplace (icon looks like stacked blocks).
+- Search for `Apache Daffodil VS Code Extension`.
+- The first result will be the item you want, click `Install`.
Review Comment:
@stevedlawrence Does the updated steps look better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell merged pull request #424: Update README.md
Posted by GitBox <gi...@apache.org>.
Shanedell merged PR #424:
URL: https://github.com/apache/daffodil-vscode/pull/424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on a diff in pull request #424: Update README.md
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on code in PR #424:
URL: https://github.com/apache/daffodil-vscode/pull/424#discussion_r1072572715
##########
README.md:
##########
@@ -23,21 +23,38 @@
# Apache Daffodilâ„¢ Extension for Visual Studio Code
[](https://github.com/apache/daffodil-vscode/actions/workflows/CI.yml)
+[](https://github.com/apache/daffodil-vscode/actions/workflows/nightly.yml)
</div>
This is an extension for Visual Studio Code (VS Code) which enables the interactive debugging of DFDL schema parsing using [Apache Daffodil](https://daffodil.apache.org/).
## Build Requirements
-- Java Development Kit (JDK) 11 or higher
+- Java Development Kit (JDK) 8 or higher
- SBT 0.13.8 or higher
- Node 10 or higher
- Yarn (https://yarnpkg.com/getting-started/install)
-## Download - Prebuilt
+## Download
-Until the extension is available in the [VS Code Extension Marketplace](https://marketplace.visualstudio.com/vscode), please download the latest `.vsix` file from the [releases page](https://github.com/apache/daffodil-vscode/releases).
+### VS Code Marketplace
+
+The easiest way to install the extension is through the VS Code Extension Marketplace. The steps are as follow:
+
+- Open VS Code.
+- Navigate to extension marketplace (icon looks like stacked blocks).
+- Search for `Apache Daffodil VS Code Extension`.
+- The first result will be the item you want, click `Install`.
Review Comment:
Thoughts on just including the instructions that markplace uses? e.g. `Ctrl+P` and run `ext install ASF.apache-daffodil-vscode`. Avoids having to describe icons that might change, or potenial ambiguities if the search ever finds some other extension or for some reason ours isn't first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org