[GitHub] [spark] srowen commented on a change in pull request #24086: [SPARK-27155][Build]update oracle docker image name

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #24086: [SPARK-27155][Build]update oracle docker image name
URL: https://github.com/apache/spark/pull/24086#discussion_r265898851
 
 

 ##########
 File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
 ##########
 @@ -55,7 +56,7 @@ class OracleIntegrationSuite extends DockerJDBCIntegrationSuite with SharedSQLCo
   import testImplicits._
 
   override val db = new DatabaseOnDocker {
-    override val imageName = "wnameless/oracle-xe-11g:16.04"
+    override val imageName = "deepdiver/docker-oracle-xe-11g:2.0"
 
 Review comment:
   Looks like this is how you build it:
   https://github.com/oracle/docker-images/blob/master/OracleDatabase/SingleInstance/README.md
   but looks like indeed you have to supply the binaries as they're not freely available.
   Yes at best I think we'd need to disable this test and parameterize it, as it's not going to work reliably anyway.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org