You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "fuweng11 (via GitHub)" <gi...@apache.org> on 2023/03/14 08:17:52 UTC
[GitHub] [inlong] fuweng11 opened a new pull request, #7596: [INLONG-7593][Manager] Fix unable to delete group
fuweng11 opened a new pull request, #7596:
URL: https://github.com/apache/inlong/pull/7596
### Prepare a Pull Request
- Fixes #7593
### Motivation
Fix unable to delete group.
### Modifications
Fix unable to delete group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #7596: [INLONG-7593][Manager] Fix unable to delete group
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #7596:
URL: https://github.com/apache/inlong/pull/7596#discussion_r1135361805
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/listener/sink/SinkResourceListener.java:
##########
@@ -67,7 +68,22 @@ public ListenerResult listen(WorkflowContext context) {
GroupResourceProcessForm form = (GroupResourceProcessForm) context.getProcessForm();
String groupId = form.getInlongGroupId();
log.info("begin to create sink resources for groupId={}", groupId);
- groupService.updateStatus(groupId, GroupStatus.CONFIG_ING.getCode(), context.getOperator());
+ GroupOperateType operateType = form.getGroupOperateType();
+ String operator = context.getOperator();
+ switch (operateType) {
Review Comment:
In addition, StreamSink does not have operations such as init, suspend and restart, so these operations should not be judged here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #7596: [INLONG-7593][Manager] Change the InlongGroup status when executing Sort and Queue listeners
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #7596:
URL: https://github.com/apache/inlong/pull/7596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] fuweng11 commented on a diff in pull request #7596: [INLONG-7593][Manager] Fix unable to delete InlongGroup
Posted by "fuweng11 (via GitHub)" <gi...@apache.org>.
fuweng11 commented on code in PR #7596:
URL: https://github.com/apache/inlong/pull/7596#discussion_r1136460039
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/listener/sink/SinkResourceListener.java:
##########
@@ -67,7 +68,22 @@ public ListenerResult listen(WorkflowContext context) {
GroupResourceProcessForm form = (GroupResourceProcessForm) context.getProcessForm();
String groupId = form.getInlongGroupId();
log.info("begin to create sink resources for groupId={}", groupId);
- groupService.updateStatus(groupId, GroupStatus.CONFIG_ING.getCode(), context.getOperator());
+ GroupOperateType operateType = form.getGroupOperateType();
+ String operator = context.getOperator();
+ switch (operateType) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #7596: [INLONG-7593][Manager] Fix unable to delete group
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #7596:
URL: https://github.com/apache/inlong/pull/7596#discussion_r1135359480
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/listener/sink/SinkResourceListener.java:
##########
@@ -67,7 +68,22 @@ public ListenerResult listen(WorkflowContext context) {
GroupResourceProcessForm form = (GroupResourceProcessForm) context.getProcessForm();
String groupId = form.getInlongGroupId();
log.info("begin to create sink resources for groupId={}", groupId);
- groupService.updateStatus(groupId, GroupStatus.CONFIG_ING.getCode(), context.getOperator());
+ GroupOperateType operateType = form.getGroupOperateType();
+ String operator = context.getOperator();
+ switch (operateType) {
Review Comment:
After updating the StreamSink, it should only change the status of InlongStream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] vernedeng commented on a diff in pull request #7596: [INLONG-7593][Manager] Fix unable to delete group
Posted by "vernedeng (via GitHub)" <gi...@apache.org>.
vernedeng commented on code in PR #7596:
URL: https://github.com/apache/inlong/pull/7596#discussion_r1135192966
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/listener/sink/SinkResourceListener.java:
##########
@@ -67,7 +68,22 @@ public ListenerResult listen(WorkflowContext context) {
GroupResourceProcessForm form = (GroupResourceProcessForm) context.getProcessForm();
String groupId = form.getInlongGroupId();
log.info("begin to create sink resources for groupId={}", groupId);
- groupService.updateStatus(groupId, GroupStatus.CONFIG_ING.getCode(), context.getOperator());
+ GroupOperateType operateType = form.getGroupOperateType();
+ String operator = context.getOperator();
+ switch (operateType) {
+ case INIT:
+ groupService.updateStatus(groupId, GroupStatus.CONFIG_ING.getCode(), context.getOperator());
Review Comment:
```suggestion
groupService.updateStatus(groupId, GroupStatus.CONFIG_ING.getCode(), operator);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org