You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/09/10 07:36:34 UTC

[GitHub] [servicecomb-java-chassis] david6969xin opened a new pull request #2566: [#2558] HttpServerOptions.maxFormAttributeSize can be configurable

david6969xin opened a new pull request #2566:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2566


   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter edited a comment on pull request #2566: [SCB-2333] HttpServerOptions.maxFormAttributeSize can be configurable

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2566:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2566#issuecomment-916712982


   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2566](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (59c756f) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/68e52289206aaf1c36981b60335df05fa64df302?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68e5228) will **increase** coverage by `0.03%`.
   > The diff coverage is `97.40%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2566      +/-   ##
   ============================================
   + Coverage     77.63%   77.67%   +0.03%     
   - Complexity     1420     1426       +6     
   ============================================
     Files          1597     1598       +1     
     Lines         42464    42546      +82     
     Branches       3578     3583       +5     
   ============================================
   + Hits          32966    33046      +80     
   + Misses         8001     8000       -1     
   - Partials       1497     1500       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...b/demo/springmvc/client/TestFormRequestSchema.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLXNwcmluZ212Yy9zcHJpbmdtdmMtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9kZW1vL3NwcmluZ212Yy9jbGllbnQvVGVzdEZvcm1SZXF1ZXN0U2NoZW1hLmphdmE=) | `93.54% <93.54%> (ø)` | |
   | [...ecomb/transport/rest/vertx/RestServerVerticle.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhbnNwb3J0cy90cmFuc3BvcnQtcmVzdC90cmFuc3BvcnQtcmVzdC12ZXJ0eC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvdHJhbnNwb3J0L3Jlc3QvdmVydHgvUmVzdFNlcnZlclZlcnRpY2xlLmphdmE=) | `69.12% <100.00%> (+2.46%)` | :arrow_up: |
   | [...vicecomb/transport/rest/vertx/TransportConfig.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhbnNwb3J0cy90cmFuc3BvcnQtcmVzdC90cmFuc3BvcnQtcmVzdC12ZXJ0eC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvdHJhbnNwb3J0L3Jlc3QvdmVydHgvVHJhbnNwb3J0Q29uZmlnLmphdmE=) | `97.77% <100.00%> (+1.28%)` | :arrow_up: |
   | [...thentication/consumer/RSAConsumerTokenManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1wdWJsaWNrZXktYXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvYXV0aGVudGljYXRpb24vY29uc3VtZXIvUlNBQ29uc3VtZXJUb2tlbk1hbmFnZXIuamF2YQ==) | `70.96% <0.00%> (-6.46%)` | :arrow_down: |
   | [...b/core/invocation/timeout/PassingTimeStrategy.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9pbnZvY2F0aW9uL3RpbWVvdXQvUGFzc2luZ1RpbWVTdHJhdGVneS5qYXZh) | `94.44% <0.00%> (-5.56%)` | :arrow_down: |
   | [...he/servicecomb/foundation/common/net/NetUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL25ldC9OZXRVdGlscy5qYXZh) | `62.99% <0.00%> (-1.58%)` | :arrow_down: |
   | [...ger/generator/core/AbstractOperationGenerator.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3dhZ2dlci9zd2FnZ2VyLWdlbmVyYXRvci9nZW5lcmF0b3ItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc3dhZ2dlci9nZW5lcmF0b3IvY29yZS9BYnN0cmFjdE9wZXJhdGlvbkdlbmVyYXRvci5qYXZh) | `88.37% <0.00%> (-0.48%)` | :arrow_down: |
   | [...egistry/client/http/ServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1NlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `71.26% <0.00%> (+0.38%)` | :arrow_up: |
   | [.../servicecomb/registry/discovery/DiscoveryTree.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvZGlzY292ZXJ5L0Rpc2NvdmVyeVRyZWUuamF2YQ==) | `100.00% <0.00%> (+3.50%)` | :arrow_up: |
   | ... and [1 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [68e5228...59c756f](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] david6969xin commented on a change in pull request #2566: [#2558] HttpServerOptions.maxFormAttributeSize can be configurable

Posted by GitBox <gi...@apache.org>.
david6969xin commented on a change in pull request #2566:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2566#discussion_r706947318



##########
File path: transports/transport-rest/transport-rest-vertx/src/main/java/org/apache/servicecomb/transport/rest/vertx/RestServerVerticle.java
##########
@@ -253,10 +253,22 @@ private HttpServerOptions createDefaultHttpServerOptions() {
     serverOptions.setIdleTimeout(TransportConfig.getConnectionIdleTimeoutInSeconds());
     serverOptions.setCompressionSupported(TransportConfig.getCompressed());
     serverOptions.setMaxHeaderSize(TransportConfig.getMaxHeaderSize());
+    serverOptions.setMaxFormAttributeSize(TransportConfig.getFormAttributeSize());
+    serverOptions.setCompressionLevel(TransportConfig.getCompressionLevel());
+    serverOptions.setMaxChunkSize(TransportConfig.getMaxChunkSize());
+    serverOptions.setDecompressionSupported(TransportConfig.getDecompression());

Review comment:
       ok




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter edited a comment on pull request #2566: [SCB-2333] HttpServerOptions.maxFormAttributeSize can be configurable

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2566:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2566#issuecomment-916712982


   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2566](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7e12fc0) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/68e52289206aaf1c36981b60335df05fa64df302?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68e5228) will **increase** coverage by `0.02%`.
   > The diff coverage is `92.94%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2566      +/-   ##
   ============================================
   + Coverage     77.63%   77.66%   +0.02%     
   - Complexity     1420     1427       +7     
   ============================================
     Files          1597     1598       +1     
     Lines         42464    42574     +110     
     Branches       3578     3588      +10     
   ============================================
   + Hits          32966    33064      +98     
   - Misses         8001     8007       +6     
   - Partials       1497     1503       +6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ecomb/demo/jaxrs/client/TestFormRequestSchema.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLWpheHJzL2pheHJzLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZGVtby9qYXhycy9jbGllbnQvVGVzdEZvcm1SZXF1ZXN0U2NoZW1hLmphdmE=) | `83.78% <83.78%> (ø)` | |
   | [...port/rest/client/http/DefaultHttpClientFilter.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhbnNwb3J0cy90cmFuc3BvcnQtcmVzdC90cmFuc3BvcnQtcmVzdC1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3RyYW5zcG9ydC9yZXN0L2NsaWVudC9odHRwL0RlZmF1bHRIdHRwQ2xpZW50RmlsdGVyLmphdmE=) | `96.77% <100.00%> (ø)` | |
   | [...ecomb/transport/rest/vertx/RestServerVerticle.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhbnNwb3J0cy90cmFuc3BvcnQtcmVzdC90cmFuc3BvcnQtcmVzdC12ZXJ0eC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvdHJhbnNwb3J0L3Jlc3QvdmVydHgvUmVzdFNlcnZlclZlcnRpY2xlLmphdmE=) | `69.12% <100.00%> (+2.46%)` | :arrow_up: |
   | [...vicecomb/transport/rest/vertx/TransportConfig.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhbnNwb3J0cy90cmFuc3BvcnQtcmVzdC90cmFuc3BvcnQtcmVzdC12ZXJ0eC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvdHJhbnNwb3J0L3Jlc3QvdmVydHgvVHJhbnNwb3J0Q29uZmlnLmphdmE=) | `97.77% <100.00%> (+1.28%)` | :arrow_up: |
   | [...n/java/org/apache/servicecomb/AuthHandlerBoot.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1wdWJsaWNrZXktYXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvQXV0aEhhbmRsZXJCb290LmphdmE=) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
   | [...thentication/provider/RSAProviderTokenManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1wdWJsaWNrZXktYXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvYXV0aGVudGljYXRpb24vcHJvdmlkZXIvUlNBUHJvdmlkZXJUb2tlbk1hbmFnZXIuamF2YQ==) | `72.72% <0.00%> (-5.66%)` | :arrow_down: |
   | [...b/core/invocation/timeout/PassingTimeStrategy.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9pbnZvY2F0aW9uL3RpbWVvdXQvUGFzc2luZ1RpbWVTdHJhdGVneS5qYXZh) | `94.44% <0.00%> (-5.56%)` | :arrow_down: |
   | [...ger/generator/core/AbstractOperationGenerator.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3dhZ2dlci9zd2FnZ2VyLWdlbmVyYXRvci9nZW5lcmF0b3ItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc3dhZ2dlci9nZW5lcmF0b3IvY29yZS9BYnN0cmFjdE9wZXJhdGlvbkdlbmVyYXRvci5qYXZh) | `88.37% <0.00%> (-0.48%)` | :arrow_down: |
   | [...eregistry/config/ServiceRegistryConfigBuilder.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NvbmZpZy9TZXJ2aWNlUmVnaXN0cnlDb25maWdCdWlsZGVyLmphdmE=) | `83.07% <0.00%> (-0.13%)` | :arrow_down: |
   | [...client/http/RegistryWatchHttpClientOptionsSPI.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1JlZ2lzdHJ5V2F0Y2hIdHRwQ2xpZW50T3B0aW9uc1NQSS5qYXZh) | `100.00% <0.00%> (ø)` | |
   | ... and [4 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [68e5228...7e12fc0](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter edited a comment on pull request #2566: [SCB-2333] HttpServerOptions.maxFormAttributeSize can be configurable

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2566:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2566#issuecomment-916712982


   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2566](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (edd613d) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/68e52289206aaf1c36981b60335df05fa64df302?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68e5228) will **increase** coverage by `0.02%`.
   > The diff coverage is `90.36%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2566      +/-   ##
   ============================================
   + Coverage     77.63%   77.65%   +0.02%     
   - Complexity     1420     1427       +7     
   ============================================
     Files          1597     1598       +1     
     Lines         42464    42572     +108     
     Branches       3578     3588      +10     
   ============================================
   + Hits          32966    33061      +95     
   - Misses         8001     8008       +7     
   - Partials       1497     1503       +6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ecomb/demo/jaxrs/client/TestFormRequestSchema.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLWpheHJzL2pheHJzLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZGVtby9qYXhycy9jbGllbnQvVGVzdEZvcm1SZXF1ZXN0U2NoZW1hLmphdmE=) | `77.14% <77.14%> (ø)` | |
   | [...port/rest/client/http/DefaultHttpClientFilter.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhbnNwb3J0cy90cmFuc3BvcnQtcmVzdC90cmFuc3BvcnQtcmVzdC1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3RyYW5zcG9ydC9yZXN0L2NsaWVudC9odHRwL0RlZmF1bHRIdHRwQ2xpZW50RmlsdGVyLmphdmE=) | `96.77% <100.00%> (ø)` | |
   | [...ecomb/transport/rest/vertx/RestServerVerticle.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhbnNwb3J0cy90cmFuc3BvcnQtcmVzdC90cmFuc3BvcnQtcmVzdC12ZXJ0eC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvdHJhbnNwb3J0L3Jlc3QvdmVydHgvUmVzdFNlcnZlclZlcnRpY2xlLmphdmE=) | `69.12% <100.00%> (+2.46%)` | :arrow_up: |
   | [...vicecomb/transport/rest/vertx/TransportConfig.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhbnNwb3J0cy90cmFuc3BvcnQtcmVzdC90cmFuc3BvcnQtcmVzdC12ZXJ0eC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvdHJhbnNwb3J0L3Jlc3QvdmVydHgvVHJhbnNwb3J0Q29uZmlnLmphdmE=) | `97.77% <100.00%> (+1.28%)` | :arrow_up: |
   | [...n/java/org/apache/servicecomb/AuthHandlerBoot.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1wdWJsaWNrZXktYXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvQXV0aEhhbmRsZXJCb290LmphdmE=) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
   | [...thentication/provider/RSAProviderTokenManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1wdWJsaWNrZXktYXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvYXV0aGVudGljYXRpb24vcHJvdmlkZXIvUlNBUHJvdmlkZXJUb2tlbk1hbmFnZXIuamF2YQ==) | `72.72% <0.00%> (-5.66%)` | :arrow_down: |
   | [...he/servicecomb/foundation/common/net/NetUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL25ldC9OZXRVdGlscy5qYXZh) | `62.99% <0.00%> (-1.58%)` | :arrow_down: |
   | [...ger/generator/core/AbstractOperationGenerator.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3dhZ2dlci9zd2FnZ2VyLWdlbmVyYXRvci9nZW5lcmF0b3ItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc3dhZ2dlci9nZW5lcmF0b3IvY29yZS9BYnN0cmFjdE9wZXJhdGlvbkdlbmVyYXRvci5qYXZh) | `88.37% <0.00%> (-0.48%)` | :arrow_down: |
   | [...eregistry/config/ServiceRegistryConfigBuilder.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NvbmZpZy9TZXJ2aWNlUmVnaXN0cnlDb25maWdCdWlsZGVyLmphdmE=) | `83.07% <0.00%> (-0.13%)` | :arrow_down: |
   | [...client/http/RegistryWatchHttpClientOptionsSPI.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1JlZ2lzdHJ5V2F0Y2hIdHRwQ2xpZW50T3B0aW9uc1NQSS5qYXZh) | `100.00% <0.00%> (ø)` | |
   | ... and [5 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [68e5228...edd613d](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] david6969xin commented on a change in pull request #2566: [SCB-2333] HttpServerOptions.maxFormAttributeSize can be configurable

Posted by GitBox <gi...@apache.org>.
david6969xin commented on a change in pull request #2566:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2566#discussion_r707376915



##########
File path: demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/TestFormRequestSchema.java
##########
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.demo.springmvc.client;
+
+import org.apache.servicecomb.demo.CategorizedTestCase;
+import org.apache.servicecomb.demo.TestMgr;
+import org.apache.servicecomb.provider.springmvc.reference.RestTemplateBuilder;
+import org.apache.servicecomb.swagger.invocation.exception.InvocationException;
+import org.springframework.http.HttpEntity;
+import org.springframework.http.HttpHeaders;
+import org.springframework.http.MediaType;
+import org.springframework.http.ResponseEntity;
+import org.springframework.stereotype.Component;
+import org.springframework.util.LinkedMultiValueMap;
+import org.springframework.util.MultiValueMap;
+import org.springframework.web.client.RestTemplate;
+
+
+@Component
+public class TestFormRequestSchema implements CategorizedTestCase {
+
+  @Override
+  public void testRestTransport() throws Exception {
+    testFormRequestFail();
+    testFormRequestSuccess();
+  }
+
+  // formSize is less than default maxFormAttributeSize , success
+  private void testFormRequestSuccess() throws Exception {
+    RestTemplate restTemplate = RestTemplateBuilder.create();
+    HttpHeaders headers = new HttpHeaders();
+    headers.setContentType(MediaType.APPLICATION_FORM_URLENCODED);
+    MultiValueMap<String, String> formData = new LinkedMultiValueMap<>();
+    StringBuffer stringBuffer = new StringBuffer();
+    for (int i = 0; i < 1024; i++) {
+      stringBuffer.append("a");
+    }
+    formData.add("formData", String.valueOf(stringBuffer));
+    HttpEntity<MultiValueMap<String, String>> requestEntity = new HttpEntity<>(formData, headers);
+    ResponseEntity<String> responseEntity = restTemplate
+        .postForEntity("servicecomb://springmvc/form/formRequest", requestEntity, String.class);
+    TestMgr.check(responseEntity.getBody(), "formRequest success");
+  }
+
+  // formSize is greater than default maxFormAttributeSize , throw exception
+  private void testFormRequestFail() throws Exception {
+    RestTemplate restTemplate = RestTemplateBuilder.create();
+    HttpHeaders headers = new HttpHeaders();
+    headers.setContentType(MediaType.APPLICATION_FORM_URLENCODED);
+    MultiValueMap<String, String> formData = new LinkedMultiValueMap<>();
+    StringBuffer stringBuffer = new StringBuffer();
+    for (int i = 0; i < 4096; i++) {
+      stringBuffer.append("a");
+    }
+    formData.add("formData", String.valueOf(stringBuffer));
+    HttpEntity<MultiValueMap<String, String>> requestEntity = new HttpEntity<>(formData, headers);
+    try {
+      restTemplate.postForEntity("servicecomb://springmvc/form/formRequest", requestEntity, String.class);

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2566: [SCB-2333] HttpServerOptions.maxFormAttributeSize can be configurable

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2566:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2566#discussion_r707259309



##########
File path: demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/TestFormRequestSchema.java
##########
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.demo.springmvc.client;
+
+import org.apache.servicecomb.demo.CategorizedTestCase;
+import org.apache.servicecomb.demo.TestMgr;
+import org.apache.servicecomb.provider.springmvc.reference.RestTemplateBuilder;
+import org.apache.servicecomb.swagger.invocation.exception.InvocationException;
+import org.springframework.http.HttpEntity;
+import org.springframework.http.HttpHeaders;
+import org.springframework.http.MediaType;
+import org.springframework.http.ResponseEntity;
+import org.springframework.stereotype.Component;
+import org.springframework.util.LinkedMultiValueMap;
+import org.springframework.util.MultiValueMap;
+import org.springframework.web.client.RestTemplate;
+
+
+@Component
+public class TestFormRequestSchema implements CategorizedTestCase {
+
+  @Override
+  public void testRestTransport() throws Exception {
+    testFormRequestFail();
+    testFormRequestSuccess();
+  }
+
+  // formSize is less than default maxFormAttributeSize , success
+  private void testFormRequestSuccess() throws Exception {
+    RestTemplate restTemplate = RestTemplateBuilder.create();
+    HttpHeaders headers = new HttpHeaders();
+    headers.setContentType(MediaType.APPLICATION_FORM_URLENCODED);
+    MultiValueMap<String, String> formData = new LinkedMultiValueMap<>();
+    StringBuffer stringBuffer = new StringBuffer();
+    for (int i = 0; i < 1024; i++) {
+      stringBuffer.append("a");
+    }
+    formData.add("formData", String.valueOf(stringBuffer));
+    HttpEntity<MultiValueMap<String, String>> requestEntity = new HttpEntity<>(formData, headers);
+    ResponseEntity<String> responseEntity = restTemplate
+        .postForEntity("servicecomb://springmvc/form/formRequest", requestEntity, String.class);
+    TestMgr.check(responseEntity.getBody(), "formRequest success");
+  }
+
+  // formSize is greater than default maxFormAttributeSize , throw exception
+  private void testFormRequestFail() throws Exception {
+    RestTemplate restTemplate = RestTemplateBuilder.create();
+    HttpHeaders headers = new HttpHeaders();
+    headers.setContentType(MediaType.APPLICATION_FORM_URLENCODED);
+    MultiValueMap<String, String> formData = new LinkedMultiValueMap<>();
+    StringBuffer stringBuffer = new StringBuffer();
+    for (int i = 0; i < 4096; i++) {
+      stringBuffer.append("a");
+    }
+    formData.add("formData", String.valueOf(stringBuffer));
+    HttpEntity<MultiValueMap<String, String>> requestEntity = new HttpEntity<>(formData, headers);
+    try {
+      restTemplate.postForEntity("servicecomb://springmvc/form/formRequest", requestEntity, String.class);

Review comment:
       fail if exception not thrown




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter edited a comment on pull request #2566: [SCB-2333] HttpServerOptions.maxFormAttributeSize can be configurable

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2566:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2566#issuecomment-916712982


   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2566](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e96a5e3) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/68e52289206aaf1c36981b60335df05fa64df302?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68e5228) will **increase** coverage by `0.02%`.
   > The diff coverage is `95.06%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2566      +/-   ##
   ============================================
   + Coverage     77.63%   77.66%   +0.02%     
   - Complexity     1420     1427       +7     
   ============================================
     Files          1597     1598       +1     
     Lines         42464    42570     +106     
     Branches       3578     3588      +10     
   ============================================
   + Hits          32966    33061      +95     
   - Misses         8001     8005       +4     
   - Partials       1497     1504       +7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ecomb/demo/jaxrs/client/TestFormRequestSchema.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLWpheHJzL2pheHJzLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZGVtby9qYXhycy9jbGllbnQvVGVzdEZvcm1SZXF1ZXN0U2NoZW1hLmphdmE=) | `87.87% <87.87%> (ø)` | |
   | [...port/rest/client/http/DefaultHttpClientFilter.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhbnNwb3J0cy90cmFuc3BvcnQtcmVzdC90cmFuc3BvcnQtcmVzdC1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3RyYW5zcG9ydC9yZXN0L2NsaWVudC9odHRwL0RlZmF1bHRIdHRwQ2xpZW50RmlsdGVyLmphdmE=) | `96.77% <100.00%> (ø)` | |
   | [...ecomb/transport/rest/vertx/RestServerVerticle.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhbnNwb3J0cy90cmFuc3BvcnQtcmVzdC90cmFuc3BvcnQtcmVzdC12ZXJ0eC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvdHJhbnNwb3J0L3Jlc3QvdmVydHgvUmVzdFNlcnZlclZlcnRpY2xlLmphdmE=) | `69.12% <100.00%> (+2.46%)` | :arrow_up: |
   | [...vicecomb/transport/rest/vertx/TransportConfig.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhbnNwb3J0cy90cmFuc3BvcnQtcmVzdC90cmFuc3BvcnQtcmVzdC12ZXJ0eC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvdHJhbnNwb3J0L3Jlc3QvdmVydHgvVHJhbnNwb3J0Q29uZmlnLmphdmE=) | `97.77% <100.00%> (+1.28%)` | :arrow_up: |
   | [...n/java/org/apache/servicecomb/AuthHandlerBoot.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1wdWJsaWNrZXktYXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvQXV0aEhhbmRsZXJCb290LmphdmE=) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
   | [...thentication/provider/RSAProviderTokenManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1wdWJsaWNrZXktYXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvYXV0aGVudGljYXRpb24vcHJvdmlkZXIvUlNBUHJvdmlkZXJUb2tlbk1hbmFnZXIuamF2YQ==) | `72.72% <0.00%> (-5.66%)` | :arrow_down: |
   | [...he/servicecomb/foundation/common/net/NetUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL25ldC9OZXRVdGlscy5qYXZh) | `62.99% <0.00%> (-1.58%)` | :arrow_down: |
   | [...ger/generator/core/AbstractOperationGenerator.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3dhZ2dlci9zd2FnZ2VyLWdlbmVyYXRvci9nZW5lcmF0b3ItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc3dhZ2dlci9nZW5lcmF0b3IvY29yZS9BYnN0cmFjdE9wZXJhdGlvbkdlbmVyYXRvci5qYXZh) | `88.37% <0.00%> (-0.48%)` | :arrow_down: |
   | [...eregistry/config/ServiceRegistryConfigBuilder.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NvbmZpZy9TZXJ2aWNlUmVnaXN0cnlDb25maWdCdWlsZGVyLmphdmE=) | `83.07% <0.00%> (-0.13%)` | :arrow_down: |
   | [...client/http/RegistryWatchHttpClientOptionsSPI.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1JlZ2lzdHJ5V2F0Y2hIdHRwQ2xpZW50T3B0aW9uc1NQSS5qYXZh) | `100.00% <0.00%> (ø)` | |
   | ... and [4 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [68e5228...e96a5e3](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] david6969xin commented on a change in pull request #2566: [SCB-2333] HttpServerOptions.maxFormAttributeSize can be configurable

Posted by GitBox <gi...@apache.org>.
david6969xin commented on a change in pull request #2566:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2566#discussion_r707256204



##########
File path: demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/TestFormRequestSchema.java
##########
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.demo.springmvc.client;
+
+import org.apache.servicecomb.demo.CategorizedTestCase;
+import org.apache.servicecomb.demo.TestMgr;
+import org.apache.servicecomb.provider.springmvc.reference.RestTemplateBuilder;
+import org.apache.servicecomb.swagger.invocation.exception.InvocationException;
+import org.springframework.http.HttpEntity;
+import org.springframework.http.HttpHeaders;
+import org.springframework.http.MediaType;
+import org.springframework.http.ResponseEntity;
+import org.springframework.stereotype.Component;
+import org.springframework.util.LinkedMultiValueMap;
+import org.springframework.util.MultiValueMap;
+import org.springframework.web.client.RestTemplate;
+
+
+@Component
+public class TestFormRequestSchema implements CategorizedTestCase {
+
+  @Override
+  public void testRestTransport() throws Exception {
+    testFormRequestFail();
+    testFormRequestSuccess();
+    testNormalFormRequestSuccess();
+  }
+
+  // formSize is less than default maxFormAttributeSize , success
+  private void testNormalFormRequestSuccess() throws Exception {
+    RestTemplate restTemplate = RestTemplateBuilder.create();
+    HttpHeaders headers = new HttpHeaders();
+    headers.setContentType(MediaType.APPLICATION_FORM_URLENCODED);
+    MultiValueMap<String, String> formData = new LinkedMultiValueMap<>();
+    StringBuffer stringBuffer = new StringBuffer();
+    for (int i = 0; i < 1024; i++) {
+      stringBuffer.append("a");
+    }
+    formData.add("formData", String.valueOf(stringBuffer));
+    HttpEntity<MultiValueMap<String, String>> requestEntity = new HttpEntity<>(formData, headers);
+    ResponseEntity<String> responseEntity = restTemplate
+        .postForEntity("servicecomb://springmvc/form/formRequest", requestEntity, String.class);
+    TestMgr.check(responseEntity.getBody(), "formRequest success");
+  }
+
+  // formSize is greater than default maxFormAttributeSize , throw exception
+  private void testFormRequestFail() throws Exception {
+    RestTemplate restTemplate = RestTemplateBuilder.create();
+    HttpHeaders headers = new HttpHeaders();
+    headers.setContentType(MediaType.APPLICATION_FORM_URLENCODED);
+    MultiValueMap<String, String> formData = new LinkedMultiValueMap<>();
+    StringBuffer stringBuffer = new StringBuffer();
+    for (int i = 0; i < 3072; i++) {
+      stringBuffer.append("a");
+    }
+    formData.add("formData", String.valueOf(stringBuffer));
+    HttpEntity<MultiValueMap<String, String>> requestEntity = new HttpEntity<>(formData, headers);
+    try {
+      ResponseEntity<String> responseEntity = restTemplate
+          .postForEntity("servicecomb://springmvc/form/formRequest", requestEntity, String.class);
+      TestMgr.check(responseEntity.getBody(), null);
+    } catch (InvocationException e) {
+      TestMgr.check(e.getMessage().equals("Size exceed allowed maximum capacity"), true);
+    }
+  }
+
+  // formSize is greater than default maxFormAttributeSize ,success through external configuration
+  private void testFormRequestSuccess() throws Exception {

Review comment:
       ok，deleted




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] david6969xin commented on a change in pull request #2566: [#2558] HttpServerOptions.maxFormAttributeSize can be configurable

Posted by GitBox <gi...@apache.org>.
david6969xin commented on a change in pull request #2566:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2566#discussion_r706947351



##########
File path: transports/transport-rest/transport-rest-vertx/src/main/java/org/apache/servicecomb/transport/rest/vertx/RestServerVerticle.java
##########
@@ -253,10 +253,22 @@ private HttpServerOptions createDefaultHttpServerOptions() {
     serverOptions.setIdleTimeout(TransportConfig.getConnectionIdleTimeoutInSeconds());
     serverOptions.setCompressionSupported(TransportConfig.getCompressed());
     serverOptions.setMaxHeaderSize(TransportConfig.getMaxHeaderSize());
+    serverOptions.setMaxFormAttributeSize(TransportConfig.getFormAttributeSize());

Review comment:
       ok




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2566: [SCB-2333] HttpServerOptions.maxFormAttributeSize can be configurable

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2566:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2566#discussion_r707239816



##########
File path: demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/TestFormRequestSchema.java
##########
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.demo.springmvc.client;
+
+import org.apache.servicecomb.demo.CategorizedTestCase;
+import org.apache.servicecomb.demo.TestMgr;
+import org.apache.servicecomb.provider.springmvc.reference.RestTemplateBuilder;
+import org.apache.servicecomb.swagger.invocation.exception.InvocationException;
+import org.springframework.http.HttpEntity;
+import org.springframework.http.HttpHeaders;
+import org.springframework.http.MediaType;
+import org.springframework.http.ResponseEntity;
+import org.springframework.stereotype.Component;
+import org.springframework.util.LinkedMultiValueMap;
+import org.springframework.util.MultiValueMap;
+import org.springframework.web.client.RestTemplate;
+
+
+@Component
+public class TestFormRequestSchema implements CategorizedTestCase {
+
+  @Override
+  public void testRestTransport() throws Exception {
+    testFormRequestFail();
+    testFormRequestSuccess();
+    testNormalFormRequestSuccess();
+  }
+
+  // formSize is less than default maxFormAttributeSize , success
+  private void testNormalFormRequestSuccess() throws Exception {
+    RestTemplate restTemplate = RestTemplateBuilder.create();
+    HttpHeaders headers = new HttpHeaders();
+    headers.setContentType(MediaType.APPLICATION_FORM_URLENCODED);
+    MultiValueMap<String, String> formData = new LinkedMultiValueMap<>();
+    StringBuffer stringBuffer = new StringBuffer();
+    for (int i = 0; i < 1024; i++) {
+      stringBuffer.append("a");
+    }
+    formData.add("formData", String.valueOf(stringBuffer));
+    HttpEntity<MultiValueMap<String, String>> requestEntity = new HttpEntity<>(formData, headers);
+    ResponseEntity<String> responseEntity = restTemplate
+        .postForEntity("servicecomb://springmvc/form/formRequest", requestEntity, String.class);
+    TestMgr.check(responseEntity.getBody(), "formRequest success");
+  }
+
+  // formSize is greater than default maxFormAttributeSize , throw exception
+  private void testFormRequestFail() throws Exception {
+    RestTemplate restTemplate = RestTemplateBuilder.create();
+    HttpHeaders headers = new HttpHeaders();
+    headers.setContentType(MediaType.APPLICATION_FORM_URLENCODED);
+    MultiValueMap<String, String> formData = new LinkedMultiValueMap<>();
+    StringBuffer stringBuffer = new StringBuffer();
+    for (int i = 0; i < 3072; i++) {
+      stringBuffer.append("a");
+    }
+    formData.add("formData", String.valueOf(stringBuffer));
+    HttpEntity<MultiValueMap<String, String>> requestEntity = new HttpEntity<>(formData, headers);
+    try {
+      ResponseEntity<String> responseEntity = restTemplate
+          .postForEntity("servicecomb://springmvc/form/formRequest", requestEntity, String.class);
+      TestMgr.check(responseEntity.getBody(), null);
+    } catch (InvocationException e) {
+      TestMgr.check(e.getMessage().equals("Size exceed allowed maximum capacity"), true);
+    }
+  }
+
+  // formSize is greater than default maxFormAttributeSize ,success through external configuration
+  private void testFormRequestSuccess() throws Exception {

Review comment:
       This test case is useless




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter edited a comment on pull request #2566: [SCB-2333] HttpServerOptions.maxFormAttributeSize can be configurable

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2566:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2566#issuecomment-916712982


   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2566](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8a18a64) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/68e52289206aaf1c36981b60335df05fa64df302?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68e5228) will **increase** coverage by `0.02%`.
   > The diff coverage is `86.95%`.
   
   > :exclamation: Current head 8a18a64 differs from pull request most recent head 7e46ee7. Consider uploading reports for the commit 7e46ee7 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2566      +/-   ##
   ============================================
   + Coverage     77.63%   77.65%   +0.02%     
   - Complexity     1420     1427       +7     
   ============================================
     Files          1597     1598       +1     
     Lines         42464    42563      +99     
     Branches       3578     3588      +10     
   ============================================
   + Hits          32966    33052      +86     
   - Misses         8001     8007       +6     
   - Partials       1497     1504       +7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...thentication/provider/RSAProviderTokenManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1wdWJsaWNrZXktYXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvYXV0aGVudGljYXRpb24vcHJvdmlkZXIvUlNBUHJvdmlkZXJUb2tlbk1hbmFnZXIuamF2YQ==) | `72.72% <50.00%> (-5.66%)` | :arrow_down: |
   | [...eregistry/config/ServiceRegistryConfigBuilder.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NvbmZpZy9TZXJ2aWNlUmVnaXN0cnlDb25maWdCdWlsZGVyLmphdmE=) | `83.07% <80.00%> (-0.13%)` | :arrow_down: |
   | [...ecomb/demo/jaxrs/client/TestFormRequestSchema.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLWpheHJzL2pheHJzLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZGVtby9qYXhycy9jbGllbnQvVGVzdEZvcm1SZXF1ZXN0U2NoZW1hLmphdmE=) | `81.08% <81.08%> (ø)` | |
   | [...ger/generator/core/AbstractOperationGenerator.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3dhZ2dlci9zd2FnZ2VyLWdlbmVyYXRvci9nZW5lcmF0b3ItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc3dhZ2dlci9nZW5lcmF0b3IvY29yZS9BYnN0cmFjdE9wZXJhdGlvbkdlbmVyYXRvci5qYXZh) | `88.37% <85.71%> (-0.48%)` | :arrow_down: |
   | [...n/java/org/apache/servicecomb/AuthHandlerBoot.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1wdWJsaWNrZXktYXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvQXV0aEhhbmRsZXJCb290LmphdmE=) | `80.00% <90.90%> (-20.00%)` | :arrow_down: |
   | [...omb/serviceregistry/auth/RBACBootStrapService.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2F1dGgvUkJBQ0Jvb3RTdHJhcFNlcnZpY2UuamF2YQ==) | `8.53% <100.00%> (+3.65%)` | :arrow_up: |
   | [...client/http/RegistryWatchHttpClientOptionsSPI.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1JlZ2lzdHJ5V2F0Y2hIdHRwQ2xpZW50T3B0aW9uc1NQSS5qYXZh) | `100.00% <100.00%> (ø)` | |
   | [.../serviceregistry/config/ServiceRegistryConfig.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NvbmZpZy9TZXJ2aWNlUmVnaXN0cnlDb25maWcuamF2YQ==) | `96.19% <100.00%> (+0.11%)` | :arrow_up: |
   | [...vicecomb/transport/rest/vertx/TransportConfig.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhbnNwb3J0cy90cmFuc3BvcnQtcmVzdC90cmFuc3BvcnQtcmVzdC12ZXJ0eC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvdHJhbnNwb3J0L3Jlc3QvdmVydHgvVHJhbnNwb3J0Q29uZmlnLmphdmE=) | `97.77% <100.00%> (+1.28%)` | :arrow_up: |
   | [...thentication/consumer/RSAConsumerTokenManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1wdWJsaWNrZXktYXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvYXV0aGVudGljYXRpb24vY29uc3VtZXIvUlNBQ29uc3VtZXJUb2tlbk1hbmFnZXIuamF2YQ==) | `70.96% <0.00%> (-6.46%)` | :arrow_down: |
   | ... and [4 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [68e5228...7e46ee7](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2566: [#2558] HttpServerOptions.maxFormAttributeSize can be configurable

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2566:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2566#discussion_r705995339



##########
File path: transports/transport-rest/transport-rest-vertx/src/main/java/org/apache/servicecomb/transport/rest/vertx/RestServerVerticle.java
##########
@@ -253,10 +253,22 @@ private HttpServerOptions createDefaultHttpServerOptions() {
     serverOptions.setIdleTimeout(TransportConfig.getConnectionIdleTimeoutInSeconds());
     serverOptions.setCompressionSupported(TransportConfig.getCompressed());
     serverOptions.setMaxHeaderSize(TransportConfig.getMaxHeaderSize());
+    serverOptions.setMaxFormAttributeSize(TransportConfig.getFormAttributeSize());
+    serverOptions.setCompressionLevel(TransportConfig.getCompressionLevel());
+    serverOptions.setMaxChunkSize(TransportConfig.getMaxChunkSize());
+    serverOptions.setDecompressionSupported(TransportConfig.getDecompression());

Review comment:
       maybe `getDecompressionSupported` method name is better. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2566: [SCB-2333] HttpServerOptions.maxFormAttributeSize can be configurable

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2566:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2566#discussion_r707239120



##########
File path: demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/server/FormRequestSchema.java
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.demo.springmvc.server;
+
+
+import javax.ws.rs.FormParam;
+
+import org.apache.servicecomb.provider.rest.common.RestSchema;
+import org.apache.servicecomb.transport.rest.vertx.TransportConfig;
+import org.springframework.http.MediaType;
+import org.springframework.web.bind.annotation.PostMapping;
+import org.springframework.web.bind.annotation.RequestMapping;
+
+import io.vertx.core.http.HttpServerOptions;
+
+
+@RestSchema(schemaId = "FormRequestSchema")
+@RequestMapping(path = "/form", produces = MediaType.APPLICATION_JSON_VALUE)
+public class FormRequestSchema {
+
+  @PostMapping(path = "/formRequest")
+  public String formRequest(@FormParam("formData") String formData, @FormParam("flag") String flag) throws Exception {
+    if (formData.getBytes().length <= (flag == null ? HttpServerOptions.DEFAULT_MAX_FORM_ATTRIBUTE_SIZE
+        : TransportConfig.getMaxFormAttributeSize())) {
+      return "formRequest success";
+    }
+    return null;

Review comment:
       return "formRequest success"; 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] david6969xin commented on a change in pull request #2566: [SCB-2333] HttpServerOptions.maxFormAttributeSize can be configurable

Posted by GitBox <gi...@apache.org>.
david6969xin commented on a change in pull request #2566:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2566#discussion_r707376562



##########
File path: demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/TestFormRequestSchema.java
##########
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.demo.springmvc.client;
+
+import org.apache.servicecomb.demo.CategorizedTestCase;
+import org.apache.servicecomb.demo.TestMgr;
+import org.apache.servicecomb.provider.springmvc.reference.RestTemplateBuilder;
+import org.apache.servicecomb.swagger.invocation.exception.InvocationException;
+import org.springframework.http.HttpEntity;
+import org.springframework.http.HttpHeaders;
+import org.springframework.http.MediaType;
+import org.springframework.http.ResponseEntity;
+import org.springframework.stereotype.Component;
+import org.springframework.util.LinkedMultiValueMap;
+import org.springframework.util.MultiValueMap;
+import org.springframework.web.client.RestTemplate;
+
+
+@Component
+public class TestFormRequestSchema implements CategorizedTestCase {
+
+  @Override
+  public void testRestTransport() throws Exception {
+    testFormRequestFail();
+    testFormRequestSuccess();
+    testNormalFormRequestSuccess();
+  }
+
+  // formSize is less than default maxFormAttributeSize , success
+  private void testNormalFormRequestSuccess() throws Exception {
+    RestTemplate restTemplate = RestTemplateBuilder.create();
+    HttpHeaders headers = new HttpHeaders();
+    headers.setContentType(MediaType.APPLICATION_FORM_URLENCODED);
+    MultiValueMap<String, String> formData = new LinkedMultiValueMap<>();
+    StringBuffer stringBuffer = new StringBuffer();
+    for (int i = 0; i < 1024; i++) {
+      stringBuffer.append("a");
+    }
+    formData.add("formData", String.valueOf(stringBuffer));
+    HttpEntity<MultiValueMap<String, String>> requestEntity = new HttpEntity<>(formData, headers);
+    ResponseEntity<String> responseEntity = restTemplate
+        .postForEntity("servicecomb://springmvc/form/formRequest", requestEntity, String.class);
+    TestMgr.check(responseEntity.getBody(), "formRequest success");
+  }
+
+  // formSize is greater than default maxFormAttributeSize , throw exception
+  private void testFormRequestFail() throws Exception {
+    RestTemplate restTemplate = RestTemplateBuilder.create();
+    HttpHeaders headers = new HttpHeaders();
+    headers.setContentType(MediaType.APPLICATION_FORM_URLENCODED);
+    MultiValueMap<String, String> formData = new LinkedMultiValueMap<>();
+    StringBuffer stringBuffer = new StringBuffer();
+    for (int i = 0; i < 3072; i++) {

Review comment:
       this value should be greater than configurable value，it just contain value size not key size




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2566: [#2558] HttpServerOptions.maxFormAttributeSize can be configurable

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2566:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2566#discussion_r705995028



##########
File path: transports/transport-rest/transport-rest-vertx/src/main/java/org/apache/servicecomb/transport/rest/vertx/RestServerVerticle.java
##########
@@ -253,10 +253,22 @@ private HttpServerOptions createDefaultHttpServerOptions() {
     serverOptions.setIdleTimeout(TransportConfig.getConnectionIdleTimeoutInSeconds());
     serverOptions.setCompressionSupported(TransportConfig.getCompressed());
     serverOptions.setMaxHeaderSize(TransportConfig.getMaxHeaderSize());
+    serverOptions.setMaxFormAttributeSize(TransportConfig.getFormAttributeSize());

Review comment:
       maybe `getMaxFormAttributeSize` method name is better.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #2566: [#2558] HttpServerOptions.maxFormAttributeSize can be configurable

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2566:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2566#issuecomment-916712982


   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2566](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9172c5f) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/68e52289206aaf1c36981b60335df05fa64df302?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68e5228) will **increase** coverage by `0.02%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2566      +/-   ##
   ============================================
   + Coverage     77.63%   77.66%   +0.02%     
     Complexity     1420     1420              
   ============================================
     Files          1597     1597              
     Lines         42464    42515      +51     
     Branches       3578     3581       +3     
   ============================================
   + Hits          32966    33018      +52     
   + Misses         8001     8000       -1     
     Partials       1497     1497              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ecomb/transport/rest/vertx/RestServerVerticle.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhbnNwb3J0cy90cmFuc3BvcnQtcmVzdC90cmFuc3BvcnQtcmVzdC12ZXJ0eC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvdHJhbnNwb3J0L3Jlc3QvdmVydHgvUmVzdFNlcnZlclZlcnRpY2xlLmphdmE=) | `69.12% <100.00%> (+2.46%)` | :arrow_up: |
   | [...vicecomb/transport/rest/vertx/TransportConfig.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhbnNwb3J0cy90cmFuc3BvcnQtcmVzdC90cmFuc3BvcnQtcmVzdC12ZXJ0eC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvdHJhbnNwb3J0L3Jlc3QvdmVydHgvVHJhbnNwb3J0Q29uZmlnLmphdmE=) | `97.77% <100.00%> (+1.28%)` | :arrow_up: |
   | [...b/core/invocation/timeout/PassingTimeStrategy.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9pbnZvY2F0aW9uL3RpbWVvdXQvUGFzc2luZ1RpbWVTdHJhdGVneS5qYXZh) | `94.44% <0.00%> (-5.56%)` | :arrow_down: |
   | [...ger/generator/core/AbstractOperationGenerator.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3dhZ2dlci9zd2FnZ2VyLWdlbmVyYXRvci9nZW5lcmF0b3ItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc3dhZ2dlci9nZW5lcmF0b3IvY29yZS9BYnN0cmFjdE9wZXJhdGlvbkdlbmVyYXRvci5qYXZh) | `88.37% <0.00%> (-0.48%)` | :arrow_down: |
   | [...egistry/client/http/ServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1NlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `71.26% <0.00%> (+0.38%)` | :arrow_up: |
   | [.../servicecomb/registry/discovery/DiscoveryTree.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvZGlzY292ZXJ5L0Rpc2NvdmVyeVRyZWUuamF2YQ==) | `100.00% <0.00%> (+3.50%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [68e5228...9172c5f](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] david6969xin commented on a change in pull request #2566: [SCB-2333] HttpServerOptions.maxFormAttributeSize can be configurable

Posted by GitBox <gi...@apache.org>.
david6969xin commented on a change in pull request #2566:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2566#discussion_r707255565



##########
File path: demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/server/FormRequestSchema.java
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.demo.springmvc.server;
+
+
+import javax.ws.rs.FormParam;
+
+import org.apache.servicecomb.provider.rest.common.RestSchema;
+import org.apache.servicecomb.transport.rest.vertx.TransportConfig;
+import org.springframework.http.MediaType;
+import org.springframework.web.bind.annotation.PostMapping;
+import org.springframework.web.bind.annotation.RequestMapping;
+
+import io.vertx.core.http.HttpServerOptions;
+
+
+@RestSchema(schemaId = "FormRequestSchema")
+@RequestMapping(path = "/form", produces = MediaType.APPLICATION_JSON_VALUE)
+public class FormRequestSchema {
+
+  @PostMapping(path = "/formRequest")
+  public String formRequest(@FormParam("formData") String formData, @FormParam("flag") String flag) throws Exception {
+    if (formData.getBytes().length <= (flag == null ? HttpServerOptions.DEFAULT_MAX_FORM_ATTRIBUTE_SIZE
+        : TransportConfig.getMaxFormAttributeSize())) {
+      return "formRequest success";
+    }
+    return null;

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2566: [SCB-2333] HttpServerOptions.maxFormAttributeSize can be configurable

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2566:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2566#discussion_r707239320



##########
File path: demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/TestFormRequestSchema.java
##########
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.demo.springmvc.client;
+
+import org.apache.servicecomb.demo.CategorizedTestCase;
+import org.apache.servicecomb.demo.TestMgr;
+import org.apache.servicecomb.provider.springmvc.reference.RestTemplateBuilder;
+import org.apache.servicecomb.swagger.invocation.exception.InvocationException;
+import org.springframework.http.HttpEntity;
+import org.springframework.http.HttpHeaders;
+import org.springframework.http.MediaType;
+import org.springframework.http.ResponseEntity;
+import org.springframework.stereotype.Component;
+import org.springframework.util.LinkedMultiValueMap;
+import org.springframework.util.MultiValueMap;
+import org.springframework.web.client.RestTemplate;
+
+
+@Component
+public class TestFormRequestSchema implements CategorizedTestCase {
+
+  @Override
+  public void testRestTransport() throws Exception {
+    testFormRequestFail();
+    testFormRequestSuccess();
+    testNormalFormRequestSuccess();
+  }
+
+  // formSize is less than default maxFormAttributeSize , success
+  private void testNormalFormRequestSuccess() throws Exception {
+    RestTemplate restTemplate = RestTemplateBuilder.create();
+    HttpHeaders headers = new HttpHeaders();
+    headers.setContentType(MediaType.APPLICATION_FORM_URLENCODED);
+    MultiValueMap<String, String> formData = new LinkedMultiValueMap<>();
+    StringBuffer stringBuffer = new StringBuffer();
+    for (int i = 0; i < 1024; i++) {
+      stringBuffer.append("a");
+    }
+    formData.add("formData", String.valueOf(stringBuffer));
+    HttpEntity<MultiValueMap<String, String>> requestEntity = new HttpEntity<>(formData, headers);
+    ResponseEntity<String> responseEntity = restTemplate
+        .postForEntity("servicecomb://springmvc/form/formRequest", requestEntity, String.class);
+    TestMgr.check(responseEntity.getBody(), "formRequest success");
+  }
+
+  // formSize is greater than default maxFormAttributeSize , throw exception
+  private void testFormRequestFail() throws Exception {
+    RestTemplate restTemplate = RestTemplateBuilder.create();
+    HttpHeaders headers = new HttpHeaders();
+    headers.setContentType(MediaType.APPLICATION_FORM_URLENCODED);
+    MultiValueMap<String, String> formData = new LinkedMultiValueMap<>();
+    StringBuffer stringBuffer = new StringBuffer();
+    for (int i = 0; i < 3072; i++) {

Review comment:
       4096




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] david6969xin commented on a change in pull request #2566: [SCB-2333] HttpServerOptions.maxFormAttributeSize can be configurable

Posted by GitBox <gi...@apache.org>.
david6969xin commented on a change in pull request #2566:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2566#discussion_r707255675



##########
File path: demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/TestFormRequestSchema.java
##########
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.demo.springmvc.client;
+
+import org.apache.servicecomb.demo.CategorizedTestCase;
+import org.apache.servicecomb.demo.TestMgr;
+import org.apache.servicecomb.provider.springmvc.reference.RestTemplateBuilder;
+import org.apache.servicecomb.swagger.invocation.exception.InvocationException;
+import org.springframework.http.HttpEntity;
+import org.springframework.http.HttpHeaders;
+import org.springframework.http.MediaType;
+import org.springframework.http.ResponseEntity;
+import org.springframework.stereotype.Component;
+import org.springframework.util.LinkedMultiValueMap;
+import org.springframework.util.MultiValueMap;
+import org.springframework.web.client.RestTemplate;
+
+
+@Component
+public class TestFormRequestSchema implements CategorizedTestCase {
+
+  @Override
+  public void testRestTransport() throws Exception {
+    testFormRequestFail();
+    testFormRequestSuccess();
+    testNormalFormRequestSuccess();
+  }
+
+  // formSize is less than default maxFormAttributeSize , success
+  private void testNormalFormRequestSuccess() throws Exception {
+    RestTemplate restTemplate = RestTemplateBuilder.create();
+    HttpHeaders headers = new HttpHeaders();
+    headers.setContentType(MediaType.APPLICATION_FORM_URLENCODED);
+    MultiValueMap<String, String> formData = new LinkedMultiValueMap<>();
+    StringBuffer stringBuffer = new StringBuffer();
+    for (int i = 0; i < 1024; i++) {
+      stringBuffer.append("a");
+    }
+    formData.add("formData", String.valueOf(stringBuffer));
+    HttpEntity<MultiValueMap<String, String>> requestEntity = new HttpEntity<>(formData, headers);
+    ResponseEntity<String> responseEntity = restTemplate
+        .postForEntity("servicecomb://springmvc/form/formRequest", requestEntity, String.class);
+    TestMgr.check(responseEntity.getBody(), "formRequest success");
+  }
+
+  // formSize is greater than default maxFormAttributeSize , throw exception
+  private void testFormRequestFail() throws Exception {
+    RestTemplate restTemplate = RestTemplateBuilder.create();
+    HttpHeaders headers = new HttpHeaders();
+    headers.setContentType(MediaType.APPLICATION_FORM_URLENCODED);
+    MultiValueMap<String, String> formData = new LinkedMultiValueMap<>();
+    StringBuffer stringBuffer = new StringBuffer();
+    for (int i = 0; i < 3072; i++) {

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter edited a comment on pull request #2566: [#2558] HttpServerOptions.maxFormAttributeSize can be configurable

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2566:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2566#issuecomment-916712982


   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2566](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (54d3a24) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/68e52289206aaf1c36981b60335df05fa64df302?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68e5228) will **increase** coverage by `0.05%`.
   > The diff coverage is `96.36%`.
   
   > :exclamation: Current head 54d3a24 differs from pull request most recent head f623274. Consider uploading reports for the commit f623274 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2566      +/-   ##
   ============================================
   + Coverage     77.63%   77.69%   +0.05%     
   - Complexity     1420     1428       +8     
   ============================================
     Files          1597     1598       +1     
     Lines         42464    42563      +99     
     Branches       3578     3584       +6     
   ============================================
   + Hits          32966    33068     +102     
   + Misses         8001     7998       -3     
     Partials       1497     1497              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ger/generator/core/AbstractOperationGenerator.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3dhZ2dlci9zd2FnZ2VyLWdlbmVyYXRvci9nZW5lcmF0b3ItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc3dhZ2dlci9nZW5lcmF0b3IvY29yZS9BYnN0cmFjdE9wZXJhdGlvbkdlbmVyYXRvci5qYXZh) | `88.37% <85.71%> (-0.48%)` | :arrow_down: |
   | [...b/demo/springmvc/client/TestFormRequestSchema.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLXNwcmluZ212Yy9zcHJpbmdtdmMtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9kZW1vL3NwcmluZ212Yy9jbGllbnQvVGVzdEZvcm1SZXF1ZXN0U2NoZW1hLmphdmE=) | `95.83% <95.83%> (ø)` | |
   | [...omb/serviceregistry/auth/RBACBootStrapService.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2F1dGgvUkJBQ0Jvb3RTdHJhcFNlcnZpY2UuamF2YQ==) | `8.53% <100.00%> (+3.65%)` | :arrow_up: |
   | [...ecomb/transport/rest/vertx/RestServerVerticle.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhbnNwb3J0cy90cmFuc3BvcnQtcmVzdC90cmFuc3BvcnQtcmVzdC12ZXJ0eC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvdHJhbnNwb3J0L3Jlc3QvdmVydHgvUmVzdFNlcnZlclZlcnRpY2xlLmphdmE=) | `69.12% <100.00%> (+2.46%)` | :arrow_up: |
   | [...vicecomb/transport/rest/vertx/TransportConfig.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhbnNwb3J0cy90cmFuc3BvcnQtcmVzdC90cmFuc3BvcnQtcmVzdC12ZXJ0eC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvdHJhbnNwb3J0L3Jlc3QvdmVydHgvVHJhbnNwb3J0Q29uZmlnLmphdmE=) | `97.77% <100.00%> (+1.28%)` | :arrow_up: |
   | [...b/core/invocation/timeout/PassingTimeStrategy.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9pbnZvY2F0aW9uL3RpbWVvdXQvUGFzc2luZ1RpbWVTdHJhdGVneS5qYXZh) | `94.44% <0.00%> (-5.56%)` | :arrow_down: |
   | [...egistry/client/http/ServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1NlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `71.26% <0.00%> (+0.38%)` | :arrow_up: |
   | [...ache/servicecomb/foundation/common/net/IpPort.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL25ldC9JcFBvcnQuamF2YQ==) | `86.66% <0.00%> (+3.33%)` | :arrow_up: |
   | [.../servicecomb/registry/discovery/DiscoveryTree.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvZGlzY292ZXJ5L0Rpc2NvdmVyeVRyZWUuamF2YQ==) | `100.00% <0.00%> (+3.50%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [68e5228...f623274](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2566?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #2566: [SCB-2333] HttpServerOptions.maxFormAttributeSize can be configurable

Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #2566:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2566


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org