You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/08/25 04:34:55 UTC
[GitHub] XD-DENG edited a comment on issue #3793: [AIRFLOW-2948] Arg check &
better doc - SSHOperator & SFTPOperator
XD-DENG edited a comment on issue #3793: [AIRFLOW-2948] Arg check & better doc - SSHOperator & SFTPOperator
URL: https://github.com/apache/incubator-airflow/pull/3793#issuecomment-415934314
Hi @feng-tao , I have
- Added instance checking for argument `ssh_hook`. If `ssh_hook` given by user is not of class "SSHHook", it would be handled properly.
- Updated the tests for both operators accordingly (covered different combinations of arguments `ssh_hook` and `ssh_conn_id`). Both can pass.
The CI is failing due to:
- test_poke (tests.contrib.sensors.test_aws_redshift_cluster_sensor.`TestAwsRedshiftClusterSensor`) ... ERROR
- test_poke_cluster_not_found (tests.contrib.sensors.test_aws_redshift_cluster_sensor.`TestAwsRedshiftClusterSensor`) ... ERROR
- test_poke_false (tests.contrib.sensors.test_aws_redshift_cluster_sensor.`TestAwsRedshiftClusterSensor`) ... ERROR
None of these test cases were touched in this PR. Seems it's exception like `Unable to locate credentials`. Not sure what is happening. Similar issue is happening to a few other PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services