You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "liming30 (via GitHub)" <gi...@apache.org> on 2023/11/06 06:28:20 UTC
[PR] [flink] fix unstable test: testAsyncCompactionFileDeletedWhenShutdown [incubator-paimon]
liming30 opened a new pull request, #2266:
URL: https://github.com/apache/incubator-paimon/pull/2266
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #2231
<!-- What is the purpose of the change -->
[flink] fix unstable test: testAsyncCompactionFileDeletedWhenShutdown.
In the original implementation, `Thread.sleep(2_000)` is used to wait for the thread pool to finish, which does not strictly guarantee that the thread pool is finished. I modified it to use `ExecutorService#awaitTermination` and increased the timeout to 2 minutes.
### Tests
<!-- List UT and IT cases to verify this change -->
No
### API and Format
<!-- Does this change affect API or storage format -->
No
### Documentation
<!-- Does this change introduce a new feature -->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] fix unstable test: testAsyncCompactionFileDeletedWhenShutdown [incubator-paimon]
Posted by "leaves12138 (via GitHub)" <gi...@apache.org>.
leaves12138 commented on PR #2266:
URL: https://github.com/apache/incubator-paimon/pull/2266#issuecomment-1794266116
this also fixed in https://github.com/apache/incubator-paimon/pull/2245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] fix unstable test: testAsyncCompactionFileDeletedWhenShutdown [incubator-paimon]
Posted by "liming30 (via GitHub)" <gi...@apache.org>.
liming30 commented on PR #2266:
URL: https://github.com/apache/incubator-paimon/pull/2266#issuecomment-1794390631
@leaves12138 It seems that `TaskCanceler` will first interrupt the `executingThread` of the `task`, and the a `TaskInterrupter` will interrupt periodically until the `task` is closed or timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] fix unstable test: testAsyncCompactionFileDeletedWhenShutdown [incubator-paimon]
Posted by "liming30 (via GitHub)" <gi...@apache.org>.
liming30 closed pull request #2266: [flink] fix unstable test: testAsyncCompactionFileDeletedWhenShutdown
URL: https://github.com/apache/incubator-paimon/pull/2266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] fix unstable test: testAsyncCompactionFileDeletedWhenShutdown [incubator-paimon]
Posted by "leaves12138 (via GitHub)" <gi...@apache.org>.
leaves12138 commented on PR #2266:
URL: https://github.com/apache/incubator-paimon/pull/2266#issuecomment-1794366795
> > this also fixed in #2245
>
> @leaves12138 hi, I saw that #2245 is waiting in the `shutdown` of `AppendOnlyTableCompactionWorkerOperator`. If `flink` sends a `cancel` signal to the task, this will interrupt the thread. Is it possible to throw an `InterruptedException`, causing the subsequent logic to fail to execute?
The close method should not receive a Interrupted signal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] fix unstable test: testAsyncCompactionFileDeletedWhenShutdown [incubator-paimon]
Posted by "leaves12138 (via GitHub)" <gi...@apache.org>.
leaves12138 commented on PR #2266:
URL: https://github.com/apache/incubator-paimon/pull/2266#issuecomment-1794961629
> @leaves12138 It seems that `TaskCanceler` will first interrupt the `executingThread` of the `task`, and the a `TaskInterrupter` will interrupt periodically until the `task` is closed or timeout.
you are right, if an interrupt happens, the files will not be deleted .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] fix unstable test: testAsyncCompactionFileDeletedWhenShutdown [incubator-paimon]
Posted by "leaves12138 (via GitHub)" <gi...@apache.org>.
leaves12138 commented on PR #2266:
URL: https://github.com/apache/incubator-paimon/pull/2266#issuecomment-1794264478
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] fix unstable test: testAsyncCompactionFileDeletedWhenShutdown [incubator-paimon]
Posted by "liming30 (via GitHub)" <gi...@apache.org>.
liming30 commented on PR #2266:
URL: https://github.com/apache/incubator-paimon/pull/2266#issuecomment-1794328691
> this also fixed in #2245
@leaves12138 hi, I saw that #2245 is waiting in the `shutdown` of `AppendOnlyTableCompactionWorkerOperator`. If `flink` sends a `cancel` signal to the task, this will interrupt the thread. Is it possible to throw an `InterruptedException`, causing the subsequent logic to fail to execute?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] fix unstable test: testAsyncCompactionFileDeletedWhenShutdown [incubator-paimon]
Posted by "liming30 (via GitHub)" <gi...@apache.org>.
liming30 commented on PR #2266:
URL: https://github.com/apache/incubator-paimon/pull/2266#issuecomment-1797955627
Closed because it has been fixed in #2245.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] fix unstable test: testAsyncCompactionFileDeletedWhenShutdown [incubator-paimon]
Posted by "Aitozi (via GitHub)" <gi...@apache.org>.
Aitozi commented on PR #2266:
URL: https://github.com/apache/incubator-paimon/pull/2266#issuecomment-1800908144
The problem seems still there: https://github.com/Aitozi/incubator-paimon/actions/runs/6792785178/job/18466599312#step:5:410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org