You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by soralee <gi...@git.apache.org> on 2017/04/13 05:12:29 UTC
[GitHub] zeppelin pull request #2248: [ZEPPELIN-2396] eliminate the 'ctrl+L' shortcut...
GitHub user soralee opened a pull request:
https://github.com/apache/zeppelin/pull/2248
[ZEPPELIN-2396] eliminate the 'ctrl+L' shortcut keyboard
### What is this PR for?
This PR is for that eliminate the `ctrl+L` shortcut keyboard. This function is what the ace editor defined.
### What type of PR is it?
[Improvement]
### What is the Jira issue?
* [ZEPPELIN-2396](https://issues.apache.org/jira/browse/ZEPPELIN-2396)
### How should this be tested?
* Press `Ctrl + L` key and check if showing the dialog or not
### Screenshots (if appropriate)
[Before]
[After]
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soralee/zeppelin ZEPPELIN-2396_ctrl_l
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2248.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2248
----
commit 4e1b8465a84099efff077e6767d643ee148a4fad
Author: soralee <so...@zepl.com>
Date: 2017-04-13T04:49:11Z
ZEPPELIN-2396 drop the Ctrl+L shortcut keyboard
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2248: [ZEPPELIN-2396] eliminate the 'ctrl+L' shortcut keyboa...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2248
@1ambda Thanks for review!
Yeah, it's make sense. Let me update `command+L` and the document
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2248: [ZEPPELIN-2396] eliminate the 'ctrl/command+L' keyboar...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2248
LGTM and merge to master if no further discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2248: [ZEPPELIN-2396] eliminate the 'ctrl/command+L' keyboar...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2248
@1ambda I just updated it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2248: [ZEPPELIN-2396] eliminate the 'ctrl+L' shortcut keyboa...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2248
Awesome! It was really annoying. Let me test and comment soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2248: [ZEPPELIN-2396] eliminate the 'ctrl+L' shortcut keyboa...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2248
@soralee I think we need to add this change into https://github.com/apache/zeppelin/blob/master/docs/install/upgrade.md
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2248: [ZEPPELIN-2396] eliminate the 'ctrl/command+L' keyboar...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2248
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2248: [ZEPPELIN-2396] eliminate the 'ctrl+L' shortcut keyboa...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2248
@soralee Doesn't work for OSX users since the binding is `CMD + L` not `CTRL + L` in OSX.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2248: [ZEPPELIN-2396] eliminate the 'ctrl/command+L' ...
Posted by soralee <gi...@git.apache.org>.
Github user soralee closed the pull request at:
https://github.com/apache/zeppelin/pull/2248
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2248: [ZEPPELIN-2396] eliminate the 'ctrl/command+L' keyboar...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2248
Works as described. LGTM except 2 comments I left
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2248: [ZEPPELIN-2396] eliminate the 'ctrl/command+L' ...
Posted by soralee <gi...@git.apache.org>.
GitHub user soralee reopened a pull request:
https://github.com/apache/zeppelin/pull/2248
[ZEPPELIN-2396] eliminate the 'ctrl/command+L' keyboard shortcut
### What is this PR for?
This PR is for that eliminate the `Ctrl/Command+L` shortcut keyboard. This function is what the ace editor defined.
### What type of PR is it?
[Improvement | Document]
### What is the Jira issue?
* [ZEPPELIN-2396](https://issues.apache.org/jira/browse/ZEPPELIN-2396)
### How should this be tested?
* **Improvement** - Press `Ctrl + L` key and check if showing the dialog or not
* **Document** - Run document development mode and check [this document](http://localhost:4000/install/upgrade.html#upgrading-from-zeppelin-07-to-08)
### Screenshots (if appropriate)
[Before]
[After]
[Document]
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes, I did. Please review [this document](http://localhost:4000/install/upgrade.html#upgrading-from-zeppelin-07-to-08) if you run document development mode (localhost:4000)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soralee/zeppelin ZEPPELIN-2396_ctrl_l
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2248.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2248
----
commit 4e1b8465a84099efff077e6767d643ee148a4fad
Author: soralee <so...@zepl.com>
Date: 2017-04-13T04:49:11Z
ZEPPELIN-2396 drop the Ctrl+L shortcut keyboard
commit 5f30fe473b6b893895d038d5d5a3468820c4ad2d
Author: soralee <so...@zepl.com>
Date: 2017-04-14T10:08:34Z
upgrade eliminate keyboard shortcut feature and add document
commit 928f179821642c7ccb4fda5deec6b778322cbd6f
Author: soralee <so...@zepl.com>
Date: 2017-04-15T04:49:04Z
add space between + and who is providing
commit d1f966a36c759a87398d65284afb09d1d8f7bb48
Author: soralee <so...@zepl.com>
Date: 2017-04-15T05:00:42Z
modify document
commit bb0f7d8223d6516e037215c552fcd62792accfb3
Author: soralee <so...@zepl.com>
Date: 2017-04-15T05:01:40Z
modify document
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2248: [ZEPPELIN-2396] eliminate the 'ctrl/command+L' ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2248
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2248: [ZEPPELIN-2396] eliminate the 'ctrl+L' keyboard shortc...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2248
I added `command+L` and changed `Alt` and `Option` feature to flexibly remove some binding shortcut key.
And, I updated the document as your comment.
Could you review again @1ambda ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---