[jira] Commented: (SLING-1338) sling.properties should be trimmed when reading

["Bertrand Delacretaz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828043#action_12828043 ] 

Bertrand Delacretaz commented on SLING-1338:
--------------------------------------------

Properties not trimming values is a major annoyance in my opinion, that regularly surfaces in troubleshooting when people inadvertently leave hard to see spaces (or tabs, or CR/LF conversion leftovers) after values in a properties files, and services that use the values don't trim it.

Relying on trailing spaces for any purpose in properties files meant to be editable by users would be a very bad idea, so I don't see a use case for that.

> sling.properties should be trimmed when reading
> -----------------------------------------------
>
>                 Key: SLING-1338
>                 URL: https://issues.apache.org/jira/browse/SLING-1338
>             Project: Sling
>          Issue Type: Bug
>          Components: Engine
>    Affects Versions: Launchpad Base 2.1.0
>            Reporter: Bertrand Delacretaz
>            Priority: Minor
>
> Values from sling.properties are not trimmed when read by the org.apache.sling.launchpad.base.impl.Sling class.
> This can lead to hard to diagnose problems, and I don't think we need to have leading or trailing spaces in any of those values.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.