You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by user640378 <gi...@git.apache.org> on 2015/06/06 21:34:12 UTC
[GitHub] thrift pull request: Apache Ant is a necessary dependency
GitHub user user640378 opened a pull request:
https://github.com/apache/thrift/pull/513
Apache Ant is a necessary dependency
adding to apt-get command
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/user640378/thrift patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/513.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #513
----
commit 33a9e477f81457556afaf6d2a8a3334f0cd4ba2e
Author: Maurya Talisetti <us...@users.noreply.github.com>
Date: 2015-06-06T19:33:06Z
Apache Ant is a necessary dependency
adding to apt-get command
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Apache Ant is a necessary dependency
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/513#issuecomment-109724783
Hi user<some_random_number>,
thanks for the patch. Unfortunately, and as little the changes are, for a number of reasons we have certain (very minimal) requirements on how to contribute. If you just could [file a JIRA ticket](http://thrift.apache.org/docs/HowToContribute) for the issue (or pick an matching existing one if there is any) and link this PR to it by mentioning the JIRA ticket number somewhere?
That would be really awesome!
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3286: Apache Ant is a necessary depend...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/513
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3286: Apache Ant is a necessary depend...
Posted by user640378 <gi...@git.apache.org>.
Github user user640378 closed the pull request at:
https://github.com/apache/thrift/pull/513
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3286: Apache Ant is a necessary depend...
Posted by user640378 <gi...@git.apache.org>.
GitHub user user640378 reopened a pull request:
https://github.com/apache/thrift/pull/513
THRIFT-3286: Apache Ant is a necessary dependency
adding to apt-get command
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/user640378/thrift patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/513.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #513
----
commit 33a9e477f81457556afaf6d2a8a3334f0cd4ba2e
Author: Maurya Talisetti <us...@users.noreply.github.com>
Date: 2015-06-06T19:33:06Z
Apache Ant is a necessary dependency
adding to apt-get command
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Apache Ant is a necessary dependency
Posted by user640378 <gi...@git.apache.org>.
Github user user640378 commented on the pull request:
https://github.com/apache/thrift/pull/513#issuecomment-109745041
Hi Jens,
Sure, no problem! I'll do that. Since it was a minor change I had thought jira might not be necessary. I'll do it now.
Sent from my iPhone
> On Jun 7, 2015, at 5:14 AM, Jens Geyer <no...@github.com> wrote:
>
> Hi user,
>
> thanks for the patch. Unfortunately, and as little the changes are, for a number of reasons we have certain (very minimal) requirements on how to contribute. If you just could file a JIRA ticket for the issue (or pick an matching existing one if there is any) and link this PR to it by mentioning the JIRA ticket number somewhere?
>
> That would be really awesome!
>
> Thanks!
>
> —
> Reply to this email directly or view it on GitHub.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---