You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by bhavik patel <bh...@gmail.com> on 2017/04/26 11:02:36 UTC
Review Request 58734: RANGER-1546 : Code Improvement To Follow Best
Practices
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58734/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1546
https://issues.apache.org/jira/browse/RANGER-1546
Repository: ranger
Description
-------
Code improvement to follow best practices.
Diffs
-----
agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java 1485c0f
agents-installer/src/main/java/org/apache/ranger/utils/install/PasswordGenerator.java a2c5193
knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java ec08ae8
security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java efc308a
Diff: https://reviews.apache.org/r/58734/diff/1/
Testing
-------
1.Verified Ranger Admin & Ranger KMS on kerberized & SSL enabled environment.
Thanks,
bhavik patel
Re: Review Request 58734: RANGER-1546 : Code Improvement To Follow
Best Practices
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58734/#review173043
-----------------------------------------------------------
In the MiscUtil.authWithKerberos method, the declaration of LoginContext could be moved further down to where it is needed (for example inside "if (!useKeytab) {"). Also I don't see what the point of declaring the finalLoginContext is. Why not just do "loginContext = new LoginContext(...)"?
The Random changes should be backported to 0.7.x as well IMO.
- Colm O hEigeartaigh
On April 26, 2017, 11:02 a.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58734/
> -----------------------------------------------------------
>
> (Updated April 26, 2017, 11:02 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1546
> https://issues.apache.org/jira/browse/RANGER-1546
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Code improvement to follow best practices.
>
>
> Diffs
> -----
>
> agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java 1485c0f
> agents-installer/src/main/java/org/apache/ranger/utils/install/PasswordGenerator.java a2c5193
> knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java ec08ae8
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java efc308a
>
>
> Diff: https://reviews.apache.org/r/58734/diff/1/
>
>
> Testing
> -------
>
> 1.Verified Ranger Admin & Ranger KMS on kerberized & SSL enabled environment.
>
>
> Thanks,
>
> bhavik patel
>
>
Re: Review Request 58734: RANGER-1546 : Code Improvement To Follow
Best Practices
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58734/#review173200
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On April 27, 2017, 5:21 a.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58734/
> -----------------------------------------------------------
>
> (Updated April 27, 2017, 5:21 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1546
> https://issues.apache.org/jira/browse/RANGER-1546
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Code improvement to follow best practices.
>
>
> Diffs
> -----
>
> agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java 1485c0f
> agents-installer/src/main/java/org/apache/ranger/utils/install/PasswordGenerator.java a2c5193
> knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java ec08ae8
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java efc308a
>
>
> Diff: https://reviews.apache.org/r/58734/diff/2/
>
>
> Testing
> -------
>
> 1.Verified Ranger Admin & Ranger KMS on kerberized & SSL enabled environment.
>
>
> Thanks,
>
> bhavik patel
>
>
Re: Review Request 58734: RANGER-1546 : Code Improvement To Follow
Best Practices
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58734/#review173171
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 27, 2017, 5:21 a.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58734/
> -----------------------------------------------------------
>
> (Updated April 27, 2017, 5:21 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1546
> https://issues.apache.org/jira/browse/RANGER-1546
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Code improvement to follow best practices.
>
>
> Diffs
> -----
>
> agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java 1485c0f
> agents-installer/src/main/java/org/apache/ranger/utils/install/PasswordGenerator.java a2c5193
> knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java ec08ae8
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java efc308a
>
>
> Diff: https://reviews.apache.org/r/58734/diff/2/
>
>
> Testing
> -------
>
> 1.Verified Ranger Admin & Ranger KMS on kerberized & SSL enabled environment.
>
>
> Thanks,
>
> bhavik patel
>
>
Re: Review Request 58734: RANGER-1546 : Code Improvement To Follow
Best Practices
Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58734/
-----------------------------------------------------------
(Updated April 27, 2017, 5:21 a.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Changes
-------
Updated Patch as per Colm comments.
Bugs: RANGER-1546
https://issues.apache.org/jira/browse/RANGER-1546
Repository: ranger
Description
-------
Code improvement to follow best practices.
Diffs (updated)
-----
agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java 1485c0f
agents-installer/src/main/java/org/apache/ranger/utils/install/PasswordGenerator.java a2c5193
knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java ec08ae8
security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java efc308a
Diff: https://reviews.apache.org/r/58734/diff/2/
Changes: https://reviews.apache.org/r/58734/diff/1-2/
Testing
-------
1.Verified Ranger Admin & Ranger KMS on kerberized & SSL enabled environment.
Thanks,
bhavik patel