[jira] [Resolved] (ARIES-1358) The PreferredProviderRepository never sets the initialized boolean to true causing it the initialize on every call to the 'findProviders' method

["Thomas Watson (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARIES-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Watson resolved ARIES-1358.
----------------------------------
    Resolution: Won't Fix

Closing as wont fix since I think the latest code fixed the original issue.  I also do not recommend introducing a double check locking pattern here since that as proven to be problematic with the java memory model.

https://en.wikipedia.org/wiki/Double-checked_locking#Usage_in_Java

> The PreferredProviderRepository never sets the initialized boolean to true causing it the initialize on every call to the 'findProviders' method
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: ARIES-1358
>                 URL: https://issues.apache.org/jira/browse/ARIES-1358
>             Project: Aries
>          Issue Type: Improvement
>          Components: Subsystem
>    Affects Versions: subsystem-core-1.2.0, subsystem-2.0.1
>         Environment: windows linux java
>            Reporter: Bas
>            Priority: Trivial
>              Labels: patch
>             Fix For: subsystem-2.0.1, subsystem-core-1.2.0
>
>         Attachments: subsystem-preferredproviderrepository-patch.txt
>
>
> The below is alread solved but it can work unmeasurable faster :) by checking the field before going into synchronized.
> While doing performance analysis we noticed the PreferredProviderRepository is never initialized causing it to re-initalize on every call to the findProviders method. This slows down the install process.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)