You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/05/19 12:50:47 UTC

Review Request 59396: Ambari Infra Manager: add jobs/steps REST API endpoints

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59396/
-----------------------------------------------------------

Review request for Ambari, Laszlo Puskas, Miklos Gergely, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Bugs: AMBARI-21071
    https://issues.apache.org/jira/browse/AMBARI-21071


Repository: ambari


Description
-------

- Added new rest endpoints to manage jobs & steps for infra-manager data/job processing
- Added some wrapper DTO classes to help jakson to serialize objects with cyclic dependency (some models are reimplemented which came from spring-batch admin manager project)
- Added exception mapper for generating the proper responses codes in case of internal exceptions.
- TODO: add unit tests for JobManager class


Diffs
-----

  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/InfraManager.java 656127e 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java 7310626 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/manager/JobManager.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/ExecutionContextResponse.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobDetailsResponse.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionDetailsResponse.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionInfoResponse.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRequest.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRestartRequest.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionStopRequest.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobInstanceDetailsResponse.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobInstanceStartRequest.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobOperationParams.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobRequest.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/PageRequest.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionContextResponse.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionInfoResponse.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionProgressResponse.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionRequest.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/wrapper/JobExecutionData.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/wrapper/StepExecutionData.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobExceptionMapper.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobResource.java 27fed40 


Diff: https://reviews.apache.org/r/59396/diff/1/


Testing
-------

done.


Thanks,

Oliver Szabo


Re: Review Request 59396: Ambari Infra Manager: add jobs/steps REST API endpoints

Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59396/
-----------------------------------------------------------

(Updated May 19, 2017, 8:08 p.m.)


Review request for Ambari, Laszlo Puskas, Miklos Gergely, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Changes
-------

fill exception-status code map only once


Bugs: AMBARI-21071
    https://issues.apache.org/jira/browse/AMBARI-21071


Repository: ambari


Description
-------

- Added new rest endpoints to manage jobs & steps for infra-manager data/job processing
- Added some wrapper DTO classes to help jakson to serialize objects with cyclic dependency (some models are reimplemented which came from spring-batch admin manager project)
- Added exception mapper for generating the proper responses codes in case of internal exceptions.
- TODO: add unit tests for JobManager class


Diffs (updated)
-----

  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/InfraManager.java 656127e 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java 7310626 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/manager/JobManager.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/ExecutionContextResponse.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobDetailsResponse.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionDetailsResponse.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionInfoResponse.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRequest.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRestartRequest.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionStopRequest.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobInstanceDetailsResponse.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobInstanceStartRequest.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobOperationParams.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobRequest.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/PageRequest.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionContextResponse.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionInfoResponse.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionProgressResponse.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionRequest.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/wrapper/JobExecutionData.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/wrapper/StepExecutionData.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobExceptionMapper.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobResource.java 27fed40 


Diff: https://reviews.apache.org/r/59396/diff/3/

Changes: https://reviews.apache.org/r/59396/diff/2-3/


Testing
-------

done.


Thanks,

Oliver Szabo


Re: Review Request 59396: Ambari Infra Manager: add jobs/steps REST API endpoints

Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59396/#review175563
-----------------------------------------------------------




ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobExceptionMapper.java
Lines 59 (patched)
<https://reviews.apache.org/r/59396/#comment248957>

    This map is always the same, thus it should be created as private static final constant, and initialized in a static block.


- Miklos Gergely


On May 19, 2017, 12:52 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59396/
> -----------------------------------------------------------
> 
> (Updated May 19, 2017, 12:52 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Miklos Gergely, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21071
>     https://issues.apache.org/jira/browse/AMBARI-21071
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - Added new rest endpoints to manage jobs & steps for infra-manager data/job processing
> - Added some wrapper DTO classes to help jakson to serialize objects with cyclic dependency (some models are reimplemented which came from spring-batch admin manager project)
> - Added exception mapper for generating the proper responses codes in case of internal exceptions.
> - TODO: add unit tests for JobManager class
> 
> 
> Diffs
> -----
> 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/InfraManager.java 656127e 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java 7310626 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/manager/JobManager.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/ExecutionContextResponse.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobDetailsResponse.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionDetailsResponse.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionInfoResponse.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRequest.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRestartRequest.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionStopRequest.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobInstanceDetailsResponse.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobInstanceStartRequest.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobOperationParams.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobRequest.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/PageRequest.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionContextResponse.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionInfoResponse.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionProgressResponse.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionRequest.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/wrapper/JobExecutionData.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/wrapper/StepExecutionData.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobExceptionMapper.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobResource.java 27fed40 
> 
> 
> Diff: https://reviews.apache.org/r/59396/diff/2/
> 
> 
> Testing
> -------
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>


Re: Review Request 59396: Ambari Infra Manager: add jobs/steps REST API endpoints

Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59396/#review175564
-----------------------------------------------------------


Ship it!




Ship It!

- Miklos Gergely


On May 19, 2017, 12:52 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59396/
> -----------------------------------------------------------
> 
> (Updated May 19, 2017, 12:52 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Miklos Gergely, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21071
>     https://issues.apache.org/jira/browse/AMBARI-21071
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - Added new rest endpoints to manage jobs & steps for infra-manager data/job processing
> - Added some wrapper DTO classes to help jakson to serialize objects with cyclic dependency (some models are reimplemented which came from spring-batch admin manager project)
> - Added exception mapper for generating the proper responses codes in case of internal exceptions.
> - TODO: add unit tests for JobManager class
> 
> 
> Diffs
> -----
> 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/InfraManager.java 656127e 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java 7310626 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/manager/JobManager.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/ExecutionContextResponse.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobDetailsResponse.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionDetailsResponse.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionInfoResponse.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRequest.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRestartRequest.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionStopRequest.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobInstanceDetailsResponse.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobInstanceStartRequest.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobOperationParams.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobRequest.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/PageRequest.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionContextResponse.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionInfoResponse.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionProgressResponse.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionRequest.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/wrapper/JobExecutionData.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/wrapper/StepExecutionData.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobExceptionMapper.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobResource.java 27fed40 
> 
> 
> Diff: https://reviews.apache.org/r/59396/diff/2/
> 
> 
> Testing
> -------
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>


Re: Review Request 59396: Ambari Infra Manager: add jobs/steps REST API endpoints

Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59396/#review175529
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Nettleton


On May 19, 2017, 12:52 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59396/
> -----------------------------------------------------------
> 
> (Updated May 19, 2017, 12:52 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Miklos Gergely, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21071
>     https://issues.apache.org/jira/browse/AMBARI-21071
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - Added new rest endpoints to manage jobs & steps for infra-manager data/job processing
> - Added some wrapper DTO classes to help jakson to serialize objects with cyclic dependency (some models are reimplemented which came from spring-batch admin manager project)
> - Added exception mapper for generating the proper responses codes in case of internal exceptions.
> - TODO: add unit tests for JobManager class
> 
> 
> Diffs
> -----
> 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/InfraManager.java 656127e 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java 7310626 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/manager/JobManager.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/ExecutionContextResponse.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobDetailsResponse.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionDetailsResponse.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionInfoResponse.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRequest.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRestartRequest.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionStopRequest.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobInstanceDetailsResponse.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobInstanceStartRequest.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobOperationParams.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobRequest.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/PageRequest.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionContextResponse.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionInfoResponse.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionProgressResponse.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionRequest.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/wrapper/JobExecutionData.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/wrapper/StepExecutionData.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobExceptionMapper.java PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobResource.java 27fed40 
> 
> 
> Diff: https://reviews.apache.org/r/59396/diff/2/
> 
> 
> Testing
> -------
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>


Re: Review Request 59396: Ambari Infra Manager: add jobs/steps REST API endpoints

Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59396/
-----------------------------------------------------------

(Updated May 19, 2017, 12:52 p.m.)


Review request for Ambari, Laszlo Puskas, Miklos Gergely, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Changes
-------

removed test code


Bugs: AMBARI-21071
    https://issues.apache.org/jira/browse/AMBARI-21071


Repository: ambari


Description
-------

- Added new rest endpoints to manage jobs & steps for infra-manager data/job processing
- Added some wrapper DTO classes to help jakson to serialize objects with cyclic dependency (some models are reimplemented which came from spring-batch admin manager project)
- Added exception mapper for generating the proper responses codes in case of internal exceptions.
- TODO: add unit tests for JobManager class


Diffs (updated)
-----

  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/InfraManager.java 656127e 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java 7310626 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/manager/JobManager.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/ExecutionContextResponse.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobDetailsResponse.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionDetailsResponse.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionInfoResponse.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRequest.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRestartRequest.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionStopRequest.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobInstanceDetailsResponse.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobInstanceStartRequest.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobOperationParams.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobRequest.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/PageRequest.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionContextResponse.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionInfoResponse.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionProgressResponse.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionRequest.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/wrapper/JobExecutionData.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/wrapper/StepExecutionData.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobExceptionMapper.java PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobResource.java 27fed40 


Diff: https://reviews.apache.org/r/59396/diff/2/

Changes: https://reviews.apache.org/r/59396/diff/1-2/


Testing
-------

done.


Thanks,

Oliver Szabo