You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/07/22 12:35:00 UTC

[jira] [Work logged] (MAPREDUCE-7398) Improve TestDFSIO to support different filesystem

     [ https://issues.apache.org/jira/browse/MAPREDUCE-7398?focusedWorklogId=794209&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794209 ]

ASF GitHub Bot logged work on MAPREDUCE-7398:
---------------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Jul/22 12:34
            Start Date: 22/Jul/22 12:34
    Worklog Time Spent: 10m 
      Work Description: steveloughran commented on code in PR #4604:
URL: https://github.com/apache/hadoop/pull/4604#discussion_r927602020


##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/fs/TestDFSIO.java:
##########
@@ -462,20 +463,33 @@ private void runIOTest(
           Path outputDir) throws IOException {
     JobConf job = new JobConf(config, TestDFSIO.class);
 
-    FileInputFormat.setInputPaths(job, getControlDir(config));
+    setInputPaths(job,getControlDir(config));
     job.setInputFormat(SequenceFileInputFormat.class);
 
     job.setMapperClass(mapperClass);
     job.setReducerClass(AccumulatingReducer.class);
 
-    FileOutputFormat.setOutputPath(job, outputDir);
+    job.set(org.apache.hadoop.mapreduce.lib.output.
+            FileOutputFormat.OUTDIR, outputDir.toString());
     job.setOutputKeyClass(Text.class);
     job.setOutputValueClass(Text.class);
     job.setNumReduceTasks(1);
     job.setSpeculativeExecution(false);
     JobClient.runJob(job);
   }
 
+  public static void setInputPaths(JobConf conf, Path... inputPaths) {
+    Path path = inputPaths[0];
+    StringBuffer str = new StringBuffer(StringUtils.escapeString(path.toString()));
+    for(int i = 1; i < inputPaths.length;i++) {

Review Comment:
   could you use java8 streams here?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 794209)
    Time Spent: 0.5h  (was: 20m)

> Improve TestDFSIO to support different filesystem
> -------------------------------------------------
>
>                 Key: MAPREDUCE-7398
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7398
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: benchmarks
>    Affects Versions: 3.3.3
>            Reporter: Vijayakumar Govindasamy
>            Assignee: Vijayakumar Govindasamy
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> TestDFSIO is the tool used for performance benchmarking on Distributed File System. Recently there is a support added for different file system in HDFS. Ex: s3:// (from Amazon), oci:// (from oracle).
>  
> Request is to improve the TestDFSIO code to support newly added filesystem so that it can be used for benchmarking IOPS and Throughput of those filesystems. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org