You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/19 19:45:35 UTC
[GitHub] [spark] MaxGekk opened a new pull request #28873: [SPARK-32021][SQL] Increase precision of seconds and fractions of `make_interval`
MaxGekk opened a new pull request #28873:
URL: https://github.com/apache/spark/pull/28873
### What changes were proposed in this pull request?
Change precision of seconds and its fraction from 8 to 18 to be able to construct intervals of max allowed microseconds value (long).
### Why are the changes needed?
To improve UX of Spark SQL.
### Does this PR introduce _any_ user-facing change?
Yes
### How was this patch tested?
- Add tests to IntervalExpressionsSuite
- Add an example to the `MakeInterval` expression
- Add tests to `interval.sql`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28873: [SPARK-32021][SQL] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28873:
URL: https://github.com/apache/spark/pull/28873#issuecomment-646920751
**[Test build #124301 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124301/testReport)** for PR 28873 at commit [`3764477`](https://github.com/apache/spark/commit/376447782460cabd206dee59e0668b1af96c7683).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28873: [SPARK-32021][SQL] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28873:
URL: https://github.com/apache/spark/pull/28873#issuecomment-646864410
**[Test build #124297 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124297/testReport)** for PR 28873 at commit [`9dae775`](https://github.com/apache/spark/commit/9dae775b82ce3576bfdb363f47613365d1234287).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28873: [SPARK-32021][SQL] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28873:
URL: https://github.com/apache/spark/pull/28873#issuecomment-646864503
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28873: [SPARK-32021][SQL] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28873:
URL: https://github.com/apache/spark/pull/28873#issuecomment-646867906
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #28873: [SPARK-32021][SQL] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #28873:
URL: https://github.com/apache/spark/pull/28873
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28873: [SPARK-32021][SQL] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28873:
URL: https://github.com/apache/spark/pull/28873#issuecomment-646867588
**[Test build #124301 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124301/testReport)** for PR 28873 at commit [`3764477`](https://github.com/apache/spark/commit/376447782460cabd206dee59e0668b1af96c7683).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28873: [SPARK-32021][SQL] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28873:
URL: https://github.com/apache/spark/pull/28873#issuecomment-646836672
**[Test build #124297 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124297/testReport)** for PR 28873 at commit [`9dae775`](https://github.com/apache/spark/commit/9dae775b82ce3576bfdb363f47613365d1234287).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28873: [SPARK-32021][SQL] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28873:
URL: https://github.com/apache/spark/pull/28873#issuecomment-646864503
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28873: [SPARK-32021][SQL] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28873:
URL: https://github.com/apache/spark/pull/28873#issuecomment-646864512
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124297/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28873: [SPARK-32021][SQL] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28873:
URL: https://github.com/apache/spark/pull/28873#issuecomment-646923926
Could you make a backporting PR to branch-3.0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28873: [SPARK-32021][SQL] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28873:
URL: https://github.com/apache/spark/pull/28873#issuecomment-646867906
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28873: [SPARK-32021][SQL] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28873:
URL: https://github.com/apache/spark/pull/28873#issuecomment-646872136
Thank you for pinging me, @MaxGekk .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #28873: [SPARK-32021][SQL] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #28873:
URL: https://github.com/apache/spark/pull/28873#issuecomment-646963674
@dongjoon-hyun This is the backport https://github.com/apache/spark/pull/28878
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28873: [SPARK-32021][SQL] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28873:
URL: https://github.com/apache/spark/pull/28873#issuecomment-646920959
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28873: [SPARK-32021][SQL] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28873:
URL: https://github.com/apache/spark/pull/28873#issuecomment-646837091
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28873: [SPARK-32021][SQL] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28873:
URL: https://github.com/apache/spark/pull/28873#issuecomment-646836672
**[Test build #124297 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124297/testReport)** for PR 28873 at commit [`9dae775`](https://github.com/apache/spark/commit/9dae775b82ce3576bfdb363f47613365d1234287).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28873: [SPARK-32021][SQL] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #28873:
URL: https://github.com/apache/spark/pull/28873#issuecomment-646923926
Could you make a backporting PR to branch-3.0? We need to regenerate some files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28873: [SPARK-32021][SQL] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28873:
URL: https://github.com/apache/spark/pull/28873#issuecomment-646867588
**[Test build #124301 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124301/testReport)** for PR 28873 at commit [`3764477`](https://github.com/apache/spark/commit/376447782460cabd206dee59e0668b1af96c7683).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28873: [SPARK-32021][SQL] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28873:
URL: https://github.com/apache/spark/pull/28873#issuecomment-646837091
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #28873: [SPARK-32021][SQL] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #28873:
URL: https://github.com/apache/spark/pull/28873#issuecomment-646860019
@dongjoon-hyun @juliuszsompolski Please, review this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28873: [SPARK-32021][SQL] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28873:
URL: https://github.com/apache/spark/pull/28873#issuecomment-646920959
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org