[GitHub] [druid] clintropolis commented on pull request #13787: Python Druid API for use in notebooks

["clintropolis (via GitHub)" <gi...@apache.org>]

clintropolis commented on PR #13787:
URL: https://github.com/apache/druid/pull/13787#issuecomment-1446900556

   drive by comment: maybe there should be tests for this library if we are going to encourage people to use it? (not to say that this necessarily needs to block merging)
   
   we do have some python tests that run for the old 'should we run this test' script that travis was using, https://github.com/apache/druid/blob/master/.github/workflows/static-checks.yml#L64 which runs https://github.com/apache/druid/blob/master/check_test_suite_test.py (not sure this is useful)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org