[jira] [Commented] (AIRFLOW-6243) Optimize NamedHivePartitionSensor to reduce Hive metastore poke load

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995253#comment-16995253 ] 

ASF GitHub Bot commented on AIRFLOW-6243:
-----------------------------------------

YingboWang commented on pull request #6810: [AIRFLOW-6243]Optimize NamedHivePartitionSensor poke
URL: https://github.com/apache/airflow/pull/6810
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-6243
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   Optimize NamedHivePartitionSensor:
   
   Existing poke function:
   Each poke will poke all partitions in NamedHivePartitionSensor.partition_names. If there are 10 partitions and 9 of these partitions landed, the poke will keep poking 10 partitions until the last one landed. 
   
   Optimization:
   Return false when the first not landed partition detected by poke_partition function. Save the index for this partition as the poke_start_index.  Do not try to poke partitions after that.
   In each round of poke, the sensor will start with the partition at poke_start_index which implies the partition was not landed before. If the partition still not landed, sensor will return without creating more traffic to the hive metastore. Thus avoid overloading the metastore by repeatedly poking landed partitions in all executes.
   
   Assume the number of partition_names is n, the poke times before all partitions landed is T. 
     For existing poke function: the poke_partition function will be called **n * T** times 
     For optimized poke function:  poke_partition function will be called **n + T** times in most cases.
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   @KevinYang21 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Optimize NamedHivePartitionSensor to reduce Hive metastore poke load 
> ---------------------------------------------------------------------
>
>                 Key: AIRFLOW-6243
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6243
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: operators
>    Affects Versions: 1.10.6
>            Reporter: Yingbo Wang
>            Assignee: Yingbo Wang
>            Priority: Major
>
> Change the way NamedHivePartitionSensor poke to reduce redundant queries to hive matestore.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)