You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2026/06/25 03:12:12 UTC
[Impala-ASF-CR] IMPALA-13946: Turn on allow catalog cache op from masked users by default
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24510
Change subject: IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
......................................................................
IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
Most of the users turn this on to resolve the performance regression on
INVALIDATE and REFRESH commands. The regression is due to additional
metadata loading if the table is unloaded in catalogd. Though this is
resolved by IMPALA-14703, i.e. don't need metadata loading anymore,
checking table masking policies is still an additional work. Setting
allow_catalog_cache_op_from_masked_users to true skips this check.
Test Changes:
- Moved the negative test (test_block_metadata_update) to
TestRangerIndependent since it now requires restarting the cluster
with the flag off. Also mirrored it to test on both catalog modes.
- Moved the positive tests, test_allow_metadata_update_legacy_catalog
and test_allow_metadata_update_local_catalog to
TestRangerLocalCatalog and TestRangerLegacyCatalog respectively since
they don't need cluster restart now.
- For FE tests that depend on this flag to be false, explicitly set it
before the tests.
Tests
- Ran CORE tests
Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
---
M be/src/service/frontend.cc
M fe/src/main/java/org/apache/impala/service/BackendConfig.java
M fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/authorization/ranger/RangerAuditLogTest.java
M tests/authorization/test_ranger.py
5 files changed, 62 insertions(+), 40 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/24510/1
--
To view, visit http://gerrit.cloudera.org:8080/24510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
Gerrit-Change-Number: 24510
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-13946: Turn on allow catalog cache op from masked users by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24510 )
Change subject: IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
Gerrit-Change-Number: 24510
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Jun 2026 13:20:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13946: Turn on allow catalog cache op from masked users by default
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24510 )
Change subject: IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/24510/2/tests/authorization/test_ranger.py
File tests/authorization/test_ranger.py:
http://gerrit.cloudera.org:8080/#/c/24510/2/tests/authorization/test_ranger.py@1314
PS2, Line 1314:
This still require cold start so would be impacted if running with other tests using the same cluster. Changed to keep this positive test in TestRangerIndependent.
--
To view, visit http://gerrit.cloudera.org:8080/24510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
Gerrit-Change-Number: 24510
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Jun 2026 08:56:30 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13946: Turn on allow catalog cache op from masked users by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24510 )
Change subject: IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/23043/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
Gerrit-Change-Number: 24510
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 27 Jun 2026 02:25:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13946: Turn on allow catalog cache op from masked users by default
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24510 )
Change subject: IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
......................................................................
Patch Set 4: Code-Review+2
LGTM!
--
To view, visit http://gerrit.cloudera.org:8080/24510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
Gerrit-Change-Number: 24510
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Jun 2026 08:40:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13946: Turn on allow catalog cache op from masked users by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24510 )
Change subject: IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/23034/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
Gerrit-Change-Number: 24510
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Jun 2026 02:38:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13946: Turn on allow catalog cache op from masked users by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24510 )
Change subject: IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13666/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/24510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
Gerrit-Change-Number: 24510
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Jun 2026 08:56:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13946: Turn on allow catalog cache op from masked users by default
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Fang-Yu Rao, Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24510
to look at the new patch set (#3).
Change subject: IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
......................................................................
IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
Most of the users turn this on to resolve the performance regression on
INVALIDATE and REFRESH commands. The regression is due to additional
metadata loading if the table is unloaded in catalogd. Though this is
resolved by IMPALA-14703, i.e. don't need metadata loading anymore,
checking table masking policies is still an additional work. Setting
allow_catalog_cache_op_from_masked_users to true skips this check.
Test Changes:
- Moved the negative test (test_block_metadata_update) to
TestRangerIndependent since it now requires restarting the cluster
with the flag off. Also mirrored it to test on both catalog modes.
- Moved the positive tests, test_allow_metadata_update_legacy_catalog
and test_allow_metadata_update_local_catalog to
TestRangerLocalCatalog and TestRangerLegacyCatalog respectively since
they don't need cluster restart now.
- Modified _test_allow_catalog_cache_op_from_masked_users since it's
not running at cold start anymore.
- For FE tests that depend on this flag to be false, explicitly set it
before the tests.
Tests
- Ran CORE tests
Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
---
M be/src/service/frontend.cc
M fe/src/main/java/org/apache/impala/service/BackendConfig.java
M fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/authorization/ranger/RangerAuditLogTest.java
M tests/authorization/test_ranger.py
5 files changed, 63 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/24510/3
--
To view, visit http://gerrit.cloudera.org:8080/24510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
Gerrit-Change-Number: 24510
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-13946: Turn on allow catalog cache op from masked users by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24510 )
Change subject: IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
Gerrit-Change-Number: 24510
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Jun 2026 07:47:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13946: Turn on allow catalog cache op from masked users by default
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24510 )
Change subject: IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/24510/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/24510/3//COMMIT_MSG@20
PS3, Line 20: For FE tests that depend on this flag to be false, explicitly set it
: before the tests.
> They are not moved in the lateset PS. Stale comment?
Oh, forgot to update this.. Done.
http://gerrit.cloudera.org:8080/#/c/24510/3//COMMIT_MSG@24
PS3, Line 24: Ran CORE tests
> Not in the latest PS. Stale comment?
Done
--
To view, visit http://gerrit.cloudera.org:8080/24510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
Gerrit-Change-Number: 24510
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 27 Jun 2026 02:04:29 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13946: Turn on allow catalog cache op from masked users by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24510 )
Change subject: IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13675/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/24510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
Gerrit-Change-Number: 24510
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Jun 2026 03:27:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13946: Turn on allow catalog cache op from masked users by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24510 )
Change subject: IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
......................................................................
IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
Most of the users turn this on to resolve the performance regression on
INVALIDATE and REFRESH commands. The regression is due to additional
metadata loading if the table is unloaded in catalogd. Though this is
resolved by IMPALA-14703, i.e. don't need metadata loading anymore,
checking table masking policies is still an additional work. Setting
allow_catalog_cache_op_from_masked_users to true skips this check.
Test Changes:
- Moved the negative test (test_block_metadata_update) to
TestRangerIndependent since it now requires restarting the cluster
with the flag off. Also mirrored it to test on both catalog modes.
- For FE tests that depend on this flag to be false, explicitly set it
before the tests.
Tests
- Ran CORE tests
Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
Reviewed-on: http://gerrit.cloudera.org:8080/24510
Reviewed-by: Zoltan Borok-Nagy <bo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/service/frontend.cc
M fe/src/main/java/org/apache/impala/service/BackendConfig.java
M fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/authorization/ranger/RangerAuditLogTest.java
M tests/authorization/test_ranger.py
5 files changed, 63 insertions(+), 32 deletions(-)
Approvals:
Zoltan Borok-Nagy: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/24510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
Gerrit-Change-Number: 24510
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-13946: Turn on allow catalog cache op from masked users by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24510 )
Change subject: IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13660/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/24510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
Gerrit-Change-Number: 24510
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jun 2026 03:57:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13946: Turn on allow catalog cache op from masked users by default
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Fang-Yu Rao, Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24510
to look at the new patch set (#2).
Change subject: IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
......................................................................
IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
Most of the users turn this on to resolve the performance regression on
INVALIDATE and REFRESH commands. The regression is due to additional
metadata loading if the table is unloaded in catalogd. Though this is
resolved by IMPALA-14703, i.e. don't need metadata loading anymore,
checking table masking policies is still an additional work. Setting
allow_catalog_cache_op_from_masked_users to true skips this check.
Test Changes:
- Moved the negative test (test_block_metadata_update) to
TestRangerIndependent since it now requires restarting the cluster
with the flag off. Also mirrored it to test on both catalog modes.
- Moved the positive tests, test_allow_metadata_update_legacy_catalog
and test_allow_metadata_update_local_catalog to
TestRangerLocalCatalog and TestRangerLegacyCatalog respectively since
they don't need cluster restart now.
- Modified _test_allow_catalog_cache_op_from_masked_users since it's
not running at cold start anymore.
- For FE tests that depend on this flag to be false, explicitly set it
before the tests.
Tests
- Ran CORE tests
Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
---
M be/src/service/frontend.cc
M fe/src/main/java/org/apache/impala/service/BackendConfig.java
M fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/authorization/ranger/RangerAuditLogTest.java
M tests/authorization/test_ranger.py
5 files changed, 65 insertions(+), 42 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/24510/2
--
To view, visit http://gerrit.cloudera.org:8080/24510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
Gerrit-Change-Number: 24510
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-13946: Turn on allow catalog cache op from masked users by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24510 )
Change subject: IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13665/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/24510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
Gerrit-Change-Number: 24510
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Jun 2026 02:54:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13946: Turn on allow catalog cache op from masked users by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24510 )
Change subject: IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13665/
--
To view, visit http://gerrit.cloudera.org:8080/24510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
Gerrit-Change-Number: 24510
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Jun 2026 07:08:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13946: Turn on allow catalog cache op from masked users by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24510 )
Change subject: IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13660/
--
To view, visit http://gerrit.cloudera.org:8080/24510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
Gerrit-Change-Number: 24510
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jun 2026 08:28:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13946: Turn on allow catalog cache op from masked users by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24510 )
Change subject: IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/23006/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
Gerrit-Change-Number: 24510
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jun 2026 03:35:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13946: Turn on allow catalog cache op from masked users by default
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24510 )
Change subject: IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/24510/1/tests/authorization/test_ranger.py
File tests/authorization/test_ranger.py:
http://gerrit.cloudera.org:8080/#/c/24510/1/tests/authorization/test_ranger.py@1304
PS1, Line 1304: self.execute_query_expect_success(
It's not cold start anymore since turning on the flag is the default now. The test runs in TestRangerLegacyCatalog and TestRangerLocalCatalog which only restarts the cluster once per class (not per method).
Changed this to explicitly invalidate the table using admin_client.
--
To view, visit http://gerrit.cloudera.org:8080/24510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
Gerrit-Change-Number: 24510
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Jun 2026 02:16:29 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13946: Turn on allow catalog cache op from masked users by default
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Fang-Yu Rao, Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24510
to look at the new patch set (#4).
Change subject: IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
......................................................................
IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
Most of the users turn this on to resolve the performance regression on
INVALIDATE and REFRESH commands. The regression is due to additional
metadata loading if the table is unloaded in catalogd. Though this is
resolved by IMPALA-14703, i.e. don't need metadata loading anymore,
checking table masking policies is still an additional work. Setting
allow_catalog_cache_op_from_masked_users to true skips this check.
Test Changes:
- Moved the negative test (test_block_metadata_update) to
TestRangerIndependent since it now requires restarting the cluster
with the flag off. Also mirrored it to test on both catalog modes.
- For FE tests that depend on this flag to be false, explicitly set it
before the tests.
Tests
- Ran CORE tests
Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
---
M be/src/service/frontend.cc
M fe/src/main/java/org/apache/impala/service/BackendConfig.java
M fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/authorization/ranger/RangerAuditLogTest.java
M tests/authorization/test_ranger.py
5 files changed, 63 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/24510/4
--
To view, visit http://gerrit.cloudera.org:8080/24510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
Gerrit-Change-Number: 24510
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-13946: Turn on allow catalog cache op from masked users by default
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24510 )
Change subject: IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Thanks for working on this!
http://gerrit.cloudera.org:8080/#/c/24510/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/24510/3//COMMIT_MSG@20
PS3, Line 20: Moved the positive tests, test_allow_metadata_update_legacy_catalog
: and test_allow_metadata_update_local_catalog
They are not moved in the lateset PS. Stale comment?
http://gerrit.cloudera.org:8080/#/c/24510/3//COMMIT_MSG@24
PS3, Line 24: Modified _test_allow_catalog_cache_op_from_masked_users
Not in the latest PS. Stale comment?
--
To view, visit http://gerrit.cloudera.org:8080/24510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
Gerrit-Change-Number: 24510
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Jun 2026 15:02:13 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13946: Turn on allow catalog cache op from masked users by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24510 )
Change subject: IMPALA-13946: Turn on allow_catalog_cache_op_from_masked_users by default
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/23037/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d3be4467c6dddf5d9cbe1f68e1a19555b3f9359
Gerrit-Change-Number: 24510
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Jun 2026 09:17:50 +0000
Gerrit-HasComments: No