You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Sudheer Vinukonda (JIRA)" <ji...@apache.org> on 2015/07/06 16:53:05 UTC
[jira] [Comment Edited] (TS-3693) Move 100-continue logic to read
client header for intercept plugins
[ https://issues.apache.org/jira/browse/TS-3693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615112#comment-14615112 ]
Sudheer Vinukonda edited comment on TS-3693 at 7/6/15 2:52 PM:
---------------------------------------------------------------
[~bcall]: I haven't seen any response to my questions/concerns on the PR https://github.com/apache/trafficserver/pull/216?
https://github.com/apache/trafficserver/pull/216?#issuecomment-111531431
Seeing now that you have merged the code, it seems that you don't think that is an issue. Even so, would you mind answering it here and/or on the PR with the concern and why you think that's not a problem?
was (Author: sudheerv):
[~bcall]: I haven't seen any response to my questions/concerns on the PR https://github.com/apache/trafficserver/pull/216?
Seeing now that you have merged the code, it seems that you don't think that is an issue. Even so, would you mind answering it here and/or on the PR with the concern and why you think that's not a problem?
> Move 100-continue logic to read client header for intercept plugins
> -------------------------------------------------------------------
>
> Key: TS-3693
> URL: https://issues.apache.org/jira/browse/TS-3693
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP
> Reporter: Bryan Call
> Assignee: Bryan Call
> Labels: yahoo
> Fix For: 6.1.0
>
>
> From https://github.com/apache/trafficserver/pull/216 :
> Currently, ATS handles "Expect: 100-continue" header in HttpSM::state_send_server_request_header. In intercept plugin case, ATS may have no chance to run into this logic, it handles the header in a later point - HttpSM::state_send_server_request_header. I did not take this into account when I wrote the first patch. Now we have an intercept plugin use case in yahoo, and I think we need to move the handle logic some earlier, right after finish parsing the client request header.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)