You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2025/03/24 16:13:13 UTC

(commons-statistics) 04/11: Sonar fix: replace lambda with method reference

This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-statistics.git

commit ef2a76908042bf9d69ae53447874978042c05cc9
Author: Alex Herbert <ah...@apache.org>
AuthorDate: Mon Mar 24 15:36:44 2025 +0000

    Sonar fix: replace lambda with method reference
---
 .../commons/statistics/descriptive/QuantileTest.java     | 16 ++++++++--------
 .../statistics/descriptive/StatisticResultTest.java      | 12 ++++++------
 2 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/commons-statistics-descriptive/src/test/java/org/apache/commons/statistics/descriptive/QuantileTest.java b/commons-statistics-descriptive/src/test/java/org/apache/commons/statistics/descriptive/QuantileTest.java
index 06ea4cf..47c62fd 100644
--- a/commons-statistics-descriptive/src/test/java/org/apache/commons/statistics/descriptive/QuantileTest.java
+++ b/commons-statistics-descriptive/src/test/java/org/apache/commons/statistics/descriptive/QuantileTest.java
@@ -211,18 +211,18 @@ class QuantileTest {
             for (int j = 0; j < p.length; j++) {
                 if (f1 != null) {
                     assertEqualsOrExactlyEqual(expected[i][j], f1.evaluate(m, values.clone(), p[j]), delta,
-                        () -> type.toString());
+                        type::toString);
                 }
                 assertEqualsOrExactlyEqual(expected[i][j], fn.evaluate(m, values.clone(), new double[] {p[j]})[0], delta,
-                    () -> type.toString());
+                    type::toString);
             }
             // Bulk quantiles
             if (delta < 0) {
                 Assertions.assertArrayEquals(expected[i], fn.evaluate(m, values.clone(), p),
-                    () -> type.toString());
+                    type::toString);
             } else {
                 Assertions.assertArrayEquals(expected[i], fn.evaluate(m, values.clone(), p), delta,
-                    () -> type.toString());
+                    type::toString);
             }
         }
     }
@@ -557,18 +557,18 @@ class QuantileTest {
             for (int j = 0; j < p.length; j++) {
                 if (f1 != null) {
                     assertEqualsOrExactlyEqual(expected[i][j], f1.evaluate(m, values.clone(), p[j]), delta,
-                        () -> type.toString());
+                        type::toString);
                 }
                 assertEqualsOrExactlyEqual(expected[i][j], fn.evaluate(m, values.clone(), new double[] {p[j]})[0], delta,
-                    () -> type.toString());
+                    type::toString);
             }
             // Bulk quantiles
             if (delta < 0) {
                 Assertions.assertArrayEquals(expected[i], fn.evaluate(m, values.clone(), p),
-                    () -> type.toString());
+                    type::toString);
             } else {
                 Assertions.assertArrayEquals(expected[i], fn.evaluate(m, values.clone(), p), delta,
-                    () -> type.toString());
+                    type::toString);
             }
         }
     }
diff --git a/commons-statistics-descriptive/src/test/java/org/apache/commons/statistics/descriptive/StatisticResultTest.java b/commons-statistics-descriptive/src/test/java/org/apache/commons/statistics/descriptive/StatisticResultTest.java
index a6a13af..87638f2 100644
--- a/commons-statistics-descriptive/src/test/java/org/apache/commons/statistics/descriptive/StatisticResultTest.java
+++ b/commons-statistics-descriptive/src/test/java/org/apache/commons/statistics/descriptive/StatisticResultTest.java
@@ -57,9 +57,9 @@ final class StatisticResultTest {
     @ValueSource(doubles = {Double.NaN, Double.POSITIVE_INFINITY, Double.NEGATIVE_INFINITY})
     void testNonFinite(double x) {
         final StatisticResult r = () -> x;
-        Assertions.assertThrows(ArithmeticException.class, () -> r.getAsInt(), "int result: " + x);
-        Assertions.assertThrows(ArithmeticException.class, () -> r.getAsLong(), "long result: " + x);
-        Assertions.assertThrows(ArithmeticException.class, () -> r.getAsBigInteger(), "BigInteger result: " + x);
+        Assertions.assertThrows(ArithmeticException.class, r::getAsInt, "int result: " + x);
+        Assertions.assertThrows(ArithmeticException.class, r::getAsLong, "long result: " + x);
+        Assertions.assertThrows(ArithmeticException.class, r::getAsBigInteger, "BigInteger result: " + x);
     }
 
     @ParameterizedTest
@@ -92,7 +92,7 @@ final class StatisticResultTest {
     void testNonRepresentableInt(double x) {
         final StatisticResult r = () -> x;
         final BigDecimal expected = round(x);
-        Assertions.assertThrows(ArithmeticException.class, () -> r.getAsInt(), () -> "int result: " + x);
+        Assertions.assertThrows(ArithmeticException.class, r::getAsInt, () -> "int result: " + x);
         Assertions.assertEquals(expected.longValue(), r.getAsLong(), () -> "long result: " + x);
         Assertions.assertEquals(expected.toBigInteger(), r.getAsBigInteger(), () -> "BigInteger result: " + x);
     }
@@ -108,8 +108,8 @@ final class StatisticResultTest {
     void testNonRepresentableLong(double x) {
         final StatisticResult r = () -> x;
         final BigDecimal expected = round(x);
-        Assertions.assertThrows(ArithmeticException.class, () -> r.getAsInt(), () -> "int result: " + x);
-        Assertions.assertThrows(ArithmeticException.class, () -> r.getAsLong(), () -> "long result: " + x);
+        Assertions.assertThrows(ArithmeticException.class, r::getAsInt, () -> "int result: " + x);
+        Assertions.assertThrows(ArithmeticException.class, r::getAsLong, () -> "long result: " + x);
         Assertions.assertEquals(expected.toBigInteger(), r.getAsBigInteger(), () -> "BigInteger result: " + x);
     }